From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Torgue Subject: Re: [PATCH 0/2] pinctrl: stm32: add suspend/resume management Date: Mon, 27 May 2019 18:17:20 +0200 Message-ID: <7c83e2e1-d5bc-0190-4795-a324a000a5c3@st.com> References: <1557474150-19618-1-git-send-email-alexandre.torgue@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij , Benjamin Gaignard Cc: Maxime Coquelin , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-stm32@st-md-mailman.stormreply.com List-Id: linux-gpio@vger.kernel.org Hi Linus On 5/24/19 1:24 PM, Linus Walleij wrote: > On Fri, May 10, 2019 at 9:42 AM Alexandre Torgue > wrote: > >> During power sequence, GPIO hardware registers could be lost if the power >> supply is switched off. Each device using pinctrl API is in charge of >> managing pins during suspend/resume sequences. But for pins used as gpio or >> irq stm32 pinctrl driver has to save the hardware configuration. >> Each register will be saved at runtime and restored during resume sequence. > > Both patches applied. > > On the same pinctrl devel branch is also Benjamin's patches to support > the "link_consumers" property on the pin controller descriptor to > enable links from pin control consumers back to their pin controller > suppliers, especially important for STMFX. > > Would you please check if it work fine if you turn on this feature > for the SoC STM32 pin controller? I just tested with Benjamin's patches and set "link_consumers" property for STM32 pinctrl. No changes on boot (except extra logs for each probe) and no changes on power tests too. regards alex > > I am working a bit on refining the patches, so I want to enable testing > with some SoC pin controllers as well and possibly make the > behavior default. > > Yours, > Linus Walleij > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DAC1C04AB3 for ; Mon, 27 May 2019 16:17:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 716152147A for ; Mon, 27 May 2019 16:17:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="syGD5pLw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbfE0QRg (ORCPT ); Mon, 27 May 2019 12:17:36 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:10662 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726207AbfE0QRg (ORCPT ); Mon, 27 May 2019 12:17:36 -0400 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4RGGj9F003553; Mon, 27 May 2019 18:17:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=8ub46LPrPqf6PivEatMxnOo+wOKNgOZwMhOATPEAYDc=; b=syGD5pLwRFIXk0Tl+AIThayna8PwIFezSNCwIIZOt0mX9lodsFkGdt+orN5H+UZVnOSk qe/pkZrdWPB0m3JmrfOZ0cZ4/WmXpU29D0Xx3AVIy3ECUCR6CB1dXazEh7rq269VvKTQ PggH4NMGxYxUfGN3IwLSatIuGh1y3Gc8hb9ZgpwjaKmziaFV+q0KlsSD2KypkeodSsh5 S6qqftIpJfpzRd2APAvp7H+/QmP+B6l0AfMacZkanppKGnmrReV9ihQSvjFySiBcZ9zj JtzbcdbzljWxPw3nhEFVBmfp45rzjj+1+lwEnCnOPvdBbQgqpoNt4WYrwPF+U5Aqzxj4 /A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2sptu9m574-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 27 May 2019 18:17:22 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AF83534; Mon, 27 May 2019 16:17:21 +0000 (GMT) Received: from Webmail-eu.st.com (gpxdag3node5.st.com [10.75.127.72]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8E8334F30; Mon, 27 May 2019 16:17:21 +0000 (GMT) Received: from [10.48.0.204] (10.75.127.50) by GPXDAG3NODE5.st.com (10.75.127.72) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 27 May 2019 18:17:20 +0200 Subject: Re: [PATCH 0/2] pinctrl: stm32: add suspend/resume management To: Linus Walleij , Benjamin Gaignard CC: Maxime Coquelin , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Linux ARM , References: <1557474150-19618-1-git-send-email-alexandre.torgue@st.com> From: Alexandre Torgue Message-ID: <7c83e2e1-d5bc-0190-4795-a324a000a5c3@st.com> Date: Mon, 27 May 2019 18:17:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To GPXDAG3NODE5.st.com (10.75.127.72) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-27_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus On 5/24/19 1:24 PM, Linus Walleij wrote: > On Fri, May 10, 2019 at 9:42 AM Alexandre Torgue > wrote: > >> During power sequence, GPIO hardware registers could be lost if the power >> supply is switched off. Each device using pinctrl API is in charge of >> managing pins during suspend/resume sequences. But for pins used as gpio or >> irq stm32 pinctrl driver has to save the hardware configuration. >> Each register will be saved at runtime and restored during resume sequence. > > Both patches applied. > > On the same pinctrl devel branch is also Benjamin's patches to support > the "link_consumers" property on the pin controller descriptor to > enable links from pin control consumers back to their pin controller > suppliers, especially important for STMFX. > > Would you please check if it work fine if you turn on this feature > for the SoC STM32 pin controller? I just tested with Benjamin's patches and set "link_consumers" property for STM32 pinctrl. No changes on boot (except extra logs for each probe) and no changes on power tests too. regards alex > > I am working a bit on refining the patches, so I want to enable testing > with some SoC pin controllers as well and possibly make the > behavior default. > > Yours, > Linus Walleij > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E4D8C04AB3 for ; Mon, 27 May 2019 16:17:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FBCA21530 for ; Mon, 27 May 2019 16:17:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qjwpgbei"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="syGD5pLw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FBCA21530 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ds7UVT+jvaspBPptZ4bgnBfWguBCWyh6xIt1biml0iw=; b=qjwpgbei99JozXTJ2AuLO1fuK frF9KJdUf/2A+Kj+NeM3Ka9ni/VAwiGNYSfUQiAG73UXB+M0Oc9u0bIN92mb7ovshcc3fgJP1oAIV KYrpG/0fpmclp6TiIHzXarr5n2Of/DQQA/woFlJA9OILAfAngnaQuWTXnjUJxdT6bc7Fj5rQ8A2Tk pWlLMZVm5KSLUsUn3R8ujCDD8JlbDXh4pMbp0fpkg/a+sjpqnQ7Eh2JFTQO4a2FxHgS23e6Ow9Ypu NuzzX9S0xa4iR7Z90ojc6/eOkZbvbrQcdmjRHx0MbzXZeLOPY4fIyRrKEjgprlZDIHUnvq5SO9eKj grOGzgekg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVIJb-0000Lm-Pq; Mon, 27 May 2019 16:17:35 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVIJU-00007l-GS for linux-arm-kernel@lists.infradead.org; Mon, 27 May 2019 16:17:33 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4RGGj9F003553; Mon, 27 May 2019 18:17:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=8ub46LPrPqf6PivEatMxnOo+wOKNgOZwMhOATPEAYDc=; b=syGD5pLwRFIXk0Tl+AIThayna8PwIFezSNCwIIZOt0mX9lodsFkGdt+orN5H+UZVnOSk qe/pkZrdWPB0m3JmrfOZ0cZ4/WmXpU29D0Xx3AVIy3ECUCR6CB1dXazEh7rq269VvKTQ PggH4NMGxYxUfGN3IwLSatIuGh1y3Gc8hb9ZgpwjaKmziaFV+q0KlsSD2KypkeodSsh5 S6qqftIpJfpzRd2APAvp7H+/QmP+B6l0AfMacZkanppKGnmrReV9ihQSvjFySiBcZ9zj JtzbcdbzljWxPw3nhEFVBmfp45rzjj+1+lwEnCnOPvdBbQgqpoNt4WYrwPF+U5Aqzxj4 /A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2sptu9m574-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 27 May 2019 18:17:22 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AF83534; Mon, 27 May 2019 16:17:21 +0000 (GMT) Received: from Webmail-eu.st.com (gpxdag3node5.st.com [10.75.127.72]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8E8334F30; Mon, 27 May 2019 16:17:21 +0000 (GMT) Received: from [10.48.0.204] (10.75.127.50) by GPXDAG3NODE5.st.com (10.75.127.72) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 27 May 2019 18:17:20 +0200 Subject: Re: [PATCH 0/2] pinctrl: stm32: add suspend/resume management To: Linus Walleij , Benjamin Gaignard References: <1557474150-19618-1-git-send-email-alexandre.torgue@st.com> From: Alexandre Torgue Message-ID: <7c83e2e1-d5bc-0190-4795-a324a000a5c3@st.com> Date: Mon, 27 May 2019 18:17:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To GPXDAG3NODE5.st.com (10.75.127.72) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-27_08:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_091729_653992_C98AECD0 X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus On 5/24/19 1:24 PM, Linus Walleij wrote: > On Fri, May 10, 2019 at 9:42 AM Alexandre Torgue > wrote: > >> During power sequence, GPIO hardware registers could be lost if the power >> supply is switched off. Each device using pinctrl API is in charge of >> managing pins during suspend/resume sequences. But for pins used as gpio or >> irq stm32 pinctrl driver has to save the hardware configuration. >> Each register will be saved at runtime and restored during resume sequence. > > Both patches applied. > > On the same pinctrl devel branch is also Benjamin's patches to support > the "link_consumers" property on the pin controller descriptor to > enable links from pin control consumers back to their pin controller > suppliers, especially important for STMFX. > > Would you please check if it work fine if you turn on this feature > for the SoC STM32 pin controller? I just tested with Benjamin's patches and set "link_consumers" property for STM32 pinctrl. No changes on boot (except extra logs for each probe) and no changes on power tests too. regards alex > > I am working a bit on refining the patches, so I want to enable testing > with some SoC pin controllers as well and possibly make the > behavior default. > > Yours, > Linus Walleij > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel