From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH net 2/7] virtio_net: Don't call free_old_xmit_skbs for
	xdp_frames
Date: Thu, 17 Jan 2019 20:39:22 +0800
Message-ID: <7c8955f5-cd38-c26f-9932-0aa0be573b4e__44699.2514342584$1547754949$gmane$org@redhat.com>
References: <1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
	<1547724045-2726-3-git-send-email-makita.toshiaki@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <virtualization-bounces@lists.linux-foundation.org>
In-Reply-To: <1547724045-2726-3-git-send-email-makita.toshiaki@lab.ntt.co.jp>
Content-Language: en-US
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
To: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>, "David S. Miller" <davem@davemloft.net>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>, virtualization@lists.linux-foundation.org
List-Id: virtualization@lists.linuxfoundation.org

Ck9uIDIwMTkvMS8xNyDkuIvljYg3OjIwLCBUb3NoaWFraSBNYWtpdGEgd3JvdGU6Cj4gV2hlbiBu
YXBpX3R4IGlzIGVuYWJsZWQsIHZpcnRuZXRfcG9sbF9jbGVhbnR4KCkgY2FsbGVkCj4gZnJlZV9v
bGRfeG1pdF9za2JzKCkgZXZlbiBmb3IgeGRwIHNlbmQgcXVldWUuCj4gVGhpcyBpcyBib2d1cyBz
aW5jZSB0aGUgcXVldWUgaGFzIHhkcF9mcmFtZXMsIG5vdCBza19idWZmcywgdGh1cyBtYW5nbGVk
Cj4gZGV2aWNlIHR4IGJ5dGVzIGNvdW50ZXJzIGJlY2F1c2Ugc2tiLT5sZW4gaXMgbWVhbmluZ2xl
c3MgdmFsdWUsIGFuZCBldmVuCj4gdHJpZ2dlcmVkIG9vcHMgZHVlIHRvIGdlbmVyYWwgcHJvdGVj
dGlvbiBmYXVsdCBvbiBmcmVlaW5nIHRoZW0uCj4KPiBTaW5jZSB4ZHAgc2VuZCBxdWV1ZXMgZG8g
bm90IGFxdWlyZSBsb2Nrcywgb2xkIHhkcF9mcmFtZXMgc2hvdWxkIGJlCj4gZnJlZWQgb25seSBp
biB2aXJ0bmV0X3hkcF94bWl0KCksIHNvIGp1c3Qgc2tpcCBmcmVlX29sZF94bWl0X3NrYnMoKSBm
b3IKPiB4ZHAgc2VuZCBxdWV1ZXMuCj4KPiBTaW1pbGFybHkgdmlydG5ldF9wb2xsX3R4KCkgY2Fs
bGVkIGZyZWVfb2xkX3htaXRfc2ticygpLiBUaGlzIE5BUEkKPiBoYW5kbGVyIGlzIGNhbGxlZCBl
dmVuIHdpdGhvdXQgY2FsbGluZyBzdGFydF94bWl0KCkgYmVjYXVzZSBjYiBmb3IgdHggaXMKPiBi
eSBkZWZhdWx0IGVuYWJsZWQuIE9uY2UgdGhlIGhhbmRsZXIgaXMgY2FsbGVkLCBpdCBlbmFibGVk
IHRoZSBjYiBhZ2FpbiwKPiBhbmQgdGhlbiB0aGUgaGFuZGxlciB3b3VsZCBiZSBjYWxsZWQgYWdh
aW4uIFdlIGRvbid0IG5lZWQgdGhpcyBoYW5kbGVyCj4gZm9yIFhEUCwgc28gZG9uJ3QgZW5hYmxl
IGNiIGFzIHdlbGwgYXMgbm90IGNhbGxpbmcgZnJlZV9vbGRfeG1pdF9za2JzKCkuCj4KPiBBbHNv
LCB3ZSBuZWVkIHRvIGRpc2FibGUgdHggTkFQSSB3aGVuIGRpc2FibGluZyBYRFAsIHNvCj4gdmly
dG5ldF9wb2xsX3R4KCkgY2FuIHNhZmVseSBhY2Nlc3MgY3Vycl9xdWV1ZV9wYWlycyBhbmQKPiB4
ZHBfcXVldWVfcGFpcnMsIHdoaWNoIGFyZSBub3QgYXRvbWljYWxseSB1cGRhdGVkIHdoaWxlIGRp
c2FibGluZyBYRFAuCgoKSSBzdWdnZXN0IHRvIHNwbGl0IHRoaXMgaW50byBhbm90aGVyIHBhdGNo
IG9yIHNxdWFzaCB0aGlzIHBhcnQgdG8gcGF0Y2ggMS4KCk90aGVyIGxvb2tzIGdvb2QuCgpUaGFu
a3MKCgo+Cj4gRml4ZXM6IGI5MmYxZTY3NTFhNiAoInZpcnRpby1uZXQ6IHRyYW5zbWl0IG5hcGki
KQo+IEZpeGVzOiA3YjA0MTFlZjRhYTYgKCJ2aXJ0aW8tbmV0OiBjbGVhbiB0eCBkZXNjcmlwdG9y
cyBmcm9tIHJ4IG5hcGkiKQo+IFNpZ25lZC1vZmYtYnk6IFRvc2hpYWtpIE1ha2l0YSA8bWFraXRh
LnRvc2hpYWtpQGxhYi5udHQuY28uanA+Cj4gLS0tCj4gICBkcml2ZXJzL25ldC92aXJ0aW9fbmV0
LmMgfCA0OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0K
PiAgIDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPgo+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMgYi9kcml2ZXJzL25ldC92aXJ0
aW9fbmV0LmMKPiBpbmRleCBhMDhkYTllLi43ZDM1ZTZkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv
bmV0L3ZpcnRpb19uZXQuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+IEBAIC0x
MzU4LDYgKzEzNTgsMTYgQEAgc3RhdGljIHZvaWQgZnJlZV9vbGRfeG1pdF9za2JzKHN0cnVjdCBz
ZW5kX3F1ZXVlICpzcSkKPiAgIAl1NjRfc3RhdHNfdXBkYXRlX2VuZCgmc3EtPnN0YXRzLnN5bmNw
KTsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgYm9vbCBpc194ZHBfcmF3X2J1ZmZlcl9xdWV1ZShzdHJ1
Y3QgdmlydG5ldF9pbmZvICp2aSwgaW50IHEpCj4gK3sKPiArCWlmIChxIDwgKHZpLT5jdXJyX3F1
ZXVlX3BhaXJzIC0gdmktPnhkcF9xdWV1ZV9wYWlycykpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsJ
ZWxzZSBpZiAocSA8IHZpLT5jdXJyX3F1ZXVlX3BhaXJzKQo+ICsJCXJldHVybiB0cnVlOwo+ICsJ
ZWxzZQo+ICsJCXJldHVybiBmYWxzZTsKPiArfQo+ICsKPiAgIHN0YXRpYyB2b2lkIHZpcnRuZXRf
cG9sbF9jbGVhbnR4KHN0cnVjdCByZWNlaXZlX3F1ZXVlICpycSkKPiAgIHsKPiAgIAlzdHJ1Y3Qg
dmlydG5ldF9pbmZvICp2aSA9IHJxLT52cS0+dmRldi0+cHJpdjsKPiBAQCAtMTM2NSw3ICsxMzc1
LDcgQEAgc3RhdGljIHZvaWQgdmlydG5ldF9wb2xsX2NsZWFudHgoc3RydWN0IHJlY2VpdmVfcXVl
dWUgKnJxKQo+ICAgCXN0cnVjdCBzZW5kX3F1ZXVlICpzcSA9ICZ2aS0+c3FbaW5kZXhdOwo+ICAg
CXN0cnVjdCBuZXRkZXZfcXVldWUgKnR4cSA9IG5ldGRldl9nZXRfdHhfcXVldWUodmktPmRldiwg
aW5kZXgpOwo+ICAgCj4gLQlpZiAoIXNxLT5uYXBpLndlaWdodCkKPiArCWlmICghc3EtPm5hcGku
d2VpZ2h0IHx8IGlzX3hkcF9yYXdfYnVmZmVyX3F1ZXVlKHZpLCBpbmRleCkpCj4gICAJCXJldHVy
bjsKPiAgIAo+ICAgCWlmIChfX25ldGlmX3R4X3RyeWxvY2sodHhxKSkgewo+IEBAIC0xNDQyLDgg
KzE0NTIsMTYgQEAgc3RhdGljIGludCB2aXJ0bmV0X3BvbGxfdHgoc3RydWN0IG5hcGlfc3RydWN0
ICpuYXBpLCBpbnQgYnVkZ2V0KQo+ICAgewo+ICAgCXN0cnVjdCBzZW5kX3F1ZXVlICpzcSA9IGNv
bnRhaW5lcl9vZihuYXBpLCBzdHJ1Y3Qgc2VuZF9xdWV1ZSwgbmFwaSk7Cj4gICAJc3RydWN0IHZp
cnRuZXRfaW5mbyAqdmkgPSBzcS0+dnEtPnZkZXYtPnByaXY7Cj4gLQlzdHJ1Y3QgbmV0ZGV2X3F1
ZXVlICp0eHEgPSBuZXRkZXZfZ2V0X3R4X3F1ZXVlKHZpLT5kZXYsIHZxMnR4cShzcS0+dnEpKTsK
PiArCXVuc2lnbmVkIGludCBpbmRleCA9IHZxMnR4cShzcS0+dnEpOwo+ICsJc3RydWN0IG5ldGRl
dl9xdWV1ZSAqdHhxOwo+ICAgCj4gKwlpZiAodW5saWtlbHkoaXNfeGRwX3Jhd19idWZmZXJfcXVl
dWUodmksIGluZGV4KSkpIHsKPiArCQkvKiBXZSBkb24ndCBuZWVkIHRvIGVuYWJsZSBjYiBmb3Ig
WERQICovCj4gKwkJbmFwaV9jb21wbGV0ZV9kb25lKG5hcGksIDApOwo+ICsJCXJldHVybiAwOwo+
ICsJfQo+ICsKPiArCXR4cSA9IG5ldGRldl9nZXRfdHhfcXVldWUodmktPmRldiwgaW5kZXgpOwo+
ICAgCV9fbmV0aWZfdHhfbG9jayh0eHEsIHJhd19zbXBfcHJvY2Vzc29yX2lkKCkpOwo+ICAgCWZy
ZWVfb2xkX3htaXRfc2ticyhzcSk7Cj4gICAJX19uZXRpZl90eF91bmxvY2sodHhxKTsKPiBAQCAt
MjQwMiw5ICsyNDIwLDEyIEBAIHN0YXRpYyBpbnQgdmlydG5ldF94ZHBfc2V0KHN0cnVjdCBuZXRf
ZGV2aWNlICpkZXYsIHN0cnVjdCBicGZfcHJvZyAqcHJvZywKPiAgIAl9Cj4gICAKPiAgIAkvKiBN
YWtlIHN1cmUgTkFQSSBpcyBub3QgdXNpbmcgYW55IFhEUCBUWCBxdWV1ZXMgZm9yIFJYLiAqLwo+
IC0JaWYgKG5ldGlmX3J1bm5pbmcoZGV2KSkKPiAtCQlmb3IgKGkgPSAwOyBpIDwgdmktPm1heF9x
dWV1ZV9wYWlyczsgaSsrKQo+ICsJaWYgKG5ldGlmX3J1bm5pbmcoZGV2KSkgewo+ICsJCWZvciAo
aSA9IDA7IGkgPCB2aS0+bWF4X3F1ZXVlX3BhaXJzOyBpKyspIHsKPiAgIAkJCW5hcGlfZGlzYWJs
ZSgmdmktPnJxW2ldLm5hcGkpOwo+ICsJCQl2aXJ0bmV0X25hcGlfdHhfZGlzYWJsZSgmdmktPnNx
W2ldLm5hcGkpOwo+ICsJCX0KPiArCX0KPiAgIAo+ICAgCW5ldGlmX3NldF9yZWFsX251bV9yeF9x
dWV1ZXMoZGV2LCBjdXJyX3FwICsgeGRwX3FwKTsKPiAgIAllcnIgPSBfdmlydG5ldF9zZXRfcXVl
dWVzKHZpLCBjdXJyX3FwICsgeGRwX3FwKTsKPiBAQCAtMjQyMywxNiArMjQ0NCwyMiBAQCBzdGF0
aWMgaW50IHZpcnRuZXRfeGRwX3NldChzdHJ1Y3QgbmV0X2RldmljZSAqZGV2LCBzdHJ1Y3QgYnBm
X3Byb2cgKnByb2csCj4gICAJCX0KPiAgIAkJaWYgKG9sZF9wcm9nKQo+ICAgCQkJYnBmX3Byb2df
cHV0KG9sZF9wcm9nKTsKPiAtCQlpZiAobmV0aWZfcnVubmluZyhkZXYpKQo+ICsJCWlmIChuZXRp
Zl9ydW5uaW5nKGRldikpIHsKPiAgIAkJCXZpcnRuZXRfbmFwaV9lbmFibGUodmktPnJxW2ldLnZx
LCAmdmktPnJxW2ldLm5hcGkpOwo+ICsJCQl2aXJ0bmV0X25hcGlfdHhfZW5hYmxlKHZpLCB2aS0+
c3FbaV0udnEsCj4gKwkJCQkJICAgICAgICZ2aS0+c3FbaV0ubmFwaSk7Cj4gKwkJfQo+ICAgCX0K
PiAgIAo+ICAgCXJldHVybiAwOwo+ICAgCj4gICBlcnI6Cj4gICAJaWYgKG5ldGlmX3J1bm5pbmco
ZGV2KSkgewo+IC0JCWZvciAoaSA9IDA7IGkgPCB2aS0+bWF4X3F1ZXVlX3BhaXJzOyBpKyspCj4g
KwkJZm9yIChpID0gMDsgaSA8IHZpLT5tYXhfcXVldWVfcGFpcnM7IGkrKykgewo+ICAgCQkJdmly
dG5ldF9uYXBpX2VuYWJsZSh2aS0+cnFbaV0udnEsICZ2aS0+cnFbaV0ubmFwaSk7Cj4gKwkJCXZp
cnRuZXRfbmFwaV90eF9lbmFibGUodmksIHZpLT5zcVtpXS52cSwKPiArCQkJCQkgICAgICAgJnZp
LT5zcVtpXS5uYXBpKTsKPiArCQl9Cj4gICAJfQo+ICAgCWlmIChwcm9nKQo+ICAgCQlicGZfcHJv
Z19zdWIocHJvZywgdmktPm1heF9xdWV1ZV9wYWlycyAtIDEpOwo+IEBAIC0yNjE1LDE2ICsyNjQy
LDYgQEAgc3RhdGljIHZvaWQgZnJlZV9yZWNlaXZlX3BhZ2VfZnJhZ3Moc3RydWN0IHZpcnRuZXRf
aW5mbyAqdmkpCj4gICAJCQlwdXRfcGFnZSh2aS0+cnFbaV0uYWxsb2NfZnJhZy5wYWdlKTsKPiAg
IH0KPiAgIAo+IC1zdGF0aWMgYm9vbCBpc194ZHBfcmF3X2J1ZmZlcl9xdWV1ZShzdHJ1Y3Qgdmly
dG5ldF9pbmZvICp2aSwgaW50IHEpCj4gLXsKPiAtCWlmIChxIDwgKHZpLT5jdXJyX3F1ZXVlX3Bh
aXJzIC0gdmktPnhkcF9xdWV1ZV9wYWlycykpCj4gLQkJcmV0dXJuIGZhbHNlOwo+IC0JZWxzZSBp
ZiAocSA8IHZpLT5jdXJyX3F1ZXVlX3BhaXJzKQo+IC0JCXJldHVybiB0cnVlOwo+IC0JZWxzZQo+
IC0JCXJldHVybiBmYWxzZTsKPiAtfQo+IC0KPiAgIHN0YXRpYyB2b2lkIGZyZWVfdW51c2VkX2J1
ZnMoc3RydWN0IHZpcnRuZXRfaW5mbyAqdmkpCj4gICB7Cj4gICAJdm9pZCAqYnVmOwpfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBt
YWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0
cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6
YXRpb24=