From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Roi Dayan <roid@nvidia.com>, David Ahern <dsahern@gmail.com>,
Zahari Doychev <zahari.doychev@linux.com>,
netdev@vger.kernel.org
Cc: simon.horman@netronome.com, jianbol@mellanox.com
Subject: Re: [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing
Date: Tue, 24 Nov 2020 08:41:18 -0500 [thread overview]
Message-ID: <7c8b77a9-f749-45ce-00d8-7695ac0f5855@mojatatu.com> (raw)
In-Reply-To: <6bf5c24a-13bf-afbd-0b45-1488c09ecc56@nvidia.com>
On 2020-11-24 7:13 a.m., Roi Dayan wrote:
>
>
> On 2020-11-24 11:39 AM, Roi Dayan wrote:
>>
>>
[..]
>> Hi,
>>
>> I didn't debug yet but with this commit I am failing to add a tc
>> rule I always could before. also the error msg doesn't make sense.
>>
>> Example:
>>
>> # tc filter add dev enp8s0f0 protocol 802.1Q parent ffff: prio 1 flower\
>> skip_hw dst_mac e4:11:22:11:4a:51 src_mac e4:11:22:11:4a:50\
>> vlan_ethtype 0x800 vlan_id 100 vlan_prio 0 action vlan pop action\
>> mirred egress redirect dev enp8s0f0_0
>>
>>
>> Can't set "vlan_id" if ethertype isn't 802.1Q or 802.1AD
>>
>>
>> I used protocol 802.1Q and vlan_ethtype 0x800.
>> am i missing something? the rule should look different now?
>>
>> Thanks,
>> Roi
>
>
> Hi,
>
> I debugged this and it break vlan rules.
> The issue is from this part of the change
>
We have a test for this in tdc. Maybe we should make it a rule to
run tdc tests on changes like these?
cheers,
jamal
prev parent reply other threads:[~2020-11-24 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 7:53 [PATCH iproute2-next v2] tc flower: use right ethertype in icmp/arp parsing Zahari Doychev
2020-11-14 3:12 ` David Ahern
2020-11-24 9:39 ` Roi Dayan
2020-11-24 12:13 ` Roi Dayan
2020-11-24 13:41 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c8b77a9-f749-45ce-00d8-7695ac0f5855@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=dsahern@gmail.com \
--cc=jianbol@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=simon.horman@netronome.com \
--cc=zahari.doychev@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.