All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>, jgross@suse.com
Cc: xen-devel@lists.xenproject.org, Luca Miccio <lucmiccio@gmail.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain
Date: Thu, 5 May 2022 16:55:06 -0400	[thread overview]
Message-ID: <7c8b93d8-a20b-a859-265e-bb4b6aefe10b@oracle.com> (raw)
In-Reply-To: <20220505002304.401417-2-sstabellini@kernel.org>


On 5/4/22 8:23 PM, Stefano Stabellini wrote:
> @@ -957,25 +989,44 @@ static int __init xenbus_init(void)
>   		 * been properly initialized. Instead of attempting to map a
>   		 * wrong guest physical address return error.
>   		 *
> -		 * Also recognize all bits set as an invalid value.
> +		 * Also recognize all bits set as an invalid/uninitialized value.


What I really meant (but not what I actually wrote I guess) was that now we are treating -1 differently than 0 and so that comment should go ...


>   		 */
> -		if (!v || !~v) {
> +		if (!v) {
>   			err = -ENOENT;
>   			goto out_error;
>   		}
> -		/* Avoid truncation on 32-bit. */


... here.


But this is ntpicking so for the series


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>


> +		if (v == ~0ULL) {
> +			wait = true;
> +		} else {
> +			/* Avoid truncation on 32-bit. */


      parent reply	other threads:[~2022-05-05 20:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05  0:22 [PATCH LINUX 0/2] dom0less + PV drivers Stefano Stabellini
2022-05-05  0:23 ` [PATCH v4 1/2] xen: sync xs_wire.h header with upstream xen Stefano Stabellini
2022-05-10 15:27   ` Luca Fancellu
2022-05-05  0:23 ` [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain Stefano Stabellini
2022-05-05 12:26   ` Michal Orzel
2022-05-05 12:29     ` Juergen Gross
2022-05-05 12:35       ` Michal Orzel
2022-05-05 20:27         ` Stefano Stabellini
2022-05-05 20:55   ` Boris Ostrovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c8b93d8-a20b-a859-265e-bb4b6aefe10b@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=lucmiccio@gmail.com \
    --cc=sstabellini@kernel.org \
    --cc=stefano.stabellini@xilinx.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.