From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v3 08/12] arm64: dts: tegra: Add Tegra186 support Date: Mon, 22 Aug 2016 13:07:23 -0600 Message-ID: <7c96bc7a-e56e-c8b6-2d89-114eff4eb586@wwwdotorg.org> References: <20160819173233.13260-1-thierry.reding@gmail.com> <20160819173233.13260-9-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160819173233.13260-9-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Timo Alho , Peter De Schrijver , Sivaram Nair , Joseph Lo , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/19/2016 11:32 AM, Thierry Reding wrote: > From: Joseph Lo > > This adds the initial support of Tegra186 SoC. It provides enough to > enable the serial console and boot from an initial ramdisk. > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > + bpmp: bpmp { > + compatible = "nvidia,tegra186-bpmp"; > + mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_DB > + TEGRA_HSP_DB_MASTER_BPMP>; > + shmem = <&cpu_bpmp_tx &cpu_bpmp_rx>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + > + bpmp_i2c: i2c { > + compatible = "nvidia,tegra186-bpmp-i2c"; > + nvidia,bpmp = <&bpmp>; > + nvidia,bpmp-bus-id = <5>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + }; Back on 7/20, Rob Herring wrote: > Just 'i2c' here. With that: > > Acked-by: Rob Herring ... but this series doesn't yet include the BPMP I2C bindings (they've been ack'd so I assume they'll be applied right after this series is). Is it better to leave out the I2C sub-node until after the bindings are applied, or doesn't the order matter too? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 22 Aug 2016 13:07:23 -0600 Subject: [PATCH v3 08/12] arm64: dts: tegra: Add Tegra186 support In-Reply-To: <20160819173233.13260-9-thierry.reding@gmail.com> References: <20160819173233.13260-1-thierry.reding@gmail.com> <20160819173233.13260-9-thierry.reding@gmail.com> Message-ID: <7c96bc7a-e56e-c8b6-2d89-114eff4eb586@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/19/2016 11:32 AM, Thierry Reding wrote: > From: Joseph Lo > > This adds the initial support of Tegra186 SoC. It provides enough to > enable the serial console and boot from an initial ramdisk. > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > + bpmp: bpmp { > + compatible = "nvidia,tegra186-bpmp"; > + mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_DB > + TEGRA_HSP_DB_MASTER_BPMP>; > + shmem = <&cpu_bpmp_tx &cpu_bpmp_rx>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + > + bpmp_i2c: i2c { > + compatible = "nvidia,tegra186-bpmp-i2c"; > + nvidia,bpmp = <&bpmp>; > + nvidia,bpmp-bus-id = <5>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + }; Back on 7/20, Rob Herring wrote: > Just 'i2c' here. With that: > > Acked-by: Rob Herring ... but this series doesn't yet include the BPMP I2C bindings (they've been ack'd so I assume they'll be applied right after this series is). Is it better to leave out the I2C sub-node until after the bindings are applied, or doesn't the order matter too?