From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Joey Gouly <joey.gouly@arm.com>, linux-arm-kernel@lists.infradead.org
Cc: nd@arm.com, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v1 2/2] arm64: vdso*: place got/plt sections in .rodata
Date: Wed, 29 Jun 2022 11:11:30 +0100 [thread overview]
Message-ID: <7c971eed-c4bd-df1e-0577-49d27d11836b@arm.com> (raw)
In-Reply-To: <20220628151307.35561-3-joey.gouly@arm.com>
On 28/06/2022 16:13, Joey Gouly wrote:
> The vDSO will not contain absolute relocations, so place these
> sections in .rodata.
>
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> Link: https://lore.kernel.org/linux-arm-kernel/00abb0c5-6360-0004-353f-e7a88b3bd22c@arm.com/
> Cc: Will Deacon <will@kernel.org>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> arch/arm64/kernel/vdso/vdso.lds.S | 12 +++++-------
> arch/arm64/kernel/vdso32/vdso.lds.S | 23 ++++++++++-------------
> 2 files changed, 15 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S
> index 1cd85258c079..e69fb4aaaf3e 100644
> --- a/arch/arm64/kernel/vdso/vdso.lds.S
> +++ b/arch/arm64/kernel/vdso/vdso.lds.S
> @@ -52,17 +52,15 @@ SECTIONS
>
> .rela.dyn : ALIGN(8) { *(.rela .rela*) }
>
> - .plt : {
> + .rodata : {
> + *(.rodata*)
> + *(.got)
> + *(.got.plt)
> *(.plt)
> *(.plt.*)
> *(.iplt)
> *(.igot .igot.plt)
> - }
> -
> - .got : { *(.got) }
> - .got.plt : { *(.got.plt) }
> -
> - .rodata : { *(.rodata*) } :text
> + } :text
>
> _end = .;
> PROVIDE(end = .);
> diff --git a/arch/arm64/kernel/vdso32/vdso.lds.S b/arch/arm64/kernel/vdso32/vdso.lds.S
> index e2f8ced571d6..6e67a6524d58 100644
> --- a/arch/arm64/kernel/vdso32/vdso.lds.S
> +++ b/arch/arm64/kernel/vdso32/vdso.lds.S
> @@ -36,7 +36,15 @@ SECTIONS
>
> .dynamic : { *(.dynamic) } :text :dynamic
>
> - .rodata : { *(.rodata*) } :text
> + .rodata : {
> + *(.rodata*)
> + *(.got)
> + *(.got.plt)
> + *(.plt)
> + *(.rel.iplt)
> + *(.iplt)
> + *(.igot.plt)
> + } :text
>
> .text : {
> *(.text*)
> @@ -46,18 +54,7 @@ SECTIONS
> *(.v4_bx)
> } :text =0xe7f001f2
>
> - .rel.dyn : { *(.rel.text) }
> -
> - .got : { *(.got) }
> - .rel.got : { *(.rel.got) }
> - .got.plt : { *(.got.plt) }
> - .rel.plt : { *(.rel.plt) }
> - .plt : {
> - *(.plt)
> - *(.rel.iplt)
> - *(.iplt)
> - *(.igot.plt)
> - }
> + .rel.dyn : { *(.rel*) }
>
> ELF_DETAILS
> .ARM.exidx : { *(.ARM.exidx*) }
--
Regards,
Vincenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 15:13 [PATCH v1 0/2] vDSO linkerscript follow up Joey Gouly
2022-06-28 15:13 ` [PATCH v1 1/2] arm64: vdso32: add ARM.exidx* sections Joey Gouly
2022-06-29 9:56 ` Vincenzo Frascino
2022-06-29 20:10 ` Nathan Chancellor
2022-06-29 20:10 ` Nathan Chancellor
2022-06-30 10:21 ` Joey Gouly
2022-06-30 10:21 ` Joey Gouly
2022-06-28 15:13 ` [PATCH v1 2/2] arm64: vdso*: place got/plt sections in .rodata Joey Gouly
2022-06-29 10:11 ` Vincenzo Frascino [this message]
2022-06-28 17:02 ` [PATCH v1 0/2] vDSO linkerscript follow up Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c971eed-c4bd-df1e-0577-49d27d11836b@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nd@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.