From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C5F4C433F5 for ; Tue, 7 Dec 2021 15:52:42 +0000 (UTC) Received: from localhost ([::1]:41794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muclk-00088k-VI for qemu-devel@archiver.kernel.org; Tue, 07 Dec 2021 10:52:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muciJ-00077O-13; Tue, 07 Dec 2021 10:49:07 -0500 Received: from beetle.greensocs.com ([5.135.226.135]:38684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muciG-0000Jq-K9; Tue, 07 Dec 2021 10:49:06 -0500 Received: from [172.17.10.6] (unknown [172.17.10.6]) by beetle.greensocs.com (Postfix) with ESMTPSA id 511C520778; Tue, 7 Dec 2021 15:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1638892141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6uLIpSxwGOEemHy6EjCphqwtbELdEvsBM1v7kqk+j7o=; b=EtzE4SVCec9gquNKZ14bvyySOjld6OqOB654TjSU4BUdGBSk3Z1Yw8frN2ANinCdAgEA5R GW01Y5/GnOq7qgnRSZLUIV5yv7UWXiOrTxLnhB5FHwZ2djCVC4G4aHF3K1tzNBBpB7TW4S 21QgMCrsv/ifPsxLHj6SvcSQqiAeL/s= Message-ID: <7c9d97ab-1662-106a-5b51-630a4d2375cf@greensocs.com> Date: Tue, 7 Dec 2021 16:49:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation Content-Language: en-US-large To: Peter Maydell , Brian Cain References: <20211207094427.3473-1-damien.hedde@greensocs.com> From: Damien Hedde In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=5.135.226.135; envelope-from=damien.hedde@greensocs.com; helo=beetle.greensocs.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.44, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sid Manning , Carl van Schaik , "shashi.mallela@linaro.org" , "qemu-devel@nongnu.org" , Taylor Simpson , "qemu-arm@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/7/21 16:45, Peter Maydell wrote: > On Tue, 7 Dec 2021 at 15:24, Peter Maydell wrote: >> The bug is a bug in any case and we'll fix it, it's just a >> question of whether it meets the bar to go into 6.2, which is >> hopefully going to have its final RC tagged today. If this >> patch had arrived a week ago then the bar would have been >> lower and it would definitely have gone in. As it is I have >> to weigh up the chances of this change causing a regression >> for eg KVM running on emulated QEMU. > > Looking at the KVM source it doesn't ever set the LRENPIE > bit (it doesn't even have a #define for it), which both > explains why we didn't notice this bug before and also > means we can be pretty certain we're not going to cause a > regression for KVM at least if we fix it... > > -- PMM > We are perfectly fine with this not going into 6.2. -- Damien