From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org,
den@openvz.org
Subject: Re: [PATCH v2 2/2] iotests: add 269 to check maximum of bitmaps in qcow2
Date: Fri, 25 Oct 2019 15:12:51 +0200 [thread overview]
Message-ID: <7c9e6d62-fc5e-204e-778d-0320833e9b00@redhat.com> (raw)
In-Reply-To: <20191014115126.15360-3-vsementsov@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 972 bytes --]
On 14.10.19 13:51, Vladimir Sementsov-Ogievskiy wrote:
> Check that it's impossible to create more persistent bitmaps than qcow2
> supports.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/269 | 47 ++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/269.out | 3 +++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 51 insertions(+)
> create mode 100755 tests/qemu-iotests/269
> create mode 100644 tests/qemu-iotests/269.out
Is there no way to make this test any faster, e.g. by creating like
65534 bitmaps with dd and a binary blob? (Similarly to what I do in
“iotests: Test qcow2's snapshot table handling”)
This is such an edge case, but running the test took 3:46 min before
patch 1 (which I already find much too long), and 8:13 min afterwards
(on my machine).
(To be honest, if we take this test as-is, I’m probably just never going
to run it.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-25 13:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 11:51 [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2019-10-14 11:51 ` [PATCH v2 1/2] qcow2-bitmaps: " Vladimir Sementsov-Ogievskiy
2019-10-25 12:50 ` Max Reitz
2019-10-25 12:56 ` Vladimir Sementsov-Ogievskiy
2019-12-09 16:32 ` Max Reitz
2019-10-14 11:51 ` [PATCH v2 2/2] iotests: add 269 to check maximum of bitmaps in qcow2 Vladimir Sementsov-Ogievskiy
2019-10-25 13:12 ` Max Reitz [this message]
2019-11-16 9:41 ` Vladimir Sementsov-Ogievskiy
2019-10-14 11:52 ` [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2019-10-25 9:57 ` [bugfix ping] " Vladimir Sementsov-Ogievskiy
2019-12-02 14:09 ` [bugfix ping2] " Vladimir Sementsov-Ogievskiy
2019-12-09 16:30 ` Max Reitz
2019-12-09 17:58 ` Max Reitz
2019-12-09 22:03 ` Eric Blake
2019-12-10 8:11 ` Max Reitz
2019-12-10 13:24 ` Max Reitz
2019-12-10 20:27 ` John Snow
2019-12-11 8:10 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c9e6d62-fc5e-204e-778d-0320833e9b00@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.