From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0178C43460 for ; Thu, 22 Apr 2021 20:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AC6D61437 for ; Thu, 22 Apr 2021 20:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237055AbhDVULC (ORCPT ); Thu, 22 Apr 2021 16:11:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236896AbhDVULB (ORCPT ); Thu, 22 Apr 2021 16:11:01 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B138DC061756 for ; Thu, 22 Apr 2021 13:10:25 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id n2so70621706ejy.7 for ; Thu, 22 Apr 2021 13:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devtank-co-uk.20150623.gappssmtp.com; s=20150623; h=to:references:from:subject:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=wgmYy/LMkr3JJRVe6OWv2xNNfb7j4siB1GggwwkeZVY=; b=Hw87f0vKJX6ikFIsxEDefV4hQCKQ/vDut2bwg0vXNIh02gg65hFiBF8sTw4f7o7GjG Z6FyVx2oJzlAM46oSFZaHsQ1l5+O7fhOnITZ2wIAflJbhrXnu6PY3n0fpltOy2TsIHfw 4Dl7frgNDQer60q80SPZ9Y2Wqek58dYaAsRLL7HEq9z6fwLEB/aHF2TkaGMSvLpYcf9u Xlw01V5fLlPeiDKRF08xi4RVvTG5UtNFskloYRI5kplwujmNACwwz7MdJ/tcgqVa7XAp 7QBli3aWPsi9+nLsuaIAAGEg1lkHXLlXysOq+3OKixqzv28oqv8zVIFPrlZ7CfvO85MN sejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=wgmYy/LMkr3JJRVe6OWv2xNNfb7j4siB1GggwwkeZVY=; b=hObgwHbritnae6MJoZEu/V+Bv4wTgaxnrNIie8XQgY2Owolbt+19WdwQrffZC56EhC aT6LnAt5I1LHCox3fUon8/KyLZVCA6l4ChqIFCvMIgvT9UxjP4uVkW6I1lDd0pgeHqKu bR8PPj2a3F5avxIbIooG7pxO5Bh/db+3T20SG6olm88oGdEinB0725M3hsoXPManESb1 aOGGAYm4+H8/KlwPLEkVOsZEazLjygxbO7Q6EMszecSDucDAdfqNHr1YoM21+yb9KoGo Vsg5qGh7vBdNMTiHqaVFiNrZKIuWvj527R5jN8sBI6MXzk61UFUKrbeU2sueeXkE/az1 brzw== X-Gm-Message-State: AOAM531xeP233OYBnd0LIOYj6K+U9HWKECiCJUYoyKH1RSCqTbHox6XL 9LSVki1jwHVozq5x8pbBII15zBv04HnFBHKb X-Google-Smtp-Source: ABdhPJyr+v8k/4PLnbIB4vbVJAw1m+H3To/oRAKVv86ZmcoWNyGn87iWvOyaqdHU3uqN8C0Pels1mQ== X-Received: by 2002:a17:906:6896:: with SMTP id n22mr461659ejr.316.1619122224095; Thu, 22 Apr 2021 13:10:24 -0700 (PDT) Received: from ?IPv6:2a02:8010:673b:0:65cb:937a:e25b:18a9? ([2a02:8010:673b:0:65cb:937a:e25b:18a9]) by smtp.gmail.com with ESMTPSA id s9sm2833911edd.16.2021.04.22.13.10.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 13:10:23 -0700 (PDT) To: Florian Fainelli , Mark Brown , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> From: Joe Burmeister Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit. Message-ID: <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk> Date: Thu, 22 Apr 2021 21:10:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 4/20/2021 1:34 AM, Joe Burmeister wrote: >> It was previoulsy possible to have a device tree with more chips than >> the driver supports and go off the end of CS arrays. > Do you mind walking me through the code how that could have happened? W= e > have spi_register_controller() call of_spi_get_gpio_numbers() which has= > the following: > > ctlr->num_chipselect =3D max_t(int, nb, ctlr->num_chipselect); > > such that what the controller has is the maximum between the number of > 'cs-gpios' properties parsed and what was already populated in > ctrl->num_chipselect during bcm2835_spi_probe(), which for this driver > is BCM2835_SPI_NUM_CS (3). If you make a initial device tree (or add overlay in the rpi's=20 config.txt) with more on the bus than BCM2835_SPI_NUM_CS (in my case 8 devices), you get into this trampling memory state. As the devices are added, once the chip_select is equal to or greater than BCM2835_SPI_NUM_CS, it's writing off the end of the arrays. There is no protection from this happening. By the looks of it, this isn't the only driver this could happen with, but it is the one I have hardware for to test. There are also drivers that look like they don't have a problem going well beyond the limit they gave. There is protection in spi_add_device, which will catch extra added later, but not ones in the device tree when the spi controller was registered. >> This patches inforces CS limit but sets that limit to the max of the >> default limit and what is in the device tree when driver is loaded. >> >> Signed-off-by: Joe Burmeister > You have changed many more things that just enforcing a limit on > BCM2835_SPI_NUM_CS you have now made all chip-select related data > structuresd dynamically allocated and you have changed a number of > prints to use the shorthand "dev" instead of &pdev->dev. The change to dynamic allocated arrays is just to support what is given in the device=C2=A0 tree rather than increase and enforce the CS limit ju= st for my case. The shorthand is of course not required. I'll drop it on resubmitting. Regards, Joe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDEC2C433B4 for ; Thu, 22 Apr 2021 20:21:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 335996137D for ; Thu, 22 Apr 2021 20:21:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 335996137D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=devtank.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1YiQ55OmNWHwdd2fgNdM3pvgCzv9tZG0sBJ0bU6JA54=; b=eGGBJU7nGIDKyxLJKyu93SSj9 g6JwIKCfzNpwkrjdSuAswWDPupzroLGozs84oQ8TWoh3pg+JFWn2zyyKWsbRQh84iuviteECLxVLY Qm1kIteeO8hXZxfjCoRTOJ+8ahAFIebT7Kwedpxmt4a51Ae0AQd2kfVBQSlIqtR9ZwoRFbTx8mVNW GlIy+buSKMAc/Ck7vhjkKaC6d+8y8VB1X48XtGSlMtSQdY9Joo9ySVrERvVsSe75jTtRISs6LVoTm W5JZljelwZuz1KqJX80Q+sPJX8NjgbtjTZ55NxCFLjft37RbxXJTsNMWdYWnCwszSjeMiS6GfILCe wUn+CrPtg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZfjK-00HO97-4i; Thu, 22 Apr 2021 20:15:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZfef-00HN5H-Lj for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 20:10:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:Subject:From:References :To:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=wgmYy/LMkr3JJRVe6OWv2xNNfb7j4siB1GggwwkeZVY=; b=cazgNsqJv6iw6syJtxwXHoiKVV zFY9XB48KXnaTM898rA7P/N3givkKUVChMhqDTdJ9WpDQK5alsuz47cx7QKLEB5/n6w0f6HhUvOZr NQdNoSnstQyPiJU3+tEKveQrCwqPWQszAvdWqLQ3Q1RR/+Kui1dJcNHZcapC+StPwmOgoav8S4zbo ytilhXwriuALSad4tFNRetIrbTw1a21qvPkwDm/EiNGcyRA2T4bTnxWdOjix138UYoWmNLUaw3wbF 1xKM4wEJw6dJ9SqZbbmB0wBaQbiC5sgiUzVhus1dIT3EafpD3rv+ro8QkFYZpnxFjSKEeawaY7rZS Coqdd6qw==; Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZfec-00DxvM-OT for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 20:10:28 +0000 Received: by mail-ej1-x62c.google.com with SMTP id g5so63912164ejx.0 for ; Thu, 22 Apr 2021 13:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devtank-co-uk.20150623.gappssmtp.com; s=20150623; h=to:references:from:subject:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=wgmYy/LMkr3JJRVe6OWv2xNNfb7j4siB1GggwwkeZVY=; b=Hw87f0vKJX6ikFIsxEDefV4hQCKQ/vDut2bwg0vXNIh02gg65hFiBF8sTw4f7o7GjG Z6FyVx2oJzlAM46oSFZaHsQ1l5+O7fhOnITZ2wIAflJbhrXnu6PY3n0fpltOy2TsIHfw 4Dl7frgNDQer60q80SPZ9Y2Wqek58dYaAsRLL7HEq9z6fwLEB/aHF2TkaGMSvLpYcf9u Xlw01V5fLlPeiDKRF08xi4RVvTG5UtNFskloYRI5kplwujmNACwwz7MdJ/tcgqVa7XAp 7QBli3aWPsi9+nLsuaIAAGEg1lkHXLlXysOq+3OKixqzv28oqv8zVIFPrlZ7CfvO85MN sejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=wgmYy/LMkr3JJRVe6OWv2xNNfb7j4siB1GggwwkeZVY=; b=a9uXi9VGIhOg5ZINp+zifjtCJxpPGZYwDJ7WfV134Dp4qd9LmvrrpOxWGHDWrqqwEg 3XQT5L4yOYpA2dNBIW6+iz7y/Wb95qHJMk4LO5Rxh2eq83BfNlBOrgO3SJWPlAu6hoEm AAa26TMB+sPTWxAD/UnsyVuYYnoJ6zdiAZUs5vcuQ6ZKySAZtqwBrBw866I8Knu07Z4H XR5gdGAP+j0Kfyp1zoexsKwKLPToKYTPw4A/Fwdi54ptT2rMPC3LB3St0EiPBWbKZSPr 3E3TVZdeQ+zIb2o7RgLsViHsLxmKzkm/2LPqGKDDZ7oRDKJEmRhPjhoUnBMnleVgZsJr smFw== X-Gm-Message-State: AOAM531luOo1MFFgeAe67GBhsipvmpyzcUEE+Sqb0tk99u+BgL3258+w lZpz5AvpHbqfJV0O5h1B7jRONg== X-Google-Smtp-Source: ABdhPJyr+v8k/4PLnbIB4vbVJAw1m+H3To/oRAKVv86ZmcoWNyGn87iWvOyaqdHU3uqN8C0Pels1mQ== X-Received: by 2002:a17:906:6896:: with SMTP id n22mr461659ejr.316.1619122224095; Thu, 22 Apr 2021 13:10:24 -0700 (PDT) Received: from ?IPv6:2a02:8010:673b:0:65cb:937a:e25b:18a9? ([2a02:8010:673b:0:65cb:937a:e25b:18a9]) by smtp.gmail.com with ESMTPSA id s9sm2833911edd.16.2021.04.22.13.10.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 13:10:23 -0700 (PDT) To: Florian Fainelli , Mark Brown , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk> From: Joe Burmeister Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit. Message-ID: <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk> Date: Thu, 22 Apr 2021 21:10:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_131026_863502_54381441 X-CRM114-Status: GOOD ( 24.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PiBPbiA0LzIwLzIwMjEgMTozNCBBTSwgSm9lIEJ1cm1laXN0ZXIgd3JvdGU6Cj4+IEl0IHdhcyBw cmV2aW91bHN5IHBvc3NpYmxlIHRvIGhhdmUgYSBkZXZpY2UgdHJlZSB3aXRoIG1vcmUgY2hpcHMg dGhhbgo+PiB0aGUgZHJpdmVyIHN1cHBvcnRzIGFuZCBnbyBvZmYgdGhlIGVuZCBvZiBDUyBhcnJh eXMuCj4gRG8geW91IG1pbmQgd2Fsa2luZyBtZSB0aHJvdWdoIHRoZSBjb2RlIGhvdyB0aGF0IGNv dWxkIGhhdmUgaGFwcGVuZWQ/IFdlCj4gaGF2ZSBzcGlfcmVnaXN0ZXJfY29udHJvbGxlcigpIGNh bGwgb2Zfc3BpX2dldF9ncGlvX251bWJlcnMoKSB3aGljaCBoYXMKPiB0aGUgZm9sbG93aW5nOgo+ Cj4gY3Rsci0+bnVtX2NoaXBzZWxlY3QgPSBtYXhfdChpbnQsIG5iLCBjdGxyLT5udW1fY2hpcHNl bGVjdCk7Cj4KPiBzdWNoIHRoYXQgd2hhdCB0aGUgY29udHJvbGxlciBoYXMgaXMgdGhlIG1heGlt dW0gYmV0d2VlbiB0aGUgbnVtYmVyIG9mCj4gJ2NzLWdwaW9zJyBwcm9wZXJ0aWVzIHBhcnNlZCBh bmQgd2hhdCB3YXMgYWxyZWFkeSBwb3B1bGF0ZWQgaW4KPiBjdHJsLT5udW1fY2hpcHNlbGVjdCBk dXJpbmcgYmNtMjgzNV9zcGlfcHJvYmUoKSwgd2hpY2ggZm9yIHRoaXMgZHJpdmVyCj4gaXMgQkNN MjgzNV9TUElfTlVNX0NTICgzKS4KCklmIHlvdSBtYWtlIGEgaW5pdGlhbCBkZXZpY2UgdHJlZSAo b3IgYWRkIG92ZXJsYXkgaW4gdGhlIHJwaSdzIApjb25maWcudHh0KSB3aXRoIG1vcmUgb24gdGhl IGJ1cyB0aGFuIEJDTTI4MzVfU1BJX05VTV9DUyAoaW4gbXkgY2FzZSA4CmRldmljZXMpLCB5b3Ug Z2V0IGludG8gdGhpcyB0cmFtcGxpbmcgbWVtb3J5IHN0YXRlLiBBcyB0aGUgZGV2aWNlcyBhcmUK YWRkZWQsIG9uY2UgdGhlIGNoaXBfc2VsZWN0IGlzIGVxdWFsIHRvIG9yIGdyZWF0ZXIgdGhhbgpC Q00yODM1X1NQSV9OVU1fQ1MsIGl0J3Mgd3JpdGluZyBvZmYgdGhlIGVuZCBvZiB0aGUgYXJyYXlz LgoKVGhlcmUgaXMgbm8gcHJvdGVjdGlvbiBmcm9tIHRoaXMgaGFwcGVuaW5nLiBCeSB0aGUgbG9v a3Mgb2YgaXQsIHRoaXMKaXNuJ3QgdGhlIG9ubHkgZHJpdmVyIHRoaXMgY291bGQgaGFwcGVuIHdp dGgsIGJ1dCBpdCBpcyB0aGUgb25lIEkgaGF2ZQpoYXJkd2FyZSBmb3IgdG8gdGVzdC4gVGhlcmUg YXJlIGFsc28gZHJpdmVycyB0aGF0IGxvb2sgbGlrZSB0aGV5IGRvbid0CmhhdmUgYSBwcm9ibGVt IGdvaW5nIHdlbGwgYmV5b25kIHRoZSBsaW1pdCB0aGV5IGdhdmUuCgpUaGVyZSBpcyBwcm90ZWN0 aW9uIGluIHNwaV9hZGRfZGV2aWNlLCB3aGljaCB3aWxsIGNhdGNoIGV4dHJhIGFkZGVkCmxhdGVy LCBidXQgbm90IG9uZXMgaW4gdGhlIGRldmljZSB0cmVlIHdoZW4gdGhlIHNwaSBjb250cm9sbGVy IHdhcwpyZWdpc3RlcmVkLgoKPj4gVGhpcyBwYXRjaGVzIGluZm9yY2VzIENTIGxpbWl0IGJ1dCBz ZXRzIHRoYXQgbGltaXQgdG8gdGhlIG1heCBvZiB0aGUKPj4gZGVmYXVsdCBsaW1pdCBhbmQgd2hh dCBpcyBpbiB0aGUgZGV2aWNlIHRyZWUgd2hlbiBkcml2ZXIgaXMgbG9hZGVkLgo+Pgo+PiBTaWdu ZWQtb2ZmLWJ5OiBKb2UgQnVybWVpc3RlciA8am9lLmJ1cm1laXN0ZXJAZGV2dGFuay5jby51az4K PiBZb3UgaGF2ZSBjaGFuZ2VkIG1hbnkgbW9yZSB0aGluZ3MgdGhhdCBqdXN0IGVuZm9yY2luZyBh IGxpbWl0IG9uCj4gQkNNMjgzNV9TUElfTlVNX0NTIHlvdSBoYXZlIG5vdyBtYWRlIGFsbCBjaGlw LXNlbGVjdCByZWxhdGVkIGRhdGEKPiBzdHJ1Y3R1cmVzZCBkeW5hbWljYWxseSBhbGxvY2F0ZWQg YW5kIHlvdSBoYXZlIGNoYW5nZWQgYSBudW1iZXIgb2YKPiBwcmludHMgdG8gdXNlIHRoZSBzaG9y dGhhbmQgImRldiIgaW5zdGVhZCBvZiAmcGRldi0+ZGV2LgpUaGUgY2hhbmdlIHRvIGR5bmFtaWMg YWxsb2NhdGVkIGFycmF5cyBpcyBqdXN0IHRvIHN1cHBvcnQgd2hhdCBpcyBnaXZlbgppbiB0aGUg ZGV2aWNlwqAgdHJlZSByYXRoZXIgdGhhbiBpbmNyZWFzZSBhbmQgZW5mb3JjZSB0aGUgQ1MgbGlt aXQganVzdApmb3IgbXkgY2FzZS4KClRoZSBzaG9ydGhhbmQgaXMgb2YgY291cnNlIG5vdCByZXF1 aXJlZC4gSSdsbCBkcm9wIGl0IG9uIHJlc3VibWl0dGluZy4KClJlZ2FyZHMsCgpKb2UKCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=