All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hyman Huang <huangy81@chinatelecom.cn>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast
Date: Wed, 16 Jun 2021 14:26:41 +0800	[thread overview]
Message-ID: <7ca552b7-4011-0d3e-6e0f-332794bb0db7@chinatelecom.cn> (raw)
In-Reply-To: <584578c0a0dd781cee45f72ddf517f6e6a41c504.1622729934.git.huangy81@chinatelecom.cn>



在 2021/6/3 22:19, huangy81@chinatelecom.cn 写道:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> 
> thread_id in CpuInfoFast is deprecated, parse thread-id instead
> after execute qmp query-cpus-fast. fix this so that test can
> go smoothly.
> 
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
>   tests/migration/guestperf/engine.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
> index 208e095794..9e16fa92d2 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
>           vcpus = src.command("query-cpus-fast")
>           src_threads = []
>           for vcpu in vcpus:
> -            src_threads.append(vcpu["thread_id"])
> +            src_threads.append(vcpu["thread-id"])
>   
>           # XXX how to get dst timings on remote host ?
>   
> 

- ping

this patch fix thread_id so that guestperf can run successfully

please review, thanks : ) !

-- 
Best regard

Hyman Huang(黄勇)


  parent reply	other threads:[~2021-06-16  6:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 14:19 [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast huangy81
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
2021-06-16  6:33   ` Hyman Huang
2021-06-21  8:20   ` Daniel P. Berrangé
2021-06-16  6:26 ` Hyman Huang [this message]
2021-06-21  6:29   ` [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast Hyman Huang
2021-06-21  8:20 ` Daniel P. Berrangé
2021-07-01  9:15 ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ca552b7-4011-0d3e-6e0f-332794bb0db7@chinatelecom.cn \
    --to=huangy81@chinatelecom.cn \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.