From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD57C48BE6 for ; Wed, 16 Jun 2021 06:28:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3630C613C7 for ; Wed, 16 Jun 2021 06:28:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3630C613C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chinatelecom.cn Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltP2F-0000lR-0a for qemu-devel@archiver.kernel.org; Wed, 16 Jun 2021 02:28:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltP12-0008TC-O7 for qemu-devel@nongnu.org; Wed, 16 Jun 2021 02:27:08 -0400 Received: from prt-mail.chinatelecom.cn ([42.123.76.228]:55676 helo=chinatelecom.cn) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltP0z-0002U6-Ih for qemu-devel@nongnu.org; Wed, 16 Jun 2021 02:27:08 -0400 HMM_SOURCE_IP: 172.18.0.218:36190.76432716 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-10.133.8.242?logid-b2513e812f98422aa1aff9052a1fb307 (unknown [172.18.0.218]) by chinatelecom.cn (HERMES) with SMTP id 8A3EB28010C; Wed, 16 Jun 2021 14:26:47 +0800 (CST) X-189-SAVE-TO-SEND: huangy81@chinatelecom.cn Received: from ([172.18.0.218]) by app0025 with ESMTP id b2513e812f98422aa1aff9052a1fb307 for dgilbert@redhat.com; Wed Jun 16 14:26:47 2021 X-Transaction-ID: b2513e812f98422aa1aff9052a1fb307 X-filter-score: filter<0> X-Real-From: huangy81@chinatelecom.cn X-Receive-IP: 172.18.0.218 X-MEDUSA-Status: 0 Subject: Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast To: qemu-devel@nongnu.org References: <584578c0a0dd781cee45f72ddf517f6e6a41c504.1622729934.git.huangy81@chinatelecom.cn> From: Hyman Huang Message-ID: <7ca552b7-4011-0d3e-6e0f-332794bb0db7@chinatelecom.cn> Date: Wed, 16 Jun 2021 14:26:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <584578c0a0dd781cee45f72ddf517f6e6a41c504.1622729934.git.huangy81@chinatelecom.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=42.123.76.228; envelope-from=huangy81@chinatelecom.cn; helo=chinatelecom.cn X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.095, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2021/6/3 22:19, huangy81@chinatelecom.cn 写道: > From: Hyman Huang(黄勇) > > thread_id in CpuInfoFast is deprecated, parse thread-id instead > after execute qmp query-cpus-fast. fix this so that test can > go smoothly. > > Signed-off-by: Hyman Huang(黄勇) > --- > tests/migration/guestperf/engine.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py > index 208e095794..9e16fa92d2 100644 > --- a/tests/migration/guestperf/engine.py > +++ b/tests/migration/guestperf/engine.py > @@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri): > vcpus = src.command("query-cpus-fast") > src_threads = [] > for vcpu in vcpus: > - src_threads.append(vcpu["thread_id"]) > + src_threads.append(vcpu["thread-id"]) > > # XXX how to get dst timings on remote host ? > > - ping this patch fix thread_id so that guestperf can run successfully please review, thanks : ) ! -- Best regard Hyman Huang(黄勇)