All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Zanders <maarten.zanders@mind.be>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump
Date: Sat, 29 Oct 2022 09:48:12 +0200	[thread overview]
Message-ID: <7cbb1cc5-e333-db25-77e2-7a1ebda70e24@mind.be> (raw)
In-Reply-To: <34c4037b-d152-412d-e551-dd3ea27b6b46@linaro.org>


On 10/29/22 00:07, Krzysztof Kozlowski wrote:
> Drop | 
OK.
>> +      Disable the internal charge pump.
> Does it mean that it is enabled by default?

The device default after reset is "off".
The current implementation sets it to "auto".
Other possible modes are "bypass" and "boost".

Should I change to an optional "ti,charge_pump_mode" as string and set 
default to "auto"?

Thanks!


  reply	other threads:[~2022-10-29  7:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 13:34 [PATCH 0/2] leds: lp55xx: support disabling the charge pump Maarten Zanders
2022-10-28 13:34 ` [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump Maarten Zanders
2022-10-28 22:07   ` Krzysztof Kozlowski
2022-10-29  7:48     ` Maarten Zanders [this message]
2022-11-02 16:19       ` Krzysztof Kozlowski
2022-10-28 13:34 ` [PATCH 2/2] leds: lp55xx: add option to disable charge pump Maarten Zanders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cbb1cc5-e333-db25-77e2-7a1ebda70e24@mind.be \
    --to=maarten.zanders@mind.be \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.