From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anshuman Khandual Date: Wed, 16 Oct 2019 09:54:31 +0000 Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers Message-Id: <7cd03155-6713-3116-1e88-f81f84dd794f@arm.com> List-Id: References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> <1571162982.5937.42.camel@lca.pw> In-Reply-To: <1571162982.5937.42.camel@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Qian Cai , linux-mm@kvack.org Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On 10/15/2019 11:39 PM, Qian Cai wrote: > On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: >> +static unsigned long __init get_random_vaddr(void) >> +{ >> + unsigned long random_vaddr, random_pages, total_user_pages; >> + >> + total_user_pages = (TASK_SIZE - FIRST_USER_ADDRESS) / PAGE_SIZE; >> + >> + random_pages = get_random_long() % total_user_pages; >> + random_vaddr = FIRST_USER_ADDRESS + random_pages * PAGE_SIZE; >> + >> + WARN_ON(random_vaddr > TASK_SIZE); >> + WARN_ON(random_vaddr < FIRST_USER_ADDRESS); > > It would be nice if this patch does not introduce a new W=1 GCC warning here on > x86 because FIRST_USER_ADDRESS is 0, and GCC think the code is dumb because > "random_vaddr" is unsigned, > > In file included from ./arch/x86/include/asm/bug.h:83, >                  from ./include/linux/bug.h:5, >                  from ./include/linux/mmdebug.h:5, >                  from ./include/linux/gfp.h:5, >                  from mm/debug_vm_pgtable.c:13: > mm/debug_vm_pgtable.c: In function ‘get_random_vaddr’: > mm/debug_vm_pgtable.c:359:23: warning: comparison of unsigned expression < 0 is > always false [-Wtype-limits] >   WARN_ON(random_vaddr < FIRST_USER_ADDRESS); >                        ^ > ./include/asm-generic/bug.h:113:25: note: in definition of macro ‘WARN_ON’ >   int __ret_warn_on = !!(condition);    \ >                          ^~~~~~~~~ The test checks against an erroneous unsigned long overflow when FIRST_USER_ADDRESS is not 0 but a positive number. Wondering if the compiler will still complain if we merge both the WARN_ON() checks as || on a single statement. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EE4C4360C for ; Wed, 16 Oct 2019 09:54:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 550D12168B for ; Wed, 16 Oct 2019 09:54:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404364AbfJPJyN (ORCPT ); Wed, 16 Oct 2019 05:54:13 -0400 Received: from foss.arm.com ([217.140.110.172]:34420 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404266AbfJPJyM (ORCPT ); Wed, 16 Oct 2019 05:54:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6076142F; Wed, 16 Oct 2019 02:54:11 -0700 (PDT) Received: from [10.163.1.216] (unknown [10.163.1.216]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD8023F6C4; Wed, 16 Oct 2019 02:53:56 -0700 (PDT) Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers To: Qian Cai , linux-mm@kvack.org Cc: Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> <1571162982.5937.42.camel@lca.pw> From: Anshuman Khandual Message-ID: <7cd03155-6713-3116-1e88-f81f84dd794f@arm.com> Date: Wed, 16 Oct 2019 15:24:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1571162982.5937.42.camel@lca.pw> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/2019 11:39 PM, Qian Cai wrote: > On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: >> +static unsigned long __init get_random_vaddr(void) >> +{ >> + unsigned long random_vaddr, random_pages, total_user_pages; >> + >> + total_user_pages = (TASK_SIZE - FIRST_USER_ADDRESS) / PAGE_SIZE; >> + >> + random_pages = get_random_long() % total_user_pages; >> + random_vaddr = FIRST_USER_ADDRESS + random_pages * PAGE_SIZE; >> + >> + WARN_ON(random_vaddr > TASK_SIZE); >> + WARN_ON(random_vaddr < FIRST_USER_ADDRESS); > > It would be nice if this patch does not introduce a new W=1 GCC warning here on > x86 because FIRST_USER_ADDRESS is 0, and GCC think the code is dumb because > "random_vaddr" is unsigned, > > In file included from ./arch/x86/include/asm/bug.h:83, >                  from ./include/linux/bug.h:5, >                  from ./include/linux/mmdebug.h:5, >                  from ./include/linux/gfp.h:5, >                  from mm/debug_vm_pgtable.c:13: > mm/debug_vm_pgtable.c: In function ‘get_random_vaddr’: > mm/debug_vm_pgtable.c:359:23: warning: comparison of unsigned expression < 0 is > always false [-Wtype-limits] >   WARN_ON(random_vaddr < FIRST_USER_ADDRESS); >                        ^ > ./include/asm-generic/bug.h:113:25: note: in definition of macro ‘WARN_ON’ >   int __ret_warn_on = !!(condition);    \ >                          ^~~~~~~~~ The test checks against an erroneous unsigned long overflow when FIRST_USER_ADDRESS is not 0 but a positive number. Wondering if the compiler will still complain if we merge both the WARN_ON() checks as || on a single statement. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7258C4360C for ; Wed, 16 Oct 2019 09:56:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EB4A2168B for ; Wed, 16 Oct 2019 09:56:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EB4A2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46tSPC21K2zDqY3 for ; Wed, 16 Oct 2019 20:56:31 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=anshuman.khandual@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 46tSLd04DFzDqfZ for ; Wed, 16 Oct 2019 20:54:13 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6076142F; Wed, 16 Oct 2019 02:54:11 -0700 (PDT) Received: from [10.163.1.216] (unknown [10.163.1.216]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD8023F6C4; Wed, 16 Oct 2019 02:53:56 -0700 (PDT) Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers To: Qian Cai , linux-mm@kvack.org References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> <1571162982.5937.42.camel@lca.pw> From: Anshuman Khandual Message-ID: <7cd03155-6713-3116-1e88-f81f84dd794f@arm.com> Date: Wed, 16 Oct 2019 15:24:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1571162982.5937.42.camel@lca.pw> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 10/15/2019 11:39 PM, Qian Cai wrote: > On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: >> +static unsigned long __init get_random_vaddr(void) >> +{ >> + unsigned long random_vaddr, random_pages, total_user_pages; >> + >> + total_user_pages = (TASK_SIZE - FIRST_USER_ADDRESS) / PAGE_SIZE; >> + >> + random_pages = get_random_long() % total_user_pages; >> + random_vaddr = FIRST_USER_ADDRESS + random_pages * PAGE_SIZE; >> + >> + WARN_ON(random_vaddr > TASK_SIZE); >> + WARN_ON(random_vaddr < FIRST_USER_ADDRESS); > > It would be nice if this patch does not introduce a new W=1 GCC warning here on > x86 because FIRST_USER_ADDRESS is 0, and GCC think the code is dumb because > "random_vaddr" is unsigned, > > In file included from ./arch/x86/include/asm/bug.h:83, >                  from ./include/linux/bug.h:5, >                  from ./include/linux/mmdebug.h:5, >                  from ./include/linux/gfp.h:5, >                  from mm/debug_vm_pgtable.c:13: > mm/debug_vm_pgtable.c: In function ‘get_random_vaddr’: > mm/debug_vm_pgtable.c:359:23: warning: comparison of unsigned expression < 0 is > always false [-Wtype-limits] >   WARN_ON(random_vaddr < FIRST_USER_ADDRESS); >                        ^ > ./include/asm-generic/bug.h:113:25: note: in definition of macro ‘WARN_ON’ >   int __ret_warn_on = !!(condition);    \ >                          ^~~~~~~~~ The test checks against an erroneous unsigned long overflow when FIRST_USER_ADDRESS is not 0 but a positive number. Wondering if the compiler will still complain if we merge both the WARN_ON() checks as || on a single statement. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF06C4360C for ; Wed, 16 Oct 2019 09:54:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07A822168B for ; Wed, 16 Oct 2019 09:54:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MrKK8k3/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07A822168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SLxJN/Hru8s1/eloUJvyms94nBeObG+dZ6p6191haLU=; b=MrKK8k3/Z29d3d 6w+QmOXDhhHeYpVVnmoLP5wLAMRbshfm9iNp0ZOnQVxuxnZIm50fUU27hQ6xeo7CyPgugozWzWWhS Tx8Y9cTvxLt9hfv9E9oVtaHNPy1xRxmEAmom9QlzOCyHExR6KKzfBIHHHlZQ/TMAxuuX11EAz9L69 g7zfu2Zu1JjPxRCP8jyzJdQBaWDVrLfUROBOXsm1JeXgrqKPOlRJpx2aFnaA5+CJaFKd/gt3QrEAr fqW3ArP7kMTvykcewR7I75jky0oVAcCuC63bFQ0f981ZhdFxCEAccjbGDhsIqhnrfE7Gxt4a6pHqC PWxb88NkiTOl5XIEbm6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKg0e-0001az-Bh; Wed, 16 Oct 2019 09:54:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKg0U-0001RD-91; Wed, 16 Oct 2019 09:54:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6076142F; Wed, 16 Oct 2019 02:54:11 -0700 (PDT) Received: from [10.163.1.216] (unknown [10.163.1.216]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD8023F6C4; Wed, 16 Oct 2019 02:53:56 -0700 (PDT) Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers To: Qian Cai , linux-mm@kvack.org References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> <1571162982.5937.42.camel@lca.pw> From: Anshuman Khandual Message-ID: <7cd03155-6713-3116-1e88-f81f84dd794f@arm.com> Date: Wed, 16 Oct 2019 15:24:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1571162982.5937.42.camel@lca.pw> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_025414_402471_ED3D6E81 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org CgpPbiAxMC8xNS8yMDE5IDExOjM5IFBNLCBRaWFuIENhaSB3cm90ZToKPiBPbiBUdWUsIDIwMTkt MTAtMTUgYXQgMTQ6NTEgKzA1MzAsIEFuc2h1bWFuIEtoYW5kdWFsIHdyb3RlOgo+PiArc3RhdGlj IHVuc2lnbmVkIGxvbmcgX19pbml0IGdldF9yYW5kb21fdmFkZHIodm9pZCkKPj4gK3sKPj4gKwl1 bnNpZ25lZCBsb25nIHJhbmRvbV92YWRkciwgcmFuZG9tX3BhZ2VzLCB0b3RhbF91c2VyX3BhZ2Vz Owo+PiArCj4+ICsJdG90YWxfdXNlcl9wYWdlcyA9IChUQVNLX1NJWkUgLSBGSVJTVF9VU0VSX0FE RFJFU1MpIC8gUEFHRV9TSVpFOwo+PiArCj4+ICsJcmFuZG9tX3BhZ2VzID0gZ2V0X3JhbmRvbV9s b25nKCkgJSB0b3RhbF91c2VyX3BhZ2VzOwo+PiArCXJhbmRvbV92YWRkciA9IEZJUlNUX1VTRVJf QUREUkVTUyArIHJhbmRvbV9wYWdlcyAqIFBBR0VfU0laRTsKPj4gKwo+PiArCVdBUk5fT04ocmFu ZG9tX3ZhZGRyID4gVEFTS19TSVpFKTsKPj4gKwlXQVJOX09OKHJhbmRvbV92YWRkciA8IEZJUlNU X1VTRVJfQUREUkVTUyk7Cj4gCj4gSXQgd291bGQgYmUgbmljZSBpZiB0aGlzIHBhdGNoIGRvZXMg bm90IGludHJvZHVjZSBhIG5ldyBXPTEgR0NDIHdhcm5pbmcgaGVyZSBvbgo+IHg4NiBiZWNhdXNl IEZJUlNUX1VTRVJfQUREUkVTUyBpcyAwLCBhbmQgR0NDIHRoaW5rIHRoZSBjb2RlIGlzIGR1bWIg YmVjYXVzZQo+ICJyYW5kb21fdmFkZHIiIGlzIHVuc2lnbmVkLAo+IAo+IEluIGZpbGUgaW5jbHVk ZWQgZnJvbSAuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2J1Zy5oOjgzLAo+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9idWcuaDo1LAo+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9tbWRlYnVn Lmg6NSwKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnJvbSAuL2luY2x1ZGUv bGludXgvZ2ZwLmg6NSwKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnJvbSBt bS9kZWJ1Z192bV9wZ3RhYmxlLmM6MTM6Cj4gbW0vZGVidWdfdm1fcGd0YWJsZS5jOiBJbiBmdW5j dGlvbiDigJhnZXRfcmFuZG9tX3ZhZGRy4oCZOgo+IG1tL2RlYnVnX3ZtX3BndGFibGUuYzozNTk6 MjM6IHdhcm5pbmc6IGNvbXBhcmlzb24gb2YgdW5zaWduZWQgZXhwcmVzc2lvbiA8IDAgaXMKPiBh bHdheXMgZmFsc2UgWy1XdHlwZS1saW1pdHNdCj4gwqAgV0FSTl9PTihyYW5kb21fdmFkZHIgPCBG SVJTVF9VU0VSX0FERFJFU1MpOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqBeCj4gLi9pbmNsdWRlL2FzbS1nZW5lcmljL2J1Zy5oOjExMzoyNTogbm90ZTog aW4gZGVmaW5pdGlvbiBvZiBtYWNybyDigJhXQVJOX09O4oCZCj4gwqAgaW50IF9fcmV0X3dhcm5f b24gPSAhIShjb25kaXRpb24pO8KgwqDCoMKgXAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgXn5+fn5+fn5+CgpUaGUgdGVzdCBjaGVja3MgYWdhaW5z dCBhbiBlcnJvbmVvdXMgdW5zaWduZWQgbG9uZyBvdmVyZmxvdyB3aGVuCkZJUlNUX1VTRVJfQURE UkVTUyBpcyBub3QgMCBidXQgYSBwb3NpdGl2ZSBudW1iZXIuIFdvbmRlcmluZyBpZgp0aGUgY29t cGlsZXIgd2lsbCBzdGlsbCBjb21wbGFpbiBpZiB3ZSBtZXJnZSBib3RoIHRoZSBXQVJOX09OKCkK Y2hlY2tzIGFzIHx8IG9uIGEgc2luZ2xlIHN0YXRlbWVudC4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXNucHMtYXJjIG1haWxpbmcgbGlzdAps aW51eC1zbnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtc25wcy1hcmMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D3BC4360C for ; Wed, 16 Oct 2019 09:54:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9273221D7D for ; Wed, 16 Oct 2019 09:54:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dqne2Ocs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9273221D7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RAwDvxUkrtL5qvJhQ9ezQpvesLkwlKIMA3hc1UgKqhY=; b=Dqne2OcsypAtcY x6cCKMCHTctt/PdLRJgGYi1b0EifMf2L8JqF9Uwq1SV/7kt7yV9AR+RBKKgk7r2fFr+KDJL7n1rao pHRsxjfuna9GYCjCPJhionDIGMihH94ypZnBkc/J1W7gdjyYEW/Ga5ooWiQvq62SVQLPKxe/XD9qI QaYasrCL1RuoCNWWhFrETmNH5cFc7M0ACo0Z6oxgcP0BF7UuFwW3P1dKvzLJHkSTWn3SR7Dz9vkwO Dlquv5YZHW+qJY9O9zTK+DBh2Okm+uz3UBtnkQ8j2ZKlgXqN1QbUXRJk5SsE947u3tAzPnX6UZTIE UNqVqECGNzLG0EMvEa6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKg0X-0001SK-0A; Wed, 16 Oct 2019 09:54:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKg0U-0001RD-91; Wed, 16 Oct 2019 09:54:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6076142F; Wed, 16 Oct 2019 02:54:11 -0700 (PDT) Received: from [10.163.1.216] (unknown [10.163.1.216]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD8023F6C4; Wed, 16 Oct 2019 02:53:56 -0700 (PDT) Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers To: Qian Cai , linux-mm@kvack.org References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> <1571162982.5937.42.camel@lca.pw> From: Anshuman Khandual Message-ID: <7cd03155-6713-3116-1e88-f81f84dd794f@arm.com> Date: Wed, 16 Oct 2019 15:24:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1571162982.5937.42.camel@lca.pw> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_025414_402471_ED3D6E81 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxMC8xNS8yMDE5IDExOjM5IFBNLCBRaWFuIENhaSB3cm90ZToKPiBPbiBUdWUsIDIwMTkt MTAtMTUgYXQgMTQ6NTEgKzA1MzAsIEFuc2h1bWFuIEtoYW5kdWFsIHdyb3RlOgo+PiArc3RhdGlj IHVuc2lnbmVkIGxvbmcgX19pbml0IGdldF9yYW5kb21fdmFkZHIodm9pZCkKPj4gK3sKPj4gKwl1 bnNpZ25lZCBsb25nIHJhbmRvbV92YWRkciwgcmFuZG9tX3BhZ2VzLCB0b3RhbF91c2VyX3BhZ2Vz Owo+PiArCj4+ICsJdG90YWxfdXNlcl9wYWdlcyA9IChUQVNLX1NJWkUgLSBGSVJTVF9VU0VSX0FE RFJFU1MpIC8gUEFHRV9TSVpFOwo+PiArCj4+ICsJcmFuZG9tX3BhZ2VzID0gZ2V0X3JhbmRvbV9s b25nKCkgJSB0b3RhbF91c2VyX3BhZ2VzOwo+PiArCXJhbmRvbV92YWRkciA9IEZJUlNUX1VTRVJf QUREUkVTUyArIHJhbmRvbV9wYWdlcyAqIFBBR0VfU0laRTsKPj4gKwo+PiArCVdBUk5fT04ocmFu ZG9tX3ZhZGRyID4gVEFTS19TSVpFKTsKPj4gKwlXQVJOX09OKHJhbmRvbV92YWRkciA8IEZJUlNU X1VTRVJfQUREUkVTUyk7Cj4gCj4gSXQgd291bGQgYmUgbmljZSBpZiB0aGlzIHBhdGNoIGRvZXMg bm90IGludHJvZHVjZSBhIG5ldyBXPTEgR0NDIHdhcm5pbmcgaGVyZSBvbgo+IHg4NiBiZWNhdXNl IEZJUlNUX1VTRVJfQUREUkVTUyBpcyAwLCBhbmQgR0NDIHRoaW5rIHRoZSBjb2RlIGlzIGR1bWIg YmVjYXVzZQo+ICJyYW5kb21fdmFkZHIiIGlzIHVuc2lnbmVkLAo+IAo+IEluIGZpbGUgaW5jbHVk ZWQgZnJvbSAuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2J1Zy5oOjgzLAo+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9idWcuaDo1LAo+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBmcm9tIC4vaW5jbHVkZS9saW51eC9tbWRlYnVn Lmg6NSwKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnJvbSAuL2luY2x1ZGUv bGludXgvZ2ZwLmg6NSwKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZnJvbSBt bS9kZWJ1Z192bV9wZ3RhYmxlLmM6MTM6Cj4gbW0vZGVidWdfdm1fcGd0YWJsZS5jOiBJbiBmdW5j dGlvbiDigJhnZXRfcmFuZG9tX3ZhZGRy4oCZOgo+IG1tL2RlYnVnX3ZtX3BndGFibGUuYzozNTk6 MjM6IHdhcm5pbmc6IGNvbXBhcmlzb24gb2YgdW5zaWduZWQgZXhwcmVzc2lvbiA8IDAgaXMKPiBh bHdheXMgZmFsc2UgWy1XdHlwZS1saW1pdHNdCj4gwqAgV0FSTl9PTihyYW5kb21fdmFkZHIgPCBG SVJTVF9VU0VSX0FERFJFU1MpOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqBeCj4gLi9pbmNsdWRlL2FzbS1nZW5lcmljL2J1Zy5oOjExMzoyNTogbm90ZTog aW4gZGVmaW5pdGlvbiBvZiBtYWNybyDigJhXQVJOX09O4oCZCj4gwqAgaW50IF9fcmV0X3dhcm5f b24gPSAhIShjb25kaXRpb24pO8KgwqDCoMKgXAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgXn5+fn5+fn5+CgpUaGUgdGVzdCBjaGVja3MgYWdhaW5z dCBhbiBlcnJvbmVvdXMgdW5zaWduZWQgbG9uZyBvdmVyZmxvdyB3aGVuCkZJUlNUX1VTRVJfQURE UkVTUyBpcyBub3QgMCBidXQgYSBwb3NpdGl2ZSBudW1iZXIuIFdvbmRlcmluZyBpZgp0aGUgY29t cGlsZXIgd2lsbCBzdGlsbCBjb21wbGFpbiBpZiB3ZSBtZXJnZSBib3RoIHRoZSBXQVJOX09OKCkK Y2hlY2tzIGFzIHx8IG9uIGEgc2luZ2xlIHN0YXRlbWVudC4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK