From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Don Brace To: Ming Lei , Jens Axboe , "linux-block@vger.kernel.org" , "Christoph Hellwig" , Mike Snitzer CC: "linux-scsi@vger.kernel.org" , Hannes Reinecke , Arun Easi , Omar Sandoval , "Martin K . Petersen" , "James Bottomley" , Christoph Hellwig , Kashyap Desai , Peter Rivera , Paolo Bonzini , "Laurence Oberman" Subject: RE: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding host Date: Mon, 5 Feb 2018 18:55:11 +0000 Message-ID: <7cd6ea234585450f972a5cdd73961e97@microsemi.com> References: <20180205152035.15016-1-ming.lei@redhat.com> <20180205152035.15016-8-ming.lei@redhat.com> In-Reply-To: <20180205152035.15016-8-ming.lei@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Return-Path: don.brace@microsemi.com List-ID: > -----Original Message----- > From: Ming Lei [mailto:ming.lei@redhat.com] > Sent: Monday, February 05, 2018 9:21 AM > To: Jens Axboe ; linux-block@vger.kernel.org; Christoph > Hellwig ; Mike Snitzer > Cc: linux-scsi@vger.kernel.org; Hannes Reinecke ; Arun Easi > ; Omar Sandoval ; Martin K . > Petersen ; James Bottomley > ; Christoph Hellwig ; > Don Brace ; Kashyap Desai > ; Peter Rivera ; > Paolo Bonzini ; Laurence Oberman > ; Ming Lei > Subject: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding = host >=20 > EXTERNAL EMAIL >=20 >=20 > So that we can decide the default reply queue by the map created > during adding host. >=20 > Cc: Hannes Reinecke > Cc: Arun Easi > Cc: Omar Sandoval , > Cc: "Martin K. Petersen" , > Cc: James Bottomley , > Cc: Christoph Hellwig , > Cc: Don Brace > Cc: Kashyap Desai > Cc: Peter Rivera > Cc: Paolo Bonzini > Cc: Mike Snitzer > Tested-by: Laurence Oberman > Signed-off-by: Ming Lei > --- > drivers/scsi/hpsa.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 287e5eb0723f..443eabf63a9f 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -8691,12 +8691,9 @@ static int hpsa_init_one(struct pci_dev *pdev, con= st > struct pci_device_id *ent) > /* Disable discovery polling.*/ > h->discovery_polling =3D 0; >=20 > - > /* Turn the interrupts on so we can service requests */ > h->access.set_intr_mask(h, HPSA_INTR_ON); >=20 > - hpsa_hba_inquiry(h); > - > h->lastlogicals =3D kzalloc(sizeof(*(h->lastlogicals)), GFP_KERNE= L); > if (!h->lastlogicals) > dev_info(&h->pdev->dev, > @@ -8707,6 +8704,8 @@ static int hpsa_init_one(struct pci_dev *pdev, cons= t > struct pci_device_id *ent) > if (rc) > goto clean7; /* perf, sg, cmd, irq, shost, pci, lu, aer/h= */ >=20 > + hpsa_hba_inquiry(h); > + > /* Monitor the controller for firmware lockups */ > h->heartbeat_sample_interval =3D HEARTBEAT_SAMPLE_INTERVAL; > INIT_DELAYED_WORK(&h->monitor_ctlr_work, hpsa_monitor_ctlr_worker= ); > -- > 2.9.5 Tested-by: Don Brace P441, P431, P830i, H240 Acked-by: Don Brace From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Brace Subject: RE: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding host Date: Mon, 5 Feb 2018 18:55:11 +0000 Message-ID: <7cd6ea234585450f972a5cdd73961e97@microsemi.com> References: <20180205152035.15016-1-ming.lei@redhat.com> <20180205152035.15016-8-ming.lei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-sn1nam02on0084.outbound.protection.outlook.com ([104.47.36.84]:49633 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753640AbeBESzV (ORCPT ); Mon, 5 Feb 2018 13:55:21 -0500 In-Reply-To: <20180205152035.15016-8-ming.lei@redhat.com> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Ming Lei , Jens Axboe , "linux-block@vger.kernel.org" , Christoph Hellwig , Mike Snitzer Cc: "linux-scsi@vger.kernel.org" , Hannes Reinecke , Arun Easi , Omar Sandoval , "Martin K . Petersen" , James Bottomley , Christoph Hellwig , Kashyap Desai , Peter Rivera , Paolo Bonzini , Laurence Oberman > -----Original Message----- > From: Ming Lei [mailto:ming.lei@redhat.com] > Sent: Monday, February 05, 2018 9:21 AM > To: Jens Axboe ; linux-block@vger.kernel.org; Christoph > Hellwig ; Mike Snitzer > Cc: linux-scsi@vger.kernel.org; Hannes Reinecke ; Arun Easi > ; Omar Sandoval ; Martin K . > Petersen ; James Bottomley > ; Christoph Hellwig ; > Don Brace ; Kashyap Desai > ; Peter Rivera ; > Paolo Bonzini ; Laurence Oberman > ; Ming Lei > Subject: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding = host >=20 > EXTERNAL EMAIL >=20 >=20 > So that we can decide the default reply queue by the map created > during adding host. >=20 > Cc: Hannes Reinecke > Cc: Arun Easi > Cc: Omar Sandoval , > Cc: "Martin K. Petersen" , > Cc: James Bottomley , > Cc: Christoph Hellwig , > Cc: Don Brace > Cc: Kashyap Desai > Cc: Peter Rivera > Cc: Paolo Bonzini > Cc: Mike Snitzer > Tested-by: Laurence Oberman > Signed-off-by: Ming Lei > --- > drivers/scsi/hpsa.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 287e5eb0723f..443eabf63a9f 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -8691,12 +8691,9 @@ static int hpsa_init_one(struct pci_dev *pdev, con= st > struct pci_device_id *ent) > /* Disable discovery polling.*/ > h->discovery_polling =3D 0; >=20 > - > /* Turn the interrupts on so we can service requests */ > h->access.set_intr_mask(h, HPSA_INTR_ON); >=20 > - hpsa_hba_inquiry(h); > - > h->lastlogicals =3D kzalloc(sizeof(*(h->lastlogicals)), GFP_KERNE= L); > if (!h->lastlogicals) > dev_info(&h->pdev->dev, > @@ -8707,6 +8704,8 @@ static int hpsa_init_one(struct pci_dev *pdev, cons= t > struct pci_device_id *ent) > if (rc) > goto clean7; /* perf, sg, cmd, irq, shost, pci, lu, aer/h= */ >=20 > + hpsa_hba_inquiry(h); > + > /* Monitor the controller for firmware lockups */ > h->heartbeat_sample_interval =3D HEARTBEAT_SAMPLE_INTERVAL; > INIT_DELAYED_WORK(&h->monitor_ctlr_work, hpsa_monitor_ctlr_worker= ); > -- > 2.9.5 Tested-by: Don Brace P441, P431, P830i, H240 Acked-by: Don Brace