All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pkrempa@redhat.com,
	qemu-block@nongnu.org, mst@redhat.com, philmd@redhat.com,
	mreitz@redhat.com, marcandre.lureau@redhat.com,
	lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 11/12] pc: Support firmware configuration with -blockdev
Date: Mon, 11 Mar 2019 18:08:41 +0100	[thread overview]
Message-ID: <7cdf93fd-504d-9371-a927-096a43394ecf@redhat.com> (raw)
In-Reply-To: <87mum1l8o9.fsf@dusky.pond.sub.org>

On 11/03/19 16:42, Markus Armbruster wrote:
>> Does it work if you add the device yourself as a child of /machine,
>> instead of relying on /machine/unattached?
> 
> I figure you're suggesting something like this incremental patch:

Yes.

> Passes "make check" and "info qtree" looks good both with and without
> -machine pflash0,...
> 
> I'm not exactly happy with "pfl0" and "pfl1".  Got a favorite color for
> my bikeshed?

"pflash[0]" and "pflash[1]"?

Paolo

  reply	other threads:[~2019-03-11 17:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 13:14 [Qemu-devel] [PATCH v3 00/12] pc: Support firmware configuration with -blockdev Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 01/12] qdev: Fix latent bug with compat_props and onboard devices Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 02/12] qom: Move compat_props machinery from qdev to QOM Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 03/12] vl: Fix latent bug with -global and onboard devices Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 04/12] sysbus: Fix latent bug with " Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 05/12] vl: Improve legibility of BlockdevOptions queue Markus Armbruster
2019-03-08 14:48   ` Philippe Mathieu-Daudé
2019-03-11 14:17   ` Paolo Bonzini
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 06/12] vl: Factor configure_blockdev() out of main() Markus Armbruster
2019-03-11 14:18   ` Paolo Bonzini
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 07/12] vl: Create block backends before setting machine properties Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 08/12] pflash_cfi01: Add pflash_cfi01_get_blk() helper Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 09/12] pc_sysfw: Remove unused PcSysFwDevice Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 10/12] pc_sysfw: Pass PCMachineState to pc_system_firmware_init() Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 11/12] pc: Support firmware configuration with -blockdev Markus Armbruster
2019-03-11 14:30   ` Paolo Bonzini
2019-03-11 15:42     ` Markus Armbruster
2019-03-11 17:08       ` Paolo Bonzini [this message]
2019-03-11 17:18       ` Philippe Mathieu-Daudé
2019-03-12  6:52         ` Markus Armbruster
2019-03-08 13:14 ` [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash Markus Armbruster
2019-03-08 13:38   ` Laszlo Ersek
2019-03-08 13:41 ` [Qemu-devel] [PATCH v3 00/12] pc: Support firmware configuration with -blockdev Michael S. Tsirkin
2019-03-08 14:39   ` Markus Armbruster
2019-03-11 17:39 ` [Qemu-devel] [PATCH v4 11/12] " Markus Armbruster
2019-03-11 17:42   ` Markus Armbruster
2019-03-11 17:45     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cdf93fd-504d-9371-a927-096a43394ecf@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=philmd@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.