From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus
	driver skeleton
Date: Mon, 25 Sep 2017 20:02:16 +0530
Message-ID: <7cf232e2-000a-85f4-2628-2945e1e7ddb1@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-3-shreyansh.jain@nxp.com>
 <be78a122-7c20-3c23-bfe0-181131de537a@intel.com>
 <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0083.outbound.protection.outlook.com [104.47.40.83])
 by dpdk.org (Postfix) with ESMTP id DB7955599
 for <dev@dpdk.org>; Mon, 25 Sep 2017 16:21:25 +0200 (CEST)
In-Reply-To: <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tuesday 19 September 2017 06:44 PM, Shreyansh Jain wrote:
> Hello Ferruh,
> 
> On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote:
>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>
>> <...>
>>
>>> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map 
>>> b/drivers/bus/dpaa/rte_bus_dpaa_version.map
>>> new file mode 100644
>>> index 0000000..d97a009
>>> --- /dev/null
>>> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
>>> @@ -0,0 +1,7 @@
>>> +DPDK_17.11 {
>>> +    global:
>>> +
>>> +    rte_dpaa_driver_register;
>>> +    rte_dpaa_driver_unregister;
>>
>> "local *;" ?
> 
> Agree. I will change this.
> Currently rte_dpaa_driver_* functions are being used locally within 
> bus/dpaa.
> 

Even though I agree earlier that I will change this (append 'local *:' 
to the file), probably I will have to skip this.
Further in the patch series, there are some symbols which are added 
which are required by the mempool and net drivers (and crypto, in 
future). Shared compilation fails for them if I add 'local: *;' here.