From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10DEC04FF3 for ; Mon, 24 May 2021 16:07:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7FAC610A8 for ; Mon, 24 May 2021 16:07:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7FAC610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A26D782C95; Mon, 24 May 2021 18:07:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="IR3wSEs0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A52B082D62; Mon, 24 May 2021 18:07:52 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0620.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::620]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BBF2D82C95 for ; Mon, 24 May 2021 18:07:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LrDyL3HoDz/TD3p9YCUfJmE1INLYTRFWIyY3TUzMXG4sqdGCHJscWVI6Mr4KXFZmNrlyox8g2SS6CvbOr5J1YnMHsVly7ASWEG8W2F+iaQjLIjRGtBWSv84+A8+REHddpck1Bwm4GWvARWc9Kbmu7iC2c3dVxEUFqCVgzaOAb01w5VW9A5kNrqAb02eiUQkkRkmPrWLVvLsbXCfRMxf3Infpjf353iyu7ra6Lgxy2ZleiOfnPTtXMbyKYBXfUqCr9onQiMmuR1TP/fnmpAg2l6gfwPPxDsyGj7j6LEQAw+8Jwss65oec98r+1u3W1lJJ/ngRRvPsEs0GAKg0puCQOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGS6ztn8LiDCZ+rYWozP54xmrr7XpGeqHoiSUS/CqkA=; b=e8gMBPpZYW3UrI5rIwZwwyk6uqpklNYm4I4/Cug1FLXOvH+o4UFt4vi47G7VrpC0ArAN2r5wIjHIE8Q2PJPumsfZQ1W5tWJliVz9LaoAT8K4NawTOI03jqa2Je8H9TosribL/a0YZhhWbk9kVqs8ejpmlsbHHX08bMhtfkAp4275ljc2IqZvMvZP7emTKxcfzSnqR9TJ5ALSoePbe/zJ+B80cmPhhQWK8hGxSJeWzW8TsgnSWxcLca4rcKIgsSZ7aWzIKaCY5j6Z7mDeSUYgGbdsUt+By6N/IMQVwlmFMDPvYM9HsL96+RL4fdBfsFddtSHn6+pHdxNOHQnG4ZomMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGS6ztn8LiDCZ+rYWozP54xmrr7XpGeqHoiSUS/CqkA=; b=IR3wSEs06Gjv8b6hTIRa8foHyFa+IWFl6AAD8EUPp3S3W2YE+EO4xtur540JOIFfxJs65QywAdlEXoSHpDHvL++lL3y+Iqim/Ck9MaYCmTqJa9Rb4vktGKBz1omN7oAPIU4AwUhm1gisn5FYybuQ9Ayx6KCOIx9rvQyL+YJ7D5c= Authentication-Results: denx.de; dkim=none (message not signed) header.d=none;denx.de; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DBBPR03MB7146.eurprd03.prod.outlook.com (2603:10a6:10:209::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Mon, 24 May 2021 16:07:48 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::40d5:3554:c709:6b1b]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::40d5:3554:c709:6b1b%5]) with mapi id 15.20.4150.027; Mon, 24 May 2021 16:07:48 +0000 Subject: Re: [PATCH v5,1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function To: Meng.Li@windriver.com, u-boot@lists.denx.de, chin.liang.see@intel.com, dinh.nguyen@intel.com, sjg@chromium.org Cc: sr@denx.de References: <20210524022249.16841-1-Meng.Li@windriver.com> From: Sean Anderson Message-ID: <7cf652da-4c3d-861e-bb23-5af0a3450c7b@seco.com> Date: Mon, 24 May 2021 12:07:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20210524022249.16841-1-Meng.Li@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: MN2PR16CA0045.namprd16.prod.outlook.com (2603:10b6:208:234::14) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [172.27.1.65] (50.195.82.171) by MN2PR16CA0045.namprd16.prod.outlook.com (2603:10b6:208:234::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 16:07:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85de9823-b39c-46d4-0a57-08d91ece1330 X-MS-TrafficTypeDiagnostic: DBBPR03MB7146: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M193KsEG8gxtA+6RRdLkTOezmXP2/I/uAgJ2AYD1CW01nMRtUVOdze1PJUG5TnAoVMVqHmxS5D1SaC2CGfYUryeC0NvCPuAWJQB7dqyz/5FSmSmRmpzomqL3n/NaB/ZNx+woCOSu2dyRNmuxsmx6PCMpx/VEoeHgdhO6BHHAmqcN+Q61cESu1spMei2MEVIv2H1gIXCy86SCi2rylt0no044aT1Pm3M4K8VwRd2pRNp/p8kltvGorK3cOpIOfJsXqCQmTX040I4jouBu5ccgWgK2bHp2zLf/NBTqarFO6Xrvbp1rotp9okWLMTxAVBNTMgvrbpB4VgVlwjpCOYdXvV0g0Q1jInIs5ZuMNUo1I7JfqQwjjIZQIUAdTUTslVoyN6Y4pk3mQ9Dti09+f+L7oNeZdJu6xJrh9p+W4YSCORbkCuOv5LAkI1TB9hv6MCvLqGuEck2ZCUldSR5L2Dq84yu95ys9gy+CJGIozxuBIBoY7N2DoPguv00c/yEyoCwXR5HPXtZ66n6y819wRY0uuEokBKnNtVdY+/YoGQvRg8zYlXwn/h12zEtECWJHLDFaH3QdPdtGrf/epjnJYiiGfGomRZdD5wChaudt4Kn+y2RTLci02m/AcWlyGk/YGbXgGE1hmkxf4+WtvbWlDDBnTHQV1WotXE9SCO8yOCp08pwOKhOCeTiMBGBBLqti2jHqS4mRmUHTOyqQwuMNGko+GjVArzquHY+FAiDDST3+7ps= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(39840400004)(396003)(366004)(376002)(136003)(346002)(66946007)(26005)(53546011)(2616005)(31686004)(478600001)(66556008)(4326008)(8676002)(44832011)(66476007)(5660300002)(8936002)(956004)(16526019)(36756003)(52116002)(6486002)(316002)(2906002)(83380400001)(38100700002)(38350700002)(16576012)(86362001)(31696002)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Mm85OFRyRlJWRU5UOTJwS0VneE16VHV3WkR5WFVTVEdVZGRBaWpjb1ZGNVI2?= =?utf-8?B?dnZ5bWtvVFZFTFBSNzJFVk1CYlF2VEFYVlM3aFRDOWp1dEF5TzRzbzJNd1RR?= =?utf-8?B?RkZnUEU4bS84b3RzQVRwbXpsVFcxZmU4ZG5iS3c2NXpBK29uNnRNeWRxKzZh?= =?utf-8?B?U3k1NFphK2ptakFKWGZOcWtVQUcreFY3VnZrSmZFSm9VR3VGZXVyWGlxS096?= =?utf-8?B?MysraUkyZzJqSFEwNmxzN2dBZWdlcEh3aFpCZ3RaOC8zT0I0MXFTUk13dXpZ?= =?utf-8?B?eDZoV3p0ckhDbVRhak1iT1o4VVBZNC9jMnlKRmhlZnVjRW5xbVc4aS9wTkxz?= =?utf-8?B?OS95ckpkRWQ0WG5QZFl0TlplTU5CcWVBdW54dkJ3NkRZS3pVcEI1T3U1cFZp?= =?utf-8?B?VFFwY0lRc0lYSU1JcEExZG1LNHdwOU0ycXBFN2REMkYvZXVjZ2dZcHNOb2xq?= =?utf-8?B?akFkM3gzOGFIeThqREpGT3c2VTZ6cDBYSlUxM3RHeUV3VnN0Vzh4bTVWeUxM?= =?utf-8?B?MDNnbmpRanJvbENrTEdJdEljVWNHN1FWSGtIeHl4aEhyNWdCTkRRWHBLd2Rn?= =?utf-8?B?WHI5YzRpak0xMjdaL3J5ZTJYeWxWL2xqNC9jNEJxVVFvNE83Sm9EWDh0L0Np?= =?utf-8?B?OVdsZytRUmVCYkQway94WUVYVWJrTlNSeEFROURkYlY4NjRJNWtQOGZQdzgr?= =?utf-8?B?OEl2ZEpvMDRtTVZoMkFEY3NQQVdWN1JJbUJxazdBb3UzY0g0TzluUFJXaWFB?= =?utf-8?B?QWt3VFJFZXR6TDl5SXltSzNoOE9VM0Y2OG9Zc0czcUNyWkkxTnI2RmVQeDlS?= =?utf-8?B?OGZDRWdBREszL2xNYk1yeC9URzdhbkdQV3h4MHV5Z3BBRHVYRDIweXFzbnor?= =?utf-8?B?NWhCbVZIZm1aeFhSMFhVUVpmWVBGazNvSU95Ukc1Qm42RkQvSEZyNVUvMjNB?= =?utf-8?B?MkppVVk0WVVyTitRR1VRVmd3bW5MN3dQQ0JOZm00dkMrOTdaclY0VUpkZldS?= =?utf-8?B?Mml1aldzdXBWRFU5L25GRWIzajBkNnhZMzIyN0M1T1ozbFFJNEJkakFoL1Ex?= =?utf-8?B?RE5vMXNhYVVuUnkyNHdmQW1ybWRkR2FlYk5FWFBiL0xRMFRQWmRXcEtHL0Vr?= =?utf-8?B?cWdrWjB5YlhZRWI3RElHbStrcDZVUEJEM3B4Zmpta2NDR2VFS1UzZWYzdko2?= =?utf-8?B?ZzJYTGtFK2RlTmRkajF4ZW9SanJHZDBxWjZwanAvSndveFRxTnJ1bkMxQlpt?= =?utf-8?B?TXZReFhrbU8raHNlZ0Q5YVZxMHNiR0lpWXhYUUxrL2djQTlLbWpERzY1YW81?= =?utf-8?B?SWxkNTNHUFpNb3h0VE51djluNXlqUFZQZ2pabXhBWHFWczBUL0xrTHdWSll5?= =?utf-8?B?cU1pYnJjZ1F4MVhPdEV6aVN3TCt5TnJaSFRMMlBZbk5VdXZKc0JwemYyYnh4?= =?utf-8?B?NmhGbTlocU1lYk1leWVkKys0cEJPY2NYeENzQkc5Q2pmYkZjUGJmREYxZ1Ar?= =?utf-8?B?NjhNQ2dybUhTM21OSXBCb3U0L05wbGUyTGt1OU54QTVyV2hWK0pjRUpGL3g4?= =?utf-8?B?OVN1UUNac09NdHFwK0dXOHcySE5zTXdZZE9SVUVpeHZCOG91WUZWQVV6OUYw?= =?utf-8?B?Q0ttdEZxU0piVUthUUpTWVBtRGgrUFRtbndaQ0NCOTVpandMUEEyUnVrVEFs?= =?utf-8?B?QytYc25kZVhFSlFmeVhZSzRUWmZHelRHT3ZrTC83Q3IzRzg0Um5qYUM2YUJ2?= =?utf-8?Q?U/+mqcleYModzRwDujxXGrT8NMsaFU1EmUMWmHA?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85de9823-b39c-46d4-0a57-08d91ece1330 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 16:07:48.4537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cgyhD2oeUwUr9wYUV/AkNpMELpFznkjCG+j2WWmFOnXKio1pT4Vz+pp9GO0c0Dds3mEvihCWfDzDvyGmynaJlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB7146 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 5/23/21 10:22 PM, Meng.Li@windriver.com wrote: > From: MengLi > > In uboot command line environment, watchdog is not able to be > stopped with below commands: > SOCFPGA_STRATIX10 # wdt dev watchdog@ffd00200 > SOCFPGA_STRATIX10 # wdt stop > Refer to watchdog driver in linux kernel, it is also need to reset > watchdog after disable it so that the disable action takes effect. > > Signed-off-by: Meng Li > Reviewed-by: Stefan Roese > > --- > v5: > fix build issue, and verify this patch with latest upstream u-boot. > v4: > Remove the unauthorized signature. > v3: > Add the resets to designware_wdt_priv and initialize it in probe(). > v2: > Change "#if CONFIG_IS_ENABLED(DM_RESET)" into > "if (CONFIG_IS_ENABLED(DM_RESET)) {", and define the variable > into if condition sentence. > --- > drivers/watchdog/designware_wdt.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/drivers/watchdog/designware_wdt.c b/drivers/watchdog/designware_wdt.c > index 9e5487168c..afed81e6c6 100644 > --- a/drivers/watchdog/designware_wdt.c > +++ b/drivers/watchdog/designware_wdt.c > @@ -22,6 +22,7 @@ > struct designware_wdt_priv { > void __iomem *base; > unsigned int clk_khz; > + struct reset_ctl_bulk *resets; > }; > > /* > @@ -95,6 +96,18 @@ static int designware_wdt_stop(struct udevice *dev) > designware_wdt_reset(dev); > writel(0, priv->base + DW_WDT_CR); > > + if (CONFIG_IS_ENABLED(DM_RESET)) { > + int ret; > + > + ret = reset_assert_bulk(priv->resets); > + if (ret) > + return ret; > + > + ret = reset_deassert_bulk(priv->resets); > + if (ret) > + return ret; > + } > + > return 0; > } > > @@ -143,13 +156,11 @@ static int designware_wdt_probe(struct udevice *dev) > #endif > > if (CONFIG_IS_ENABLED(DM_RESET)) { > - struct reset_ctl_bulk resets; > - > - ret = reset_get_bulk(dev, &resets); > + ret = reset_get_bulk(dev, priv->resets); > if (ret) > goto err; > > - ret = reset_deassert_bulk(&resets); > + ret = reset_deassert_bulk(priv->resets); > if (ret) > goto err; > } > Reviewed-by: Sean Anderson