From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/2] clk: davinci: pll-dm646x: keep PLL2 SYSCLK1 always enabled To: David Lechner , Michael Turquette , Stephen Boyd CC: Linux clk Mailing List , Linux ARM Mailing List , Kevin Hilman References: <20180511141037.25250-1-nsekhar@ti.com> <20180511141037.25250-2-nsekhar@ti.com> From: Sekhar Nori Message-ID: <7d060dec-562e-993c-7af4-c3524ba0b946@ti.com> Date: Mon, 14 May 2018 15:35:53 +0530 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" List-ID: On Sunday 13 May 2018 02:50 AM, David Lechner wrote: > On 05/11/2018 09:10 AM, Sekhar Nori wrote: >> PLL2 SYSCLK1 on DM646x is connected to DDR2 PHY and cannot >> be disabled. Mark it so to prevent unused clock disable >> infrastructure from disabling it. >> >> Signed-off-by: Sekhar Nori >> --- >>   drivers/clk/davinci/pll-dm646x.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/davinci/pll-dm646x.c >> b/drivers/clk/davinci/pll-dm646x.c >> index eb96dd72b6b7..5bdf1cb5fda8 100644 >> --- a/drivers/clk/davinci/pll-dm646x.c >> +++ b/drivers/clk/davinci/pll-dm646x.c >> @@ -72,7 +72,7 @@ static const struct davinci_pll_clk_info >> dm646x_pll2_info = { >>       .flags = 0, >>   }; >>   -SYSCLK(1, pll2_sysclk1, pll2_pllen, 4, 0); >> +SYSCLK(1, pll2_sysclk1, pll2_pllen, 4, SYSCLK_ALWAYS_ENABLED); >>     int dm646x_pll2_init(struct device *dev, void __iomem *base, >> struct regmap *cfgchip) >>   { >> > > FYI, this only applies on top of "clk: davinci: pll: allow dev == NULL". > Not sure if that was intentional. Not actually. I will resend the series as it applies to v4.17-rc1. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Mon, 14 May 2018 15:35:53 +0530 Subject: [PATCH 1/2] clk: davinci: pll-dm646x: keep PLL2 SYSCLK1 always enabled In-Reply-To: References: <20180511141037.25250-1-nsekhar@ti.com> <20180511141037.25250-2-nsekhar@ti.com> Message-ID: <7d060dec-562e-993c-7af4-c3524ba0b946@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sunday 13 May 2018 02:50 AM, David Lechner wrote: > On 05/11/2018 09:10 AM, Sekhar Nori wrote: >> PLL2 SYSCLK1 on DM646x is connected to DDR2 PHY and cannot >> be disabled. Mark it so to prevent unused clock disable >> infrastructure from disabling it. >> >> Signed-off-by: Sekhar Nori >> --- >> ? drivers/clk/davinci/pll-dm646x.c | 2 +- >> ? 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/davinci/pll-dm646x.c >> b/drivers/clk/davinci/pll-dm646x.c >> index eb96dd72b6b7..5bdf1cb5fda8 100644 >> --- a/drivers/clk/davinci/pll-dm646x.c >> +++ b/drivers/clk/davinci/pll-dm646x.c >> @@ -72,7 +72,7 @@ static const struct davinci_pll_clk_info >> dm646x_pll2_info = { >> ????? .flags = 0, >> ? }; >> ? -SYSCLK(1, pll2_sysclk1, pll2_pllen, 4, 0); >> +SYSCLK(1, pll2_sysclk1, pll2_pllen, 4, SYSCLK_ALWAYS_ENABLED); >> ? ? int dm646x_pll2_init(struct device *dev, void __iomem *base, >> struct regmap *cfgchip) >> ? { >> > > FYI, this only applies on top of "clk: davinci: pll: allow dev == NULL". > Not sure if that was intentional. Not actually. I will resend the series as it applies to v4.17-rc1. Thanks, Sekhar