From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: Intel: Disable SND_SOC_INTEL_BAYTRAIL when SND_SST_ATOM_HIFI2_PLATFORM is enabled
Date: Fri, 13 Apr 2018 09:50:45 -0500 [thread overview]
Message-ID: <7d14acfc-f9e1-f408-2f76-bf00ab8b9534@linux.intel.com> (raw)
In-Reply-To: <20180413124537.6765-1-hdegoede@redhat.com>
On 4/13/18 7:45 AM, Hans de Goede wrote:
> The sound/soc/intel/common/sst-acpi.c code only tries to load the
> "baytrail-pcm-audio" driver (and supporting board drivers) when
> SND_SST_ATOM_HIFI2_PLATFORM is not enabled, since otherwise these
> are handled by snd-soc-sst-atom-hifi2-platform.ko.
>
> Since these thus will never be used when SND_SST_ATOM_HIFI2_PLATFORM is
> enabled, building these drivers when it is enabled is useless.
>
> Add a Kconfig dependency to reflect this, so that SND_SOC_INTEL_BAYTRAIL
> cannot be enabled when SND_SST_ATOM_HIFI2_PLATFORM is also enabled.
We had this before and I dropped it when we cleaned the code, mainly
since this dependency is one-sided and the selections in menuconfig are
a bit odd. It's really a mutual exclusion we'd want.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> sound/soc/intel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index ceb105cbd461..640f9bc9bd46 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -61,7 +61,7 @@ config SND_SOC_INTEL_HASWELL
>
> config SND_SOC_INTEL_BAYTRAIL
> tristate "Baytrail (legacy) Platforms"
> - depends on DMADEVICES && ACPI
> + depends on DMADEVICES && ACPI && SND_SST_ATOM_HIFI2_PLATFORM=n
> select SND_SOC_INTEL_SST
> select SND_SOC_INTEL_SST_ACPI
> select SND_SOC_INTEL_SST_FIRMWARE
>
next prev parent reply other threads:[~2018-04-13 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 12:45 [PATCH] ASoC: Intel: Disable SND_SOC_INTEL_BAYTRAIL when SND_SST_ATOM_HIFI2_PLATFORM is enabled Hans de Goede
2018-04-13 14:50 ` Pierre-Louis Bossart [this message]
2018-04-13 16:56 ` Hans de Goede
2018-04-18 17:23 ` Pierre-Louis Bossart
2018-04-19 12:12 ` Applied "ASoC: Intel: Disable SND_SOC_INTEL_BAYTRAIL when SND_SST_ATOM_HIFI2_PLATFORM is enabled" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d14acfc-f9e1-f408-2f76-bf00ab8b9534@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.