From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87254C433F5 for ; Tue, 5 Apr 2022 19:07:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9757D10EE6A; Tue, 5 Apr 2022 19:06:59 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B53310EE6A for ; Tue, 5 Apr 2022 19:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=t/jIi5NMSsGNuqWW3SuqC3XVvuEfpO7XbqF5AkaA5/U=; b=LPMKtFqBIJkiHt5K/vxQqvOLCu mTtahlGt/q4Xpf4OXU3LL8wuiNduEjzWzNq55unSnMzDk7CYvfowt/vKjj6bjlwQgADze5JQ9Psjo zoI+TVMYGfEfL4P70Pe2PFL/JxdwFD2I4WP+DyRear6bSQKw2eCB5CfybzmgtTuN/LMtSQTqF2OfR ZPzyowE2VLduY70zxf3YLEz4HZ23/teHo3NsyN9eJJ7+txeZLiIBHgyiORbDW7nI1nMeYFRmNjw9f Q6GuLgBNJCpOjbQZRtb3BmZB9wR7iHknQ9vB8LaKHfyWS17w82ksHoUVL6oTdaV3zrqFlq0Ltqr83 sN+Qa8aQ==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nboVq-006ykA-C2; Tue, 05 Apr 2022 19:06:46 +0000 Message-ID: <7d16caee-e605-d80b-6638-3ada4dbc4f67@infradead.org> Date: Tue, 5 Apr 2022 12:06:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/format_helper: fix a kernel-doc typo Content-Language: en-US To: Simon Ser References: <20220403232902.1753-1-rdunlap@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Thomas Zimmermann , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 4/5/22 11:47, Simon Ser wrote: > On Tuesday, April 5th, 2022 at 19:58, Randy Dunlap wrote: > >> On 4/5/22 08:05, Simon Ser wrote: >> >>> On Tuesday, April 5th, 2022 at 16:39, Randy Dunlap rdunlap@infradead.org wrote: >>> >>>> On 4/4/22 23:26, Javier Martinez Canillas wrote: >>>> >>>>> On 4/5/22 08:12, Simon Ser wrote: >>>>> >>>>>> On Monday, April 4th, 2022 at 23:35, Randy Dunlap rdunlap@infradead.org wrote: >>>>>> >>>>>>> On 4/4/22 09:04, Simon Ser wrote: >>>>>>> >>>>>>>> Both doc patches pushed, thanks. I had to manually edit them because they >>>>>>>> wouldn't apply cleanly. Next time, please use git-send-email (see >>>>>>>> https://git-send-email.io/ for setup instructions). >>>>>>> >>>>>>> That's odd. I did use 'git send-email' and I don't usually have any >>>>>>> problems (AFAIK). I'll check those setup instructions. >>>>>> >>>>>> Hm, maybe the issue isn't git-send-email, but the way the patch was >>>>>> generated? I had to manually edit these lines for the first patch to work: >>>>>> >>>>>> --- linux-next-20211217.orig/include/drm/drm_file.h >>>>>> +++ linux-next-20211217/include/drm/drm_file.h >>>>>> >>>>>> I changed these to: >>>>>> >>>>>> --- a/include/drm/drm_file.h >>>>>> +++ b/include/drm/drm_file.h >> >> >> quilt (which I am using) can generate a/ b/ patches instead of linux.orig/ and >> linux/ patches. >> >>>>>> This wasn't enough for the second patch, I had to re-do the changes by hand >>>>>> from scratch. >> >> >> I would like more information about this one if it's not too much trouble >> for you. > > IIRC it was the usual git-am error "fatal: sha1 information is lacking > or useless". Maybe you wrote the patch for an old tree and drm-misc-next > contained changes near the lines you changed? Maybe providing base-commit > information in the patch would've helped? I'm not sure. OK, thanks Simon. -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA5EC4332F for ; Tue, 5 Apr 2022 21:32:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378792AbiDEVcY (ORCPT ); Tue, 5 Apr 2022 17:32:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573408AbiDETIz (ORCPT ); Tue, 5 Apr 2022 15:08:55 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BF18DFFAA for ; Tue, 5 Apr 2022 12:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=t/jIi5NMSsGNuqWW3SuqC3XVvuEfpO7XbqF5AkaA5/U=; b=LPMKtFqBIJkiHt5K/vxQqvOLCu mTtahlGt/q4Xpf4OXU3LL8wuiNduEjzWzNq55unSnMzDk7CYvfowt/vKjj6bjlwQgADze5JQ9Psjo zoI+TVMYGfEfL4P70Pe2PFL/JxdwFD2I4WP+DyRear6bSQKw2eCB5CfybzmgtTuN/LMtSQTqF2OfR ZPzyowE2VLduY70zxf3YLEz4HZ23/teHo3NsyN9eJJ7+txeZLiIBHgyiORbDW7nI1nMeYFRmNjw9f Q6GuLgBNJCpOjbQZRtb3BmZB9wR7iHknQ9vB8LaKHfyWS17w82ksHoUVL6oTdaV3zrqFlq0Ltqr83 sN+Qa8aQ==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nboVq-006ykA-C2; Tue, 05 Apr 2022 19:06:46 +0000 Message-ID: <7d16caee-e605-d80b-6638-3ada4dbc4f67@infradead.org> Date: Tue, 5 Apr 2022 12:06:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/format_helper: fix a kernel-doc typo Content-Language: en-US To: Simon Ser Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org References: <20220403232902.1753-1-rdunlap@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/5/22 11:47, Simon Ser wrote: > On Tuesday, April 5th, 2022 at 19:58, Randy Dunlap wrote: > >> On 4/5/22 08:05, Simon Ser wrote: >> >>> On Tuesday, April 5th, 2022 at 16:39, Randy Dunlap rdunlap@infradead.org wrote: >>> >>>> On 4/4/22 23:26, Javier Martinez Canillas wrote: >>>> >>>>> On 4/5/22 08:12, Simon Ser wrote: >>>>> >>>>>> On Monday, April 4th, 2022 at 23:35, Randy Dunlap rdunlap@infradead.org wrote: >>>>>> >>>>>>> On 4/4/22 09:04, Simon Ser wrote: >>>>>>> >>>>>>>> Both doc patches pushed, thanks. I had to manually edit them because they >>>>>>>> wouldn't apply cleanly. Next time, please use git-send-email (see >>>>>>>> https://git-send-email.io/ for setup instructions). >>>>>>> >>>>>>> That's odd. I did use 'git send-email' and I don't usually have any >>>>>>> problems (AFAIK). I'll check those setup instructions. >>>>>> >>>>>> Hm, maybe the issue isn't git-send-email, but the way the patch was >>>>>> generated? I had to manually edit these lines for the first patch to work: >>>>>> >>>>>> --- linux-next-20211217.orig/include/drm/drm_file.h >>>>>> +++ linux-next-20211217/include/drm/drm_file.h >>>>>> >>>>>> I changed these to: >>>>>> >>>>>> --- a/include/drm/drm_file.h >>>>>> +++ b/include/drm/drm_file.h >> >> >> quilt (which I am using) can generate a/ b/ patches instead of linux.orig/ and >> linux/ patches. >> >>>>>> This wasn't enough for the second patch, I had to re-do the changes by hand >>>>>> from scratch. >> >> >> I would like more information about this one if it's not too much trouble >> for you. > > IIRC it was the usual git-am error "fatal: sha1 information is lacking > or useless". Maybe you wrote the patch for an old tree and drm-misc-next > contained changes near the lines you changed? Maybe providing base-commit > information in the patch would've helped? I'm not sure. OK, thanks Simon. -- ~Randy