From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933232AbeAOMay (ORCPT + 1 other); Mon, 15 Jan 2018 07:30:54 -0500 Received: from mail-eopbgr30121.outbound.protection.outlook.com ([40.107.3.121]:14400 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933102AbeAOMav (ORCPT ); Mon, 15 Jan 2018 07:30:51 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v4] mm/memcg: try harder to decrease [memory,memsw].limit_in_bytes To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shakeel Butt References: <20180109152622.31ca558acb0cc25a1b14f38c@linux-foundation.org> <20180110124317.28887-1-aryabinin@virtuozzo.com> <20180111104239.GZ1732@dhcp22.suse.cz> <4a8f667d-c2ae-e3df-00fd-edc01afe19e1@virtuozzo.com> <20180111124629.GA1732@dhcp22.suse.cz> <20180111162947.GG1732@dhcp22.suse.cz> <560a77b5-02d7-cbae-35f3-0b20a1c384c2@virtuozzo.com> <20180112122405.GK1732@dhcp22.suse.cz> From: Andrey Ryabinin Message-ID: <7d1b5bfb-f602-8cf4-2de6-dd186484e55c@virtuozzo.com> Date: Mon, 15 Jan 2018 15:30:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180112122405.GK1732@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0102CA0015.eurprd01.prod.exchangelabs.com (2603:10a6:7:14::28) To AM4PR08MB2820.eurprd08.prod.outlook.com (2603:10a6:205:d::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 482189c9-9349-4c4e-23d7-08d55c13ceeb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:AM4PR08MB2820; X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2820;3:p5i6N3UaSMDw1jMFawX3AIBdHm617R+YfWlz3D+g/XkO1bID303BHAIYLM33xfJqQTsTuRB1f6HMixLcqMQtPr3N+lQYC4JFMC/g8FSEVkIVskLDNpVtOLfASHQuxRJ0K2UVqhpx8idwP+7KSveqI7eS31CoQWsYVYIO9/Xl6o1rNWkA5iL1t4DG4mt639NRQnB3oyQtOlopio20wemwyS34IV4UM4FxFy9hKsk9lgoauGi1LNLFNrwmW6xmUS+/;25:PAemyESbT1ev4r9SvVx2UX+4PW/TnX/1yDYhK4wE+NaL7sPdkTMoGsN55u7mAcHV6vSGbfvycTL+edZL0MTd4bnWiTzBxfTuMKIjBGSX9lmsCqHxLLvQW9vJygrKgTL7zO7MBF1Mco13o1IWbprdmXPyUI8sgxAX0bPPcXeZfWJsVC098NFHvKOQB8XnHy6/tJBr/hI/F+QL8DDygtt/pgV/h90VrUn2NIiiPk2BjzOE9aZGgCM5ZFfgHRNen0+5z32jFwrPCYav4IeTm7B9EM/5/IRg8zK5doiMMf13xXg9HlmC0zGhI7zPLXdiN46IZQ4RB8CYdpnFnSqbwkDrYg==;31:PLRYR1v1vPt1JaLfniTrS4rdDUv3Si6f+il6QLh6lINYwawoSIWU29Gxcoem/QrT8wYWV887KwFZKygQjrfXLde7jhZ8AtMFs2CnNVRslCWi+KsEK987zkTlLmgoiTf4xbXE5UAKRkn0DlQTiPxTcu+Puo6L9OeDTzCcy81IK47nYLjmwogtYyNVC87x/Rbp4mR1gnLW+L5Q7lggwe8aHn9pEiaTClWJ60MX+Gwt39U= X-MS-TrafficTypeDiagnostic: AM4PR08MB2820: X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2820;20:T73yfQhDrZvVCrz8DbHXSi6NkPLM3lDt7bZcPYzqy3Qyh4VdTGiPODQ3cMY8b/QCIYQM8c4+QOJbWMSKGUm5sIRtuejbywgTuR4axjfp8ExSNKeum0WnQJkhA0pZNt/M5+f7QAg5zXe4J1E5ROwUvzf+RriYbaoLPjCvL7C5jquNLwhNDcZMQUpo4LNOsI5b8eWO48ku68RgLnCotwBmxeeOlrIQdx32MUvdxqFa610V2H1JyeE/6bLlo2QZVRU+f+MHUjzjLL/aphNWBjDrhWHQNzyiw9eX32imvxAam67MMUIMpC5bReO7iECUvUNw3ptb16EsAOpn/b0WPAK/o/PAuQsOI4Px8OAnSELRGoPC66OjUtpF8vOKU/L5NmNVcQ6VuxH+X2n6E0MpUjHkSZ/amFy3sJABu2nBT4ZQazc=;4:zCb/uFfuvQYLadSnEh0Bm0SdQ2c7PJI2RWGWu3MTfQ0TgR+iOQuqExM9musMaqUIvV/br+9jNe8y6XIDsBYuefMerVDGPjXJQTrsRQ2kpjoxQBm5l+AojJdbZveP8yRvTQCoTFesKf+mJggqQWf0Ppw4A9qob/ytZIVl1Gx8XirdC1Mz7cN9JMezqNwRwY38Bx4yGBl0StHn1r/rJX/EOVZCBeLTmnfoORVdT2JIAs9qFUs+nxeIlpVBZrJIXGVZXfD4LaZAoCpjCNfYgzeHAA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231023)(944501161)(10201501046)(6041268)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011);SRVR:AM4PR08MB2820;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM4PR08MB2820; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(39380400002)(366004)(39840400004)(376002)(396003)(346002)(189003)(199004)(377424004)(24454002)(4326008)(6246003)(8936002)(47776003)(66066001)(65806001)(105586002)(50466002)(77096006)(81156014)(6486002)(8676002)(6116002)(25786009)(65956001)(81166006)(31686004)(68736007)(2906002)(39060400002)(3846002)(229853002)(478600001)(7736002)(386003)(316002)(36756003)(106356001)(230700001)(86362001)(53546011)(65826007)(58126008)(52146003)(2950100002)(2486003)(6666003)(54906003)(6916009)(52116002)(23676004)(93886005)(76176011)(5660300001)(31696002)(16526018)(97736004)(16576012)(305945005)(53936002)(64126003)(83506002)(34023003)(148693002)(142933001);DIR:OUT;SFP:1102;SCL:1;SRVR:AM4PR08MB2820;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjA4TUIyODIwOzIzOkFpSHZEYXkxNGdQOFBLKzE2bFplQTFKOThE?= =?utf-8?B?YVYvL3ZPTGgwM1BWNnN5SlF5NU9rODU3QWszY2FRTTBNLzZlMDl3eXJhRDJm?= =?utf-8?B?MmhqekRRdVRZNWpHQlFGVEdTejhSSUQ2U0xTTTY1QllkL0VVRGtrRU9OYTZP?= =?utf-8?B?bHV3QmNrbzV3RHBDRDA0UzNCeDAzejJlTGlKUWppM1c4Z1dIMzlyckFpWThH?= =?utf-8?B?aXI0a2F6ZUlMQTJ6NWNoWnBYM0xLZE1FNFU4Q1g4TWI3RjZQdDAwUXA3ckxF?= =?utf-8?B?Sm42Z1QrY2lqNEdJRXJub0x0QzJuYUhleWQvSHBTSnFmNDlFekIxazRGTzBk?= =?utf-8?B?MGhCU0dTRFdzZVhyZFBTV3UzN1VVeitFNzdySEdONjNHdGU0K1JiakY3Qjk2?= =?utf-8?B?REI4cEZwK25nM1FIR1Z2bVA0UkprQURURXYwNFoyTmloc3R5ZHlSN1RDa1lT?= =?utf-8?B?RlJyNmd2RTE1aWNkR2RQK1B6NTkvYWpPQWNhajJiNWo3ZFdvMmN0bENtb1pv?= =?utf-8?B?NlNCbXU4VHlRVUEzSUd5REl6OVRETjlUREt6WFhnZHJmT2cwbVlxck1yUi9y?= =?utf-8?B?encwUU5QazNRaS9ZTUwvWGk0Z2p4d3NDTVJBVUptNW5NQU8zTzMycmVsVld1?= =?utf-8?B?UGJ6U1p3RUg2c0xQb0doMnQrNXRVdEZBaFd5ak00SFhhTG5LMk0rVDZiZ202?= =?utf-8?B?NXpiT2UreXpHWVJRcE9HYXNWMzdNR291NnZQN05ncGNiZWxnR05SU1VxcDRG?= =?utf-8?B?WW5Vb2hkcVlCSUxoTEF4Y3NHSVhuWEQrMGZWdlRsaFZnOUIwZGZGZkRoSGVY?= =?utf-8?B?Ky83bnR1OFdlYkdTK2RBRmQzYms3WnhFdVU0VFdGZzU5a1FVMzM0dUlldmlk?= =?utf-8?B?T2JCZ3VoQnB6a2RBS1BPSUJxY0ljN2Q3ZkFmUFp6UFVDNEMweG9nQWYyZHJu?= =?utf-8?B?Ui9BeWY0U1pwSHA4TmxIb0lqdjJjWHVhM242aW13RmEvSHpHQ1E1TGh6SFZG?= =?utf-8?B?dFh2dmlKbWxzMFRtUXp6QlorUFJsZlFzZ1kzNEpick4zcTYyRnl4UGVkOFRt?= =?utf-8?B?cXduWSs3ZzFIWndzY1FZWkJvY0VOSTd0eUtzMXUwTmp5UWowNm1OYjBHdzd3?= =?utf-8?B?MUNMcllud0ltRGxGcTdBSTFRT01WdDBkZEhvY0tacWpmV1FvZUI3dXBLczVQ?= =?utf-8?B?clh3YzlLWHA4UUFCU3M4cGY3YytPTkR5VXRzRnJpS29kN2puM2RrcGI2SGlE?= =?utf-8?B?a2xMUWx2S0NWL1pPL3oxR01zVGpkajRqL09jQXR3eXQ3dkFWU1Z3VWtmeW40?= =?utf-8?B?VDB6MUFzOHZYQzVBWGs5b3pZaG55VS9iMUMzY0M3QU8xK2hlMVVNby9NenFt?= =?utf-8?B?Y3A5cnZxeE96R2dzMWNCZTJpQVp5dlhtdnB1SUZyOE9DZlN6cllpSWZPVHhu?= =?utf-8?B?OGo2ejdMMGk2QUFxZzcrZ0M0bktmUm9NL1dKZ0M5ajU2aGo4V2JrR2hwSlE0?= =?utf-8?B?Z1E2NGVMYjAvRFBkNWJHOWJDQnpDT0lMeVRVUzM4c2VrMk5FNjRxRlhjNkdL?= =?utf-8?B?UC9veUwvWTZRUTUzMmE5Q2VWeG9XdHVRbllMYXVQc25QajdMbVNiWnBFY0Zk?= =?utf-8?B?Z1ZVR09vaEpFSXplMnNsckEvVGU2OXZPeDNWVFp5K3c2ZDFPcVh6cFUwVFIx?= =?utf-8?B?MmpUODdmanBoL1NCQU1zV3R3RWdYWitjL0VNSW5Ba3JESW1wZmh1WlRlSmYw?= =?utf-8?B?RFc4UjVaZENuRlZtVWZTSFZScGFFOEUzNXBZTjN1eGJsazVNNUlpeVB0MStT?= =?utf-8?B?NG1CUkpaOC9weE9CQzd0Z0hIK01EQ1dheHNvOGd2YktTbjU4QklGUkxtZFF1?= =?utf-8?B?UG9UOEIvNEJZdkxSSGlvTitRUWNDUVd4aU9KSlVQbEYrM005NzdQYkNOTTVS?= =?utf-8?B?V2MyK2QwYWlMT1BzNkgzNS9LeTF2QlFMblE4aWFhN2s4d3psdGk5dnJvK1hQ?= =?utf-8?B?dG9tcnFBZEJFb2U3MVpkeHh4alpkMHpuMzd2MldNOVBOOGVUZ0pvMWFzZ3Jk?= =?utf-8?Q?EPr4=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2820;6:pT5mi++d4u3ewfWMvqcWm4XUxAjUGOhlfyOKS0kgjFSh8580cLWTzEZ5WZgzfyBfuea3DLl+qzcsE6+T5Fgzs2a2EbbzXnHcDXqsuQIw6BYoRiwIya9xo5LWfEiT8rp/fz64+qeVD1tlngoLdumKGkJ2XhRbZrhofwUqAFNms5YwJkx20Ajy5lSvDNywJf5wUbD7Yc3O9kvR8+UeHgNbfBiAHym5Wg/DShdFKpVFSxk3l5x+5VoN7F7uFtOZ6M6miQnbCY+MUKFHB6MNdHHV6yhsrHu3CXG0ETq2rUdlBr+cnW8a2pwQ4hOH4/EkpN1Jf1xUQUi4N4W6LNDrVw6W61iLfBPXShhOsLVRHFHBZMI=;5:A+iNXajjrRuXdAg/AUyya0C6ohXclSogH/29Viu10KduRslLMAGAFD1VSx6aBCnQ+yn6AZxLN6WlrEm6N3gxzJbfFj2CFtCC7aIcOg/Z8zje92MH35ANFBaaa+UoAkzjEu53tGQMwKHWR+qpfbwLptx8iRA+5D7dmiBEgTCDgQA=;24:WcM+brTL0W1X2Nf8Pw/LoN3zroVC+49Kg3Bvd9aIHITiw3X3bxFT8oii90gkv8JuTmz8lAdNll+Q8eFhiXG2EH3t6xQkzMkz4HmuJHjuw/A=;7:VlldpviixLyfrveYalfVD3iesTvDiWibxTnOfF2NkCJdK2EFAmklOzGefBrAt74bqZRn04iOPGYca6ri6XXOfihkd9otaE2kyDShu/Xo9B8f0jlHM2t4NpuPoO/fOBc6kH2n8VMQRoPAPsJEkQj1YDHRYYSoC42e6GFVvhVAlMbCtKTj2YfRTB54v/2Wq/LBWsmX2Q+8egO/57FJNTNX/s2li93fwBjplvPvfZ15+I6KSO/GOm7pG4UZbGc3fxGS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2820;20:3PvM1gJxL+QVD/KxifY+s+6I8qT0HgglUTl5NJ4cfZxlVPdfvqpW2RQTLUb1MTdRJnRPjcFsZN1CsLSR4dwxPN6kvbbzyAmmfSrR5mlZ35zZfRgENo8YUqAfVS/LaEDXawhnssixACJ6TlZghzzmWqf46p4FqJFUxb1cFAJIdO4= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 12:30:48.2350 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 482189c9-9349-4c4e-23d7-08d55c13ceeb X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2820 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/12/2018 03:24 PM, Michal Hocko wrote: > On Fri 12-01-18 00:59:38, Andrey Ryabinin wrote: >> On 01/11/2018 07:29 PM, Michal Hocko wrote: > [...] >>> I do not think so. Consider that this reclaim races with other >>> reclaimers. Now you are reclaiming a large chunk so you might end up >>> reclaiming more than necessary. SWAP_CLUSTER_MAX would reduce the over >>> reclaim to be negligible. >>> >> >> I did consider this. And I think, I already explained that sort of race in previous email. >> Whether "Task B" is really a task in cgroup or it's actually a bunch of reclaimers, >> doesn't matter. That doesn't change anything. > > I would _really_ prefer two patches here. The first one removing the > hard coded reclaim count. That thing is just dubious at best. If you > _really_ think that the higher reclaim target is meaningfull then make > it a separate patch. I am not conviced but I will not nack it it either. > But it will make our life much easier if my over reclaim concern is > right and we will need to revert it. Conceptually those two changes are > independent anywa. > Ok, fair point. But what about livelock than? Don't you think that we should go back to something like in V1 patch to prevent it? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Ryabinin Subject: Re: [PATCH v4] mm/memcg: try harder to decrease [memory,memsw].limit_in_bytes Date: Mon, 15 Jan 2018 15:30:59 +0300 Message-ID: <7d1b5bfb-f602-8cf4-2de6-dd186484e55c@virtuozzo.com> References: <20180109152622.31ca558acb0cc25a1b14f38c@linux-foundation.org> <20180110124317.28887-1-aryabinin@virtuozzo.com> <20180111104239.GZ1732@dhcp22.suse.cz> <4a8f667d-c2ae-e3df-00fd-edc01afe19e1@virtuozzo.com> <20180111124629.GA1732@dhcp22.suse.cz> <20180111162947.GG1732@dhcp22.suse.cz> <560a77b5-02d7-cbae-35f3-0b20a1c384c2@virtuozzo.com> <20180112122405.GK1732@dhcp22.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oblxiovEdl6j21U+S1apdsciE7vYM21+Z/J8x3IQj1w=; b=WmEYu2Z1jBI6uCqUHzUtZ0zYtLFe2X7e3KlmshTPAqTFG5uYmjrI8tfPctWZoeCNLwaJpSyx0ZhGscxWwwPT9MQ32SkLtEpdxdoqhmwuH9LWlfG1DYS+9PwGrUDe8pVlCnK0dHl0HOQPUNYOS6uNLs5ApGV1eYSw3/vu0Ht3foo= In-Reply-To: <20180112122405.GK1732@dhcp22.suse.cz> Content-Language: en-US Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shakeel Butt On 01/12/2018 03:24 PM, Michal Hocko wrote: > On Fri 12-01-18 00:59:38, Andrey Ryabinin wrote: >> On 01/11/2018 07:29 PM, Michal Hocko wrote: > [...] >>> I do not think so. Consider that this reclaim races with other >>> reclaimers. Now you are reclaiming a large chunk so you might end up >>> reclaiming more than necessary. SWAP_CLUSTER_MAX would reduce the over >>> reclaim to be negligible. >>> >> >> I did consider this. And I think, I already explained that sort of race in previous email. >> Whether "Task B" is really a task in cgroup or it's actually a bunch of reclaimers, >> doesn't matter. That doesn't change anything. > > I would _really_ prefer two patches here. The first one removing the > hard coded reclaim count. That thing is just dubious at best. If you > _really_ think that the higher reclaim target is meaningfull then make > it a separate patch. I am not conviced but I will not nack it it either. > But it will make our life much easier if my over reclaim concern is > right and we will need to revert it. Conceptually those two changes are > independent anywa. > Ok, fair point. But what about livelock than? Don't you think that we should go back to something like in V1 patch to prevent it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org