All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishen Maloor <kishen.maloor@intel.com>
To: Paolo Abeni <pabeni@redhat.com>, <mptcp@lists.linux.dev>
Subject: Re: [PATCH mptcp-next v6 03/14] mptcp: read attributes of addr entries managed by userspace PMs
Date: Wed, 6 Apr 2022 18:58:01 -0700	[thread overview]
Message-ID: <7d2e5716-1507-d7eb-72df-baac56cf71c4@intel.com> (raw)
In-Reply-To: <c71821482e4eefe5a5f6067f38192e95bd834ba8.camel@redhat.com>

On 4/1/22 8:03 AM, Paolo Abeni wrote:
> On Mon, 2022-03-28 at 22:14 -0400, Kishen Maloor wrote:
>> This change introduces a parallel path in the kernel for retrieving
>> the local id, flags, if_index for an addr entry in the context of
>> an MPTCP connection that's being managed by a userspace PM. The
>> userspace and in-kernel PM modes deviate in their procedures for
>> obtaining this information.
> 
> I'm sorry, but I was not able to give feedback earlier. I really think
> it would be better do the 'if (mptcp_pm_is_kernel(msk))' in a thin
> layer, and add the new code into pm_userspace.c
> 
> e.g. this patch has a relatively large diffstat because quite a bit of
> existing code is just re-indented, with the proposed schema that will
> be avoided.

I have moved code from the 2 functions that had explicit in-kernel vs
userspace PM branches into matching functions inside pm_userspace.c.
Hopefully that makes it cleaner.

> 
> Thanks!
> 
> Paolo
> 


  reply	other threads:[~2022-04-07  1:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  2:14 [PATCH mptcp-next v6 00/14] mptcp: APIs and self-tests for userspace path management Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 01/14] mptcp: allow ADD_ADDR reissuance by userspace PMs Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 02/14] mptcp: handle local addrs announced " Kishen Maloor
2022-04-01 14:43   ` Paolo Abeni
2022-04-07  1:57     ` Kishen Maloor
2022-04-01 19:02   ` Mat Martineau
2022-03-29  2:14 ` [PATCH mptcp-next v6 03/14] mptcp: read attributes of addr entries managed " Kishen Maloor
2022-04-01 15:03   ` Paolo Abeni
2022-04-07  1:58     ` Kishen Maloor [this message]
2022-04-01 19:13   ` Mat Martineau
2022-03-29  2:14 ` [PATCH mptcp-next v6 04/14] mptcp: netlink: split mptcp_pm_parse_addr into two functions Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 05/14] mptcp: netlink: Add MPTCP_PM_CMD_ANNOUNCE Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 06/14] selftests: mptcp: support MPTCP_PM_CMD_ANNOUNCE Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 07/14] mptcp: netlink: Add MPTCP_PM_CMD_REMOVE Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 08/14] selftests: mptcp: support MPTCP_PM_CMD_REMOVE Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 09/14] mptcp: netlink: allow userspace-driven subflow establishment Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 10/14] selftests: mptcp: support MPTCP_PM_CMD_SUBFLOW_CREATE Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 11/14] selftests: mptcp: support MPTCP_PM_CMD_SUBFLOW_DESTROY Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 12/14] selftests: mptcp: capture netlink events Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 13/14] selftests: mptcp: create listeners to receive MPJs Kishen Maloor
2022-03-29  2:14 ` [PATCH mptcp-next v6 14/14] selftests: mptcp: functional tests for the userspace PM type Kishen Maloor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d2e5716-1507-d7eb-72df-baac56cf71c4@intel.com \
    --to=kishen.maloor@intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.