From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50105C43387 for ; Wed, 16 Jan 2019 13:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13D6020657 for ; Wed, 16 Jan 2019 13:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="HZTzIaLz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387596AbfAPN7M (ORCPT ); Wed, 16 Jan 2019 08:59:12 -0500 Received: from mail-it1-f195.google.com ([209.85.166.195]:38458 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbfAPN7L (ORCPT ); Wed, 16 Jan 2019 08:59:11 -0500 Received: by mail-it1-f195.google.com with SMTP id h65so2773134ith.3 for ; Wed, 16 Jan 2019 05:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=H4lUz/mmF+oALGcftPoXDOr0SjeiYB+VJKX3NJgOlos=; b=HZTzIaLzirl8ZagNxd6pleeI4Bh9jn8FcTPQB5Evirx8QSMWHVqph7P0o1HMO2+uK+ Q+c17O/3jIPLYJlV5cCzqRSNnw1WYOIkWEUeXDL21X+f7cVwh/6HWD0Hv/FJKXQyp39M o6VPoG2yL8AP2QmTEQjp1QrLvH5PyrRizl3tWk1qWWjaFv9L7NVgRrLEuZwp1DFESN8j vhrF4VpRC5ha+l/NPLzt9aXXOTEQ06IjlsJxkq9+NFtOqpV4MX6UarKa0uqBURwmdXBE Qm76NtYEd1rtJIWDfA5skJ69zt/EpYJyGqf/ccafvvdZBDaNVIpT/kPAjufCNp2FqxCq OvJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=H4lUz/mmF+oALGcftPoXDOr0SjeiYB+VJKX3NJgOlos=; b=n2rEIE3FlnEnhzhKjM1QuPnI+6dyaAjiQqtrrKkoXWzuuAbUHCwFLwFIGbGcthxh89 suBJc8zFH7BPf46TDK3ejP6P0gLGlCfeLQghMNA/OdFg/IrKjB/zlVeh+PJt7BOm2Jf2 SHjvH2xpWPvi9Q2hbnkViJBp3LqdySNmqZMkvWqZekuLc28Dq/fwNi/Wjv7N/wiWPt0r Y7sX24lL8i9EG8PxotUoztfEm2lRFR4CXxCixHd+NDbh8s7zVORuQYIpX9If2IrDAhrC s1rzMH8VfpYENR4Osa8aRx8Wjt9fpGBdwI9nbbbTdS+rRcSrBfkHqoYDj6BPhMJJJkSl hdqA== X-Gm-Message-State: AJcUukdkVZQ7tCPJ5jo5YTo/JCX47nKyrU80rxz5C6+J0TJKERswibyh yBU1F40+8G+X7g8LGA+7aNRTrw== X-Google-Smtp-Source: ALg8bN7b2pIyKXFDpfBOGsDx6oKuWqzlkEsPqtmma+zblOleFUSzPCoeF3BGM/dQ6iBozsJIXyqarg== X-Received: by 2002:a02:7f08:: with SMTP id r8mr5368367jac.20.1547647150687; Wed, 16 Jan 2019 05:59:10 -0800 (PST) Received: from [10.0.0.135] (24-212-162-241.cable.teksavvy.com. [24.212.162.241]) by smtp.googlemail.com with ESMTPSA id u18sm2296571iom.15.2019.01.16.05.59.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 05:59:09 -0800 (PST) Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter To: Cong Wang , netdev@vger.kernel.org Cc: Martin Olsson , Jiri Pirko References: <20190112025542.397-1-xiyou.wangcong@gmail.com> From: Jamal Hadi Salim Message-ID: <7d4c774c-c17d-1739-81f3-bdab67099138@mojatatu.com> Date: Wed, 16 Jan 2019 08:59:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190112025542.397-1-xiyou.wangcong@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019-01-11 9:55 p.m., Cong Wang wrote: > Martin reported a set of filters don't work after changing > from reclassify to continue. Looking into the code, it > looks like skb protocol is not always fetched for each > iteration of the filters. But, as demonstrated by Martin, > TC actions could modify skb->protocol, for example act_vlan, > this means we have to refetch skb protocol in each iteration, > rather than using the one we fetch in the beginning of the loop. > > This bug is _not_ introduced by commit 3b3ae880266d > ("net: sched: consolidate tc_classify{,_compat}"), technically, > if act_vlan is the only action that modifies skb protocol, then > it is commit c7e2b9689ef8 ("sched: introduce vlan action") which > introduced this bug. > > Reported-by: Martin Olsson > Cc: Jamal Hadi Salim > Cc: Jiri Pirko > Signed-off-by: Cong Wang Acked-by: Jamal Hadi Salim cheers, jamal