All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Govindapillai, Vinod" <vinod.govindapillai@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Hogander, Jouni" <jouni.hogander@intel.com>
Subject: Re: [PATCH i-g-t 1/2] tests/intel/kms_fbt: Skip fbcpsr tests on Wa_14016291713
Date: Wed, 27 Mar 2024 12:26:39 +0000	[thread overview]
Message-ID: <7d4e83557e56bea9fc347d3a8b71963d9733eeb9.camel@intel.com> (raw)
In-Reply-To: <20240327054750.159017-1-jouni.hogander@intel.com>

On Wed, 2024-03-27 at 07:47 +0200, Jouni Högander wrote:
> Wa_1401629171 is disabling FBC if PSR is enabled. Check this from FBC
> debugfs interface and skip current test if FBC is disabled due to
> Wa_14016291713.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9525
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  tests/intel/kms_frontbuffer_tracking.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> 
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index db2db0ff1..6d5395a0c 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -2025,6 +2025,14 @@ static bool fbc_mode_too_large(void)
>         return strstr(buf, "FBC disabled: mode too large for compression\n");
>  }
>  
> +static bool fbc_psr_not_possible(void)
> +{
> +       char buf[128];
> +
> +       debugfs_read_crtc("i915_fbc_status", buf);
> +       return strstr(buf, "FBC disabled: PSR1 enabled (Wa_14016291713)");
> +}
> +
>  static bool fbc_enable_per_plane(int plane_index, enum pipe pipe)
>  {
>         char buf[PATH_MAX];
> @@ -2699,6 +2707,7 @@ static void do_status_assertions(int flags)
>                 igt_require(!fbc_not_enough_stolen());
>                 igt_require(!fbc_stride_not_supported());
>                 igt_require(!fbc_mode_too_large());
> +               igt_require(!fbc_psr_not_possible());
>                 if (!intel_fbc_wait_until_enabled(drm.fd, prim_mode_params.pipe)) {
>                         igt_assert_f(intel_fbc_is_enabled(drm.fd,
>                                                     prim_mode_params.pipe,


  parent reply	other threads:[~2024-03-27 12:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  5:47 [PATCH i-g-t 1/2] tests/intel/kms_fbt: Skip fbcpsr tests on Wa_14016291713 Jouni Högander
2024-03-27  5:47 ` [PATCH i-g-t 2/2] tests/intel/kms_fbt: Remove checking display_ver for fpcpsr tests Jouni Högander
2024-03-27 12:27   ` Govindapillai, Vinod
2024-03-27  6:29 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] tests/intel/kms_fbt: Skip fbcpsr tests on Wa_14016291713 Patchwork
2024-03-27  6:39 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-27 12:26 ` Govindapillai, Vinod [this message]
2024-03-28 10:32   ` [PATCH i-g-t 1/2] " Hogander, Jouni
2024-03-28  1:52 ` ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
2024-03-28 10:23   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d4e83557e56bea9fc347d3a8b71963d9733eeb9.camel@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.