From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B728AC433DB for ; Mon, 25 Jan 2021 21:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8638820708 for ; Mon, 25 Jan 2021 21:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732046AbhAYVKV (ORCPT ); Mon, 25 Jan 2021 16:10:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732238AbhAYVJu (ORCPT ); Mon, 25 Jan 2021 16:09:50 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D772C061574; Mon, 25 Jan 2021 13:09:09 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id a8so19858028lfi.8; Mon, 25 Jan 2021 13:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ljX94ob0gxc7TBbMW/hwvorCyQ7d78+9C5d6nUuJY4A=; b=l8FsEZ8ZKnJFAhD5sfNBKDjgb3XtTjtjRwwpmqVRkHvuw0hQec5jUHcmTJPIU3fJ3+ euItLtjg7gKpCV1pjAgOqUWu+FIW9C5mjVBC6XHOAHGgSeGwC2FWgOGiVViyylakaQ5h bA9u4oeJSbto5gU3zaYoAouYI2RN+bJiF/zw1D0m61jNLdGVDvmRJhrWGMKXw1WWfMYH +FWeWiEWI2IJ/qgkE6d+sivsZXixsW853jfsLJWvzCgLnPJSZsx97ng3dPpMMM9gpoCo KolGhANnSL4SOZ6WL7chOYSgt1DTI7SrWcOFVbyjvVgaGZSKkYBCvKAkgRNxzX0ImNPS HQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ljX94ob0gxc7TBbMW/hwvorCyQ7d78+9C5d6nUuJY4A=; b=J2eEZpAVznhRdXqWdF0gdZhJRv1ykIZdyCfci2H4k0I/RqkYqBvRtc29Koltevz5yn afHE3iiSpSDIqVYkw0qVZFMQ/Xt2ThXnYaDh/DlJ0WP+MQ5d2I0aMSd0sNRvnCaKqniI XMIzT+xuwB8mRHQzK/Xn5soUakFZYPGBXzZXCH6IrPZAhN6UeriYSeawUZQKQfEcPxj0 aEUyIkDhmMpFlOx+GB7zEY7eb7Dws0Tpl2vMbcQxf+MA4D1OHWJrzo8T7f3TK7sd7D91 UumedGxpB1/NS4dKLCf9+8M1/zzuXBmalK/0b5wMTazshEnDJWAnthTI8+l1i2hA2jqE 1GAQ== X-Gm-Message-State: AOAM531TwdRlP8LMhL5IZOJl8xNcHqOBfnD2VUmlT+MavCX/0yqY0ugR uYfNji+C3alkuu2XkUqGCzOScTHsru8= X-Google-Smtp-Source: ABdhPJxNbMSVPgHPo/hTwLSVl2t3E08eBL30MfC6cO0G1scw3qtVdUFtPz51LYvi84N+/v7VL0sTcg== X-Received: by 2002:a19:58a:: with SMTP id 132mr1091790lff.355.1611608947678; Mon, 25 Jan 2021 13:09:07 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id q13sm1069781lfk.307.2021.01.25.13.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 13:09:06 -0800 (PST) Subject: Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices To: Viresh Kumar Cc: Viresh Kumar , Nishanth Menon , Stephen Boyd , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-tegra@vger.kernel.org" References: <1585f6c21ea8aee64fe4da0bf72b36ea4d74a779.1611227342.git.viresh.kumar@linaro.org> <9b2638e6-b842-8737-e5a0-aeeb84927fce@gmail.com> <20210122043506.lm6yiefzlyubq5my@vireshk-i7> From: Dmitry Osipenko Message-ID: <7d6573e3-7885-fb0b-2290-c181e2c557f9@gmail.com> Date: Tue, 26 Jan 2021 00:09:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210122043506.lm6yiefzlyubq5my@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 22.01.2021 07:35, Viresh Kumar пишет: > On 21-01-21, 23:26, Dmitry Osipenko wrote: >> 21.01.2021 14:17, Viresh Kumar пишет: >>> In order to avoid conditional statements at the caller site, this patch >>> updates _generic_set_opp_clk_only() to work for devices that don't >>> change frequency (like power domains, etc.). Return 0 if the clk pointer >>> passed to this routine is not valid. >>> >>> Signed-off-by: Viresh Kumar >>> --- >> ... >> >> Hello Viresh, >> >> Thank you very much for yours effort! I gave a quick test to this series >> and instantly found one small issue in this patch. >> >>> + /* We may reach here for devices which don't change frequency */ >>> + if (unlikely(!clk)) >> >> I replaced dev_pm_opp_set_voltage() with dev_pm_opp_set_opp() in the >> Tegra PD driver and got a crash, which happens because the above line >> should be: >> >> if (IS_ERR(clk)) > > Fixed, thanks. > Please remove unlikely() around IS_ERR(), it already has the unlikely(). https://elixir.bootlin.com/linux/v5.11-rc4/source/include/linux/err.h#L22 I'd also recommend to remove all the unlikely() from OPP code since it doesn't bring any value if not used in a very performance-critical code path. OPP core doesn't have such code paths. The [un]likely() only make code less readable and may result in a worse assembly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71319C433E6 for ; Mon, 25 Jan 2021 21:10:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A9F1207B6 for ; Mon, 25 Jan 2021 21:10:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A9F1207B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2RlvtBRCUprtO2ka41vpoPT8ebx4HA8BQcertoaUrKo=; b=WJ/w9NSs9K5ZUqizGLlEq8bkL Fyo2UQo92Ck1PDcdWh9A2Be4AlC788FZ+u3S+DXUJf9cu5pZXGzhWzWL3LI/dsSAzlzmTupE66YKH gVUrKv33+l+LlSmsb+JL/Zyn2RmmfnMpzMu42XlX1CChCXO8NBK4K/jTGsM/6ytmnFwedcwwQ+sV/ UzDME6omTLQ0p4vxkoigGlXpT9xX2niDqVX9MlN/GF7sTFKPu9UYrJMr7aRh5GmN1dqGTrP+k/Enq MmSnuy8O5LGkSwJmSfVJS6D+L17l7Pb6pA5Zs2g+5/4Sf+eayVT/MLBC6Ve6rY3fsZC6A/tdyCuDS QolF1tMWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l496n-0007jA-7V; Mon, 25 Jan 2021 21:09:13 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l496j-0007iF-I6 for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 21:09:11 +0000 Received: by mail-lf1-x135.google.com with SMTP id m22so19862139lfg.5 for ; Mon, 25 Jan 2021 13:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ljX94ob0gxc7TBbMW/hwvorCyQ7d78+9C5d6nUuJY4A=; b=l8FsEZ8ZKnJFAhD5sfNBKDjgb3XtTjtjRwwpmqVRkHvuw0hQec5jUHcmTJPIU3fJ3+ euItLtjg7gKpCV1pjAgOqUWu+FIW9C5mjVBC6XHOAHGgSeGwC2FWgOGiVViyylakaQ5h bA9u4oeJSbto5gU3zaYoAouYI2RN+bJiF/zw1D0m61jNLdGVDvmRJhrWGMKXw1WWfMYH +FWeWiEWI2IJ/qgkE6d+sivsZXixsW853jfsLJWvzCgLnPJSZsx97ng3dPpMMM9gpoCo KolGhANnSL4SOZ6WL7chOYSgt1DTI7SrWcOFVbyjvVgaGZSKkYBCvKAkgRNxzX0ImNPS HQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ljX94ob0gxc7TBbMW/hwvorCyQ7d78+9C5d6nUuJY4A=; b=A06Oaqr5R/EPPYdVCCCDA3zk/8eqE7OaHwYWZIoy6K7/A57oQXsDkMqUpA0POPn4k2 8rajdihkhl3UlSO0y2zQeKyYu5ca0IlrtMCNQp7xKhvIYx7eZmuoTzjh9uiMhwquiyPU HJJanVrigGzeWa0EKhw14NyybzCqBZiA7r7Krw9QEgaMv3xmnODI+TLC6kWeRwM+zSrZ jy7NBlas4Y+iMS5glM3bFMyu+3NBi6V5flPg0ef9lEPYROfl/ySzL+v48dG/2N9/I8Z7 fp0HvULnGf30s5lR6TVxqlIZ/chKU8ag/snihGHn21DKy8JhUs8P/7L61h40z7X/udJm SRrA== X-Gm-Message-State: AOAM5305KnU8wqrGsaKwVBbSfVaPZtPMgttXPPrPlO7DAUUIh7eHNZBc twuO4+CWWTBqqWhA1GuwTu4= X-Google-Smtp-Source: ABdhPJxNbMSVPgHPo/hTwLSVl2t3E08eBL30MfC6cO0G1scw3qtVdUFtPz51LYvi84N+/v7VL0sTcg== X-Received: by 2002:a19:58a:: with SMTP id 132mr1091790lff.355.1611608947678; Mon, 25 Jan 2021 13:09:07 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id q13sm1069781lfk.307.2021.01.25.13.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 13:09:06 -0800 (PST) Subject: Re: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices To: Viresh Kumar References: <1585f6c21ea8aee64fe4da0bf72b36ea4d74a779.1611227342.git.viresh.kumar@linaro.org> <9b2638e6-b842-8737-e5a0-aeeb84927fce@gmail.com> <20210122043506.lm6yiefzlyubq5my@vireshk-i7> From: Dmitry Osipenko Message-ID: <7d6573e3-7885-fb0b-2290-c181e2c557f9@gmail.com> Date: Tue, 26 Jan 2021 00:09:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210122043506.lm6yiefzlyubq5my@vireshk-i7> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_160910_423990_C2A923FC X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Viresh Kumar , Rafael Wysocki , linux-kernel@vger.kernel.org, Sibi Sankar , "linux-tegra@vger.kernel.org" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjIuMDEuMjAyMSAwNzozNSwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjEtMDEtMjEs IDIzOjI2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IDIxLjAxLjIwMjEgMTQ6MTcsIFZpcmVz aCBLdW1hciDQv9C40YjQtdGCOgo+Pj4gSW4gb3JkZXIgdG8gYXZvaWQgY29uZGl0aW9uYWwgc3Rh dGVtZW50cyBhdCB0aGUgY2FsbGVyIHNpdGUsIHRoaXMgcGF0Y2gKPj4+IHVwZGF0ZXMgX2dlbmVy aWNfc2V0X29wcF9jbGtfb25seSgpIHRvIHdvcmsgZm9yIGRldmljZXMgdGhhdCBkb24ndAo+Pj4g Y2hhbmdlIGZyZXF1ZW5jeSAobGlrZSBwb3dlciBkb21haW5zLCBldGMuKS4gUmV0dXJuIDAgaWYg dGhlIGNsayBwb2ludGVyCj4+PiBwYXNzZWQgdG8gdGhpcyByb3V0aW5lIGlzIG5vdCB2YWxpZC4K Pj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBWaXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1hckBsaW5hcm8u b3JnPgo+Pj4gLS0tCj4+IC4uLgo+Pgo+PiBIZWxsbyBWaXJlc2gsCj4+Cj4+IFRoYW5rIHlvdSB2 ZXJ5IG11Y2ggZm9yIHlvdXJzIGVmZm9ydCEgSSBnYXZlIGEgcXVpY2sgdGVzdCB0byB0aGlzIHNl cmllcwo+PiBhbmQgaW5zdGFudGx5IGZvdW5kIG9uZSBzbWFsbCBpc3N1ZSBpbiB0aGlzIHBhdGNo Lgo+Pgo+Pj4gKwkvKiBXZSBtYXkgcmVhY2ggaGVyZSBmb3IgZGV2aWNlcyB3aGljaCBkb24ndCBj aGFuZ2UgZnJlcXVlbmN5ICovCj4+PiArCWlmICh1bmxpa2VseSghY2xrKSkKPj4KPj4gSSByZXBs YWNlZCBkZXZfcG1fb3BwX3NldF92b2x0YWdlKCkgd2l0aCBkZXZfcG1fb3BwX3NldF9vcHAoKSBp biB0aGUKPj4gVGVncmEgUEQgZHJpdmVyIGFuZCBnb3QgYSBjcmFzaCwgd2hpY2ggaGFwcGVucyBi ZWNhdXNlIHRoZSBhYm92ZSBsaW5lCj4+IHNob3VsZCBiZToKPj4KPj4gCWlmIChJU19FUlIoY2xr KSkKPiAKPiBGaXhlZCwgdGhhbmtzLgo+IAoKUGxlYXNlIHJlbW92ZSB1bmxpa2VseSgpIGFyb3Vu ZCBJU19FUlIoKSwgaXQgYWxyZWFkeSBoYXMgdGhlIHVubGlrZWx5KCkuCgpodHRwczovL2VsaXhp ci5ib290bGluLmNvbS9saW51eC92NS4xMS1yYzQvc291cmNlL2luY2x1ZGUvbGludXgvZXJyLmgj TDIyCgpJJ2QgYWxzbyByZWNvbW1lbmQgdG8gcmVtb3ZlIGFsbCB0aGUgdW5saWtlbHkoKSBmcm9t IE9QUCBjb2RlIHNpbmNlIGl0CmRvZXNuJ3QgYnJpbmcgYW55IHZhbHVlIGlmIG5vdCB1c2VkIGlu IGEgdmVyeSBwZXJmb3JtYW5jZS1jcml0aWNhbCBjb2RlCnBhdGguIE9QUCBjb3JlIGRvZXNuJ3Qg aGF2ZSBzdWNoIGNvZGUgcGF0aHMuIFRoZSBbdW5dbGlrZWx5KCkgb25seSBtYWtlCmNvZGUgbGVz cyByZWFkYWJsZSBhbmQgbWF5IHJlc3VsdCBpbiBhIHdvcnNlIGFzc2VtYmx5LgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=