From: Neil Armstrong <narmstrong@baylibre.com>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags
Date: Wed, 16 Jun 2021 11:13:26 +0200 [thread overview]
Message-ID: <7d7a6260-78b8-3b84-ab66-1fc9a5cdea86@baylibre.com> (raw)
In-Reply-To: <75faf1744b7857508fa21578e21208216561e82b.1623725300.git.xji@analogixsemi.com>
Hi,
On 16/06/2021 09:48, Xin Ji wrote:
> Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0,
> lane1 swing register array define, and audio enable flag.
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> .../display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++-
> 1 file changed, 56 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index ab48ab2f4240..9e604d19a3d5 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -43,6 +43,26 @@ properties:
> vdd33-supply:
> description: Regulator that provides the supply 3.3V power.
>
> + analogix,lane0-swing:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 20
> + description:
> + an array of swing register setting for DP tx lane0 PHY, please don't
> + add this property, or contact vendor.
> +
> + analogix,lane1-swing:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 20
> + description:
> + an array of swing register setting for DP tx lane1 PHY, please don't
> + add this property, or contact vendor.
> +
> + analogix,audio-enable:
> + type: boolean
> + description: let the driver enable audio HDMI codec function or not.
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -50,13 +70,43 @@ properties:
> port@0:
> $ref: /schemas/graph.yaml#/properties/port
> description:
> - Video port for MIPI DSI input.
> + MIPI DSI/DPI input.
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + type: object
> + additionalProperties: false
> +
> + properties:
> + remote-endpoint: true
> + bus-type: true
> + data-lanes: true
> +
> + required:
> + - remote-endpoint
> +
> + required:
> + - endpoint
> +
>
> port@1:
> $ref: /schemas/graph.yaml#/properties/port
> description:
> Video port for panel or connector.
>
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + type: object
> + additionalProperties: false
> +
> + properties:
> + remote-endpoint: true
> +
> + required:
> + - remote-endpoint
> +
> required:
> - port@0
> - port@1
> @@ -87,6 +137,9 @@ examples:
> vdd10-supply = <&pp1000_mipibrdg>;
> vdd18-supply = <&pp1800_mipibrdg>;
> vdd33-supply = <&pp3300_mipibrdg>;
> + analogix,audio-enable;
> + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
>
> ports {
> #address-cells = <1>;
> @@ -96,6 +149,8 @@ examples:
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
>
Please split the patch in 3 between:
- analogix DP tx lane0 lane1 swing register array define
- audio enable flag
- port properties
Neil
next prev parent reply other threads:[~2021-06-16 9:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 7:47 [PATCH v8 0/4] Add MIPI rx DPI support Xin Ji
2021-06-16 7:47 ` Xin Ji
2021-06-16 7:47 ` Xin Ji
2021-06-16 7:48 ` [PATCH v8 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags Xin Ji
2021-06-16 7:48 ` Xin Ji
2021-06-16 9:13 ` Neil Armstrong [this message]
2021-06-16 7:50 ` [PATCH v8 2/4] drm/bridge: anx7625: fix not correct return value Xin Ji
2021-06-16 7:50 ` Xin Ji
2021-06-16 7:50 ` Xin Ji
2021-06-16 7:50 ` [PATCH v8 3/4] drm/bridge: anx7625: add MIPI DPI input feature Xin Ji
2021-06-16 7:50 ` Xin Ji
2021-06-16 7:50 ` Xin Ji
2021-06-16 9:16 ` Neil Armstrong
2021-06-16 9:16 ` Neil Armstrong
2021-06-16 9:16 ` Neil Armstrong
2021-06-22 8:20 ` Xin Ji
2021-06-22 8:20 ` Xin Ji
2021-06-22 8:20 ` Xin Ji
2021-06-16 7:51 ` [PATCH v8 4/4] drm/bridge: anx7625: add HDMI audio function Xin Ji
2021-06-16 7:51 ` Xin Ji
2021-06-16 7:51 ` Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d7a6260-78b8-3b84-ab66-1fc9a5cdea86@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.