From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D62EEB64D9 for ; Fri, 7 Jul 2023 08:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231779AbjGGIWT (ORCPT ); Fri, 7 Jul 2023 04:22:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232940AbjGGIWO (ORCPT ); Fri, 7 Jul 2023 04:22:14 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 344EE210B; Fri, 7 Jul 2023 01:22:09 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4AB9C6606FCA; Fri, 7 Jul 2023 09:22:07 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688718128; bh=KlqmsemJjqgs8TN2Gg23NtEfSBp5PE0Ob4EPcUQRJuw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dTdK+JOhlS1RgWLnLTo3YBkJSNT581LvyIa23ZL6eicmvkcLaVeZ2g9u18dMNXOtW Tkg1Aq4nQlff4bBZ1dqbJGm9dWMsjhuQwVWbcWHECFBoh1cTZuPbwzJEvY78QPckSL 7eka9gMKpUNEg71Ki37FrhwC9A4KGP43lfwQmmpa0tuqv+po5EARjMa5kUpl4EFDgk k0MsmvVaVgxDATr5bRtjL2v37taVHc/z/Qkc00kmGPoqxe4mnx1WiKXKqOVjZGG1yv nFLJEiPw9v261ho8uS3+/h33OHfo7A+TllTaehD8q7Qw7HQrWOYWx/0uJIS5sM8nZ3 bKyqCZpet8aPQ== Message-ID: <7d7db84b-e6be-2d45-fbc6-e891718b757a@collabora.com> Date: Fri, 7 Jul 2023 10:22:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 5/6] thermal/drivers/mediatek/lvts_thermal: Don't leave threshold zeroed Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , Chen-Yu Tsai , Alexandre Mergnat , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-6-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230706153823.201943-6-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 06/07/23 17:37, Nícolas F. R. A. Prado ha scritto: > The thermal framework might leave the low threshold unset if there > aren't any lower trip points. This leaves the register zeroed, which > translates to a very high temperature for the low threshold. The > interrupt for this threshold is then immediately triggered, and the > state machine gets stuck, preventing any other temperature monitoring > interrupts to ever trigger. > > (The same happens by not setting the Cold or Hot to Normal thresholds > when using those) > > Set the unused threshold to a valid low value. This value was chosen so > that for any valid golden temperature read from the efuse, when the > value is converted to raw and back again to milliCelsius, the result > doesn't underflow. > > Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver") > Signed-off-by: Nícolas F. R. A. Prado > Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3E65EB64D9 for ; Fri, 7 Jul 2023 08:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X20Qfr6taODbv4j1qP4uiIJjDZDKbG7tnx0Sm2Grx1M=; b=U1FVVdVQjHnJ1A 4df0oJQMW7DB8NVOLWPsf0QlbuVDNZVDUIWuxaE1KnqDiddXKloZzFEKqz5Fal7llDUmKJiI90vdw 8lYm13L0bTQVNeJZfIE//Nq3JMXqCkt+DzCXGp8sUVPbqtG7BY1Z/T6wKLSHpQk539PbxVXhZoXLC T0YIfQBI9bgeFqAKejWu3yW0D/O7EHNXaRLRXnDt7QIEvZ7paQswAR86YgdY+XV1uqD1ISueunQ+z J5xCMoXx81mr3B3u2J0d+SJG8ipnN1v8+yjgmmGddHPr9inem0jF3KaNQUVrpY8wEFaeC1bjOEXxl H0I1T5jQA6kFSvwD4VuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHgjD-003yjh-1S; Fri, 07 Jul 2023 08:22:11 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHgjB-003yiH-0m; Fri, 07 Jul 2023 08:22:10 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4AB9C6606FCA; Fri, 7 Jul 2023 09:22:07 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688718128; bh=KlqmsemJjqgs8TN2Gg23NtEfSBp5PE0Ob4EPcUQRJuw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dTdK+JOhlS1RgWLnLTo3YBkJSNT581LvyIa23ZL6eicmvkcLaVeZ2g9u18dMNXOtW Tkg1Aq4nQlff4bBZ1dqbJGm9dWMsjhuQwVWbcWHECFBoh1cTZuPbwzJEvY78QPckSL 7eka9gMKpUNEg71Ki37FrhwC9A4KGP43lfwQmmpa0tuqv+po5EARjMa5kUpl4EFDgk k0MsmvVaVgxDATr5bRtjL2v37taVHc/z/Qkc00kmGPoqxe4mnx1WiKXKqOVjZGG1yv nFLJEiPw9v261ho8uS3+/h33OHfo7A+TllTaehD8q7Qw7HQrWOYWx/0uJIS5sM8nZ3 bKyqCZpet8aPQ== Message-ID: <7d7db84b-e6be-2d45-fbc6-e891718b757a@collabora.com> Date: Fri, 7 Jul 2023 10:22:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 5/6] thermal/drivers/mediatek/lvts_thermal: Don't leave threshold zeroed Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , Chen-Yu Tsai , Alexandre Mergnat , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-6-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230706153823.201943-6-nfraprado@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_012209_410780_26AE6102 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMDYvMDcvMjMgMTc6MzcsIE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIGhhIHNjcml0dG86Cj4g VGhlIHRoZXJtYWwgZnJhbWV3b3JrIG1pZ2h0IGxlYXZlIHRoZSBsb3cgdGhyZXNob2xkIHVuc2V0 IGlmIHRoZXJlCj4gYXJlbid0IGFueSBsb3dlciB0cmlwIHBvaW50cy4gVGhpcyBsZWF2ZXMgdGhl IHJlZ2lzdGVyIHplcm9lZCwgd2hpY2gKPiB0cmFuc2xhdGVzIHRvIGEgdmVyeSBoaWdoIHRlbXBl cmF0dXJlIGZvciB0aGUgbG93IHRocmVzaG9sZC4gVGhlCj4gaW50ZXJydXB0IGZvciB0aGlzIHRo cmVzaG9sZCBpcyB0aGVuIGltbWVkaWF0ZWx5IHRyaWdnZXJlZCwgYW5kIHRoZQo+IHN0YXRlIG1h Y2hpbmUgZ2V0cyBzdHVjaywgcHJldmVudGluZyBhbnkgb3RoZXIgdGVtcGVyYXR1cmUgbW9uaXRv cmluZwo+IGludGVycnVwdHMgdG8gZXZlciB0cmlnZ2VyLgo+IAo+IChUaGUgc2FtZSBoYXBwZW5z IGJ5IG5vdCBzZXR0aW5nIHRoZSBDb2xkIG9yIEhvdCB0byBOb3JtYWwgdGhyZXNob2xkcwo+IHdo ZW4gdXNpbmcgdGhvc2UpCj4gCj4gU2V0IHRoZSB1bnVzZWQgdGhyZXNob2xkIHRvIGEgdmFsaWQg bG93IHZhbHVlLiBUaGlzIHZhbHVlIHdhcyBjaG9zZW4gc28KPiB0aGF0IGZvciBhbnkgdmFsaWQg Z29sZGVuIHRlbXBlcmF0dXJlIHJlYWQgZnJvbSB0aGUgZWZ1c2UsIHdoZW4gdGhlCj4gdmFsdWUg aXMgY29udmVydGVkIHRvIHJhdyBhbmQgYmFjayBhZ2FpbiB0byBtaWxsaUNlbHNpdXMsIHRoZSBy ZXN1bHQKPiBkb2Vzbid0IHVuZGVyZmxvdy4KPiAKPiBGaXhlczogZjVmNjMzYjE4MjM0ICgidGhl cm1hbC9kcml2ZXJzL21lZGlhdGVrOiBBZGQgdGhlIExvdyBWb2x0YWdlIFRoZXJtYWwgU2Vuc29y IGRyaXZlciIpCj4gU2lnbmVkLW9mZi1ieTogTsOtY29sYXMgRi4gUi4gQS4gUHJhZG8gPG5mcmFw cmFkb0Bjb2xsYWJvcmEuY29tPgo+IAoKUmV2aWV3ZWQtYnk6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVs IFJlZ25vIDxhbmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+CgoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK