From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19DE4C433EF for ; Fri, 20 May 2022 16:00:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 29E9383EB7; Fri, 20 May 2022 18:00:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="ZWnmlkL7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5603183E1B; Fri, 20 May 2022 18:00:50 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20606.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::606]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38B8083F35 for ; Fri, 20 May 2022 18:00:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=horia.geanta@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=THYrG23RGo+LHNA5i+R8hdt796BtcwjnOCBsYVPTfF6flafx7Z7L1AtqX1G3kwbVhe8uYBiydiAnzEx8HNR3ws6QaQ82qMKyKUlpWYfFfrbPFubJO4jxHTm6m8nVTn2eSYgp6xsl0z2ZpgenEZ8hd8T1eLUyHf9/gPEIpK7P9rte7/c6p/BSmF1u9Z65lpynYmJHQoP36183ceJwwMS1MNsWW3YDl9IseTphuM/R8etyHP/hIiZh21ffkx3hagvX7o/VACktQPwUTQ+H7xm4ILlN3mjeXG7EdEERY74+Uqd5vtOWo5ajmIIgUCdtZm4YJypOfy/6NKvLglG2qcG+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SC2q44y+wn7FMJC4Jzh8siuMaUlfEwj2ofAJhjGSneI=; b=TnUotP1yZTajelxAByc2ev9hw74g4SdaiAvXn/rDMXL1/1p3ixvFpTM/Q+0xp8B5UFoChVyc1Pax+ZueMk0OdtpJl1RZuTbnjLfxPhNvHT+F5IFfhO87YZnqi4oyqyfF8spacZd+XOnTr7UzxxFirZOrPoVylr41EyrRWjTigsWHs1u1aaDMDP8HZWub5rO2PsB7LglHsy4T+SElVyP8RTxpU58JXD8g+V3cWaESi9sTICehnwZCsXypllTILJaPcrYKefZXtV6AIVnxq/w7YzGrr0vFiCcxoulxhTgm+aRlpb1tGpEmTdOlWuhhJZ51ynmnz9b6JIpV7NVovW0hAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SC2q44y+wn7FMJC4Jzh8siuMaUlfEwj2ofAJhjGSneI=; b=ZWnmlkL7/UW1C3HMFZjJp4NpZ+fB2s8eO4YW22kfp6fj681P/oAekFUVOcI9LgLMnsXwbmSBMrL1pqhvD1U3dvcmKUfM+K6fa2JPlIIgLRqo8l4dr5jnIgU56GgIFVuVISfHSvM/2USrysYYIpm6Hm4Z3Po5G8dohPC+VmxhFmo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from GV1PR04MB9514.eurprd04.prod.outlook.com (2603:10a6:150:20::17) by AM9PR04MB8698.eurprd04.prod.outlook.com (2603:10a6:20b:43d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 16:00:44 +0000 Received: from GV1PR04MB9514.eurprd04.prod.outlook.com ([fe80::974:442b:8b4e:d69e]) by GV1PR04MB9514.eurprd04.prod.outlook.com ([fe80::974:442b:8b4e:d69e%6]) with mapi id 15.20.5164.025; Fri, 20 May 2022 16:00:44 +0000 Message-ID: <7d830168-bb2d-2a29-2753-b66e3ea5f5af@nxp.com> Date: Fri, 20 May 2022 19:00:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] crypto/fsl: fsl_hash: Fix dcache issue in caam_hash_finish Content-Language: en-US To: Rasmus Villemoes , Gaurav Jain , Stefano Babic , "u-boot@lists.denx.de" Cc: Fabio Estevam , Priyanka Jain , Ye Li , Silvano Di Ninno , Varun Sethi , Peng Fan , dl-uboot-imx References: <20220511085319.1941861-1-gaurav.jain@nxp.com> <39de1330-a36e-bad9-1b15-d4b43925870f@prevas.dk> From: =?UTF-8?Q?Horia_Geant=c4=83?= In-Reply-To: <39de1330-a36e-bad9-1b15-d4b43925870f@prevas.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR10CA0064.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::17) To GV1PR04MB9514.eurprd04.prod.outlook.com (2603:10a6:150:20::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a92a8144-5555-437e-2eed-08da3a79e577 X-MS-TrafficTypeDiagnostic: AM9PR04MB8698:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nAulRa5WJclJ+ShUW8b3OGf4G0AIn4ONQZlJSR9TeXozOvM9sQ1dp/FWrxSQQUE8xR2rFZVqdImTlaVaeho7I1vobcbpPasWgKL8ZMHHYn36qL8/w2BhmxqiYRLNqGbsDWbIbhCKwaIZPpYnpaWlkk5Sj4wJ2AGYPITaut0cfT3A7na9ZsePE+eK8FkJK7Ki8TsynM/2gGZBaiuE3SqqQ7cPqLC4qslm6pjStVoccp6mRop3RtKemyqclCuQWXyqb6S9QEaI5QHPbAKRDhiAYShNJU4ozJMnaCwv/H898uynAFHKWEUxggYxlXlVkoVKJNvH+fDAThRb673+Gqk/USZD1vz0vbWlNb/7cgMPh6wTMlS1JoKAvkjd9KmM7ouRmWnsJsS3vJ5/DdN7yXaERSUlGV1bBlNXlmI1V+hStjawV3wT039/hBUV4hIsv55mkFl0zGduU6FV7PqGM2mTlppng+re+1kksN30HrqbvHN+mQlYzUYbes6YajixEySnHPRu9G9AofErz18DKKoW37U7uUQCGCs8hSR46+LhNHPCmPZ4dCUUA7ekKMuQMtRbxPpQAjlHKMJLqUbkaWu0Ojb9wYefAgL9hQIcZLBVoR+Nk6gUUSu7kuexJ/l5uw9K1gwGdbr4UenfDhDZn3kGctA1VM3A1vBZ58HgCe1T/3Lp0hmzTz/cCYWz80PKkqRIFm1LbNiRGM9LBFlsYX/oX3NyLLNdHBV3w5cG8ojGl+pQeuxFXBAMdQTXmp+kHHQfD9rKEsFsgs81RGFQX77GVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV1PR04MB9514.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(83380400001)(6486002)(36756003)(2616005)(8936002)(31686004)(508600001)(186003)(6666004)(38350700002)(2906002)(53546011)(316002)(6506007)(31696002)(4326008)(66946007)(66556008)(38100700002)(86362001)(6512007)(55236004)(52116002)(5660300002)(26005)(8676002)(66476007)(110136005)(54906003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alNDNDVEeXk5VVFRdFBIUXhMNmJYbS93cWdvNEJVVW5aL2dLaG9LL2pXeDBq?= =?utf-8?B?WSsveE8vNmJvdVA2MEp4TVpYNjJYbndDRGpONW5KVVlqbERmREgzYmd4VDF0?= =?utf-8?B?YzNjM0p3YXZwSFBPL0lSSHFGQllkSERvcTFkcjVnRU4xeVB5THAyNHMwcVdn?= =?utf-8?B?azNWY0h1K0xHdWFtR0NXbG1aL0NXaS91Y0lvZEozeGorNjJobTdsbTBjdzU5?= =?utf-8?B?RHRoZUhkTjFpSEhpanJVaklMMUpTRDFoZEdJdDhadzYxSCthMEpCS0NRZi9K?= =?utf-8?B?RFJCSGcvVlk2aEtaMEFGUm9xN0VHczVEU0NQaGFuU3pkVi9kMGd4dkZnY2c2?= =?utf-8?B?dkM1WDVjbzd0dERESDNZbWdsTldMZi9tMlF0eWFZNFNoMnZRZ0RSdURrTHFQ?= =?utf-8?B?NlNuZDJzTXo0K3c4N1VpUmhwK3lTSjBTQzZ3RDZsazdoTlBNTWRUYit5anpS?= =?utf-8?B?WlhBKzV1dnNmeXBEbHBidC9kV2c5c1h4WkpqYmUyR2J1S2FsaTFlT1k4Wm01?= =?utf-8?B?UW53bVcwMkQwNDcxVE9pbG5qUWlvNVpRa25menEyd2pXV1E2bVptR1d3N1hJ?= =?utf-8?B?NzZRU3VUd0hxdDJLc2U3WjNCZzZhd1lOUHBtcUFFbzRaSEw5MDgzRTY5Rzd4?= =?utf-8?B?bU9QWlRyWWVrQ3kyK04xQXB3NGY1OExWVEphSzhaUUg5aXdUTUNXR2V0ekNZ?= =?utf-8?B?cTJsN0haMDhWc1MzWnpkOU5jVmhIOU5SZlpIT3hDQlJLMjRLTS9RTnREcW9y?= =?utf-8?B?QUJ0SmdlWjVXS0VuTlhpOFhKZ1R4WHovVG9yYnlXQnpRWWZOMmV4UjZRZC9L?= =?utf-8?B?MGRwd003amRPR2k5VHVyZzgxc0NoTjJ4UXZYNFZzaHBJczY3bzJ1Zkl6NnRi?= =?utf-8?B?RzZ5cTUwMXRXdmppTGdvNDBRS1M3VWN6Mm9DMzRRNjhGS3J5bWZUbERDd1B4?= =?utf-8?B?U0NZS3dwRTlIRXMyaU5FTXIrTmVEUG9scGVFWm9FV0NuenU2TXZQRXoxeWlF?= =?utf-8?B?Ukt2TE1nMnRaM3FmbkZWL2JXdWxSQlIwT3R5NFNZMm91K3lvUVdsZlhwSzdh?= =?utf-8?B?d3JwUWdkdVVOaWFQNjZqVXAySU1FTGZaaCt1QUp2Z0RMT0RPMVpQdVRFYXB6?= =?utf-8?B?WWJjemJESlprOFNWVkJjVGdpYjZpeDNWZThqeExqQ3JCSGRYalA2aWdpWW55?= =?utf-8?B?bzQ1dHg3SUpaWGNZclJUMlo1UURFYjI0emdyZzBySnpIYWNBa240YWttd0d5?= =?utf-8?B?OW9xcUE3bkJHdkZzd29BcXZCeTRCUEcvR2cxZFBKdE9vM2YrRktJbzhvQSt4?= =?utf-8?B?Y05qUU9DTFd6WDZ5UXlBSzZRUi9oRGkxRXdubU0yeUdaV3dJZGxkMWJVSVJv?= =?utf-8?B?WVhZNnRGQlhVRGlvNTZOWXdEVzRoSU9SM2FoSmUwV3pQc3hSbkQ2SEVUd2xK?= =?utf-8?B?YUp1OFdCYlNqUDhFbHQ5eWczV1dEbmRZRWxTMzN0bDVjQWY2dzFPZlFNcDRZ?= =?utf-8?B?ZENQUExwb2FlQmoza1VMZW1EZ2lyMTJWdmQxWDN6NExHNVBiNW5NbTFPeGlh?= =?utf-8?B?MWE2UFE0azZxSStBQnlFNGJ4Q0g4UHNheGk2TWxnKzQ1WkF4SjVmaUlTTFI0?= =?utf-8?B?THVtSDNwQk1MdUhwcVdXNUoxejlHSDFJK1kxdXEyTmxmRDk5V2oxWFRUZ1ZW?= =?utf-8?B?VnNaYmU1dGFrcnZ6cGdtc1RFMDFyVTB1dndGSFpTME9HMlFpa2I0RFFxY0dx?= =?utf-8?B?anZOUnJUNms3L3BRd1czK3Nyd3Yyc0lwcFVCVE41azVLRlQwRkE1VUNJdmVz?= =?utf-8?B?anpQRm5JYWtrN0RLb3BiTlV6elllSWFPMko2dVRuYjJ2dXNmZUkyTFBWL2F5?= =?utf-8?B?VmEyaFhGeGF6YjhUS2tPbURsUlNjTXlvNW01VEc5U3ROdXVNYTF2dlRFUjQv?= =?utf-8?B?SzN1OEZ4TGlKZTkzand4ejRuZ1JiVXFVT1BZSlZyc2ZYVEVIR25aei96Y0Zm?= =?utf-8?B?TDdzRnlSMmwvb29vTjVNUzY0cWx6am0yaEl2T0Z1L3lPeDh1UWRQRWlUdTg3?= =?utf-8?B?YmVGNkpTWnpwMDRzRUQ0b1VsbWZGdVZlRGtrM3ViVS9ZRUJFTVhMeXBUa2I0?= =?utf-8?B?ZE9CeDQ1VVdJS3Q2bEdBUEx5MzVKU2NFbmdBZThLNURIWnpmMXYvVGw0Zmdy?= =?utf-8?B?eDZXNzhZRkk5TmZyYWtMVjlsTUlJaFRJWTl2QzAwdHJwdGw4UitTbnRFWmlm?= =?utf-8?B?dkVxcmRUbGNlU1VtcnVrSWZqM0xyVUJrUXpMeUFnbUdQOUIyQnNCckdMUWZL?= =?utf-8?B?QUtFTmhPVUoySFQvSDlVdnpLdzJ2QWo2eUVBT2RjN2kyaWZnNW1FSDY1c0ph?= =?utf-8?Q?B6GlOk2eAeXGlj3Q=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a92a8144-5555-437e-2eed-08da3a79e577 X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9514.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 16:00:44.7068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: glYXnO5VH/c+LXxOLVo0zA2kSjHcX8WtWv23Ks2iUZwHKwguE2qDFbi2ABJZbtbbcGJDYGTGDYwnvOfCwZgLCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8698 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 5/11/2022 4:55 PM, Rasmus Villemoes wrote: > On 11/05/2022 10.53, Gaurav Jain wrote: >> HW accelerated hash operations are giving incorrect hash output. >> so add flush and invalidate for input/output hash buffers. >> >> Fixes: 94e3c8c4fd (crypto/fsl - Add progressive hashing support using hardware acceleration.) > > AFAICT, it takes somewhat more to fix that commit; the progressive > hashing is entirely broken. > > It doesn't actually do anything progressive, it just stashes the > address/length pairs it is given, but doesn't feed the contents of those > buffers to the hardware, folding it into the hash state. So the caller Correct. > must not touch the buffers it passes until the finalization. I.e. I > think this won't work: > > char buf[SOMETHING]; > > update_buffer(buf); > hash_update(buf, len); > update_buffer_again(buf); > hash_update(buf, len); > Indeed, this won't work. > And this pattern can be found in e.g. drivers/dfu/dfu.c which seems to > repeatedly pass the same address (dfu->i_buf_start) to ->hash_update. > At first glance, dfu asks for crc32 algorithm, so it won't use this backend. But the concept is correct: user is not forced to keep a buffer unmodified (or even allocated) after .hash_update returns. Thanks, Horia