From: Peter Rosin <peda@axentia.se>
To: Wolfram Sang <wsa@the-dreams.de>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kieran Bingham <kieran@ksquared.org.uk>
Subject: Re: [PATCH v7 2/3] i2c: core: add device-managed version of i2c_new_dummy
Date: Sat, 16 Mar 2019 08:21:57 +0000 [thread overview]
Message-ID: <7d8b2a46-d349-5589-229c-f0c01c510feb@axentia.se> (raw)
In-Reply-To: <20190315210806.GA1749@kunai>
On 2019-03-15 22:08, Wolfram Sang wrote:
>
>>> I personally really dislike the proposed name. It is akin to the abomination
>>> where some sort of abbreviation of the types of variables are included also
>>> in the variable names. It's useless clutter, at least to me.
>>
>>
>> I hate to be jumping in with just a 'me-too' - but I also had a similar
>> disliking to the _errptr suffix on the function name here.
>
> As I said to Peter, I am not exactly happy with the naming. I just
> couldn't come up with something better. I am totally open for
> suggestions here. Let's give ourselves a few days. Maybe inspiration
> will hit one of us somehow somewhen.
I can't seem to find what you said to me anywhere, it's not in my inbox and
I don't see any (other) reply from you on patchwork for this patch either.
Perhaps a resend is in order?
Cheers,
Peter
next prev parent reply other threads:[~2019-03-16 8:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 16:55 [PATCH v7 0/3] i2c: improve i2c_new_{device|dummy} Wolfram Sang
2019-03-13 16:55 ` [PATCH v7 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy Wolfram Sang
2019-03-15 11:57 ` Simon Horman
2019-03-15 12:15 ` Kieran Bingham
2019-03-13 16:55 ` [PATCH v7 2/3] i2c: core: add device-managed version of i2c_new_dummy Wolfram Sang
2019-03-14 10:25 ` Peter Rosin
2019-03-15 12:06 ` Kieran Bingham
2019-03-15 21:08 ` Wolfram Sang
2019-03-16 8:21 ` Peter Rosin [this message]
2019-03-16 16:44 ` Wolfram Sang
2019-03-16 16:43 ` Wolfram Sang
2019-03-17 21:32 ` Peter Rosin
2019-03-15 12:05 ` Simon Horman
2019-03-13 16:55 ` [PATCH v7 3/3] mfd: da9063: occupy second I2C address, too Wolfram Sang
2019-03-15 12:06 ` Simon Horman
2019-03-13 20:55 ` [PATCH v7 0/3] i2c: improve i2c_new_{device|dummy} Bartosz Golaszewski
2019-03-13 21:09 ` Wolfram Sang
2019-03-13 21:18 ` Bartosz Golaszewski
2019-03-13 21:19 ` Wolfram Sang
2019-03-14 8:51 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8b2a46-d349-5589-229c-f0c01c510feb@axentia.se \
--to=peda@axentia.se \
--cc=brgl@bgdev.pl \
--cc=hkallweit1@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kieran@ksquared.org.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.