Re: [igt-dev] [PATCH i-g-t] meson: Allow source location to be configurable

[Martin Peres <martin.peres@mupuf.org>]

Hi Richard,

On 28/02/2021 14:29, Richard Purdie wrote:
> On Sun, 2021-02-28 at 12:06 +0200, Martin Peres wrote:
>> On 27/02/2021 16:49, Richard Purdie wrote:
>>>
>>>    lib_version = vcs_tag(input : 'version.h.in', output : 'version.h',
>>>    		      fallback : 'NO-GIT',
>>> diff --git a/meson_options.txt b/meson_options.txt
>>> index ff3abf08..a0a1aaed 100644
>>> --- a/meson_options.txt
>>> +++ b/meson_options.txt
>>> @@ -50,3 +50,7 @@ option('use_rpath',
>>>           type : 'boolean',
>>>           value : false,
>>>           description : 'Set runpath on installed executables for libigt.so')
>>> +
>>> +option('srcdir',
>>> +       type : 'string',
>>> +       description : 'Path to source code to be compiled into binaries (optional)')
>>
>> Shouldn't this read: "Path to THE source code to be compiled
>> (optional)"? Compiling into binaries is a little redundant, so I would
>> drop it.
> 
> I'm not sure that does quite mean the same thing. The option is talking
> about a path which gets compiled inside the binary rather than a path to code
> which is compiled.
> 
> Regardless, it clearly needs to be more clear! :)
> 
> How about "Source code path in the target environment for use within target
> binaries (optional)"?

Ah ah! Yeah, that was not how I understood it, and your new help text is 
definitely making sense :)

Please send a v2 with this done, after you get an actual review :)

Cheers,
Martin

> 
> Cheers,
> 
> Richard
> 
>> Other than this, the rationale seems sane, but I am not
>> knowledgeable-enough about IGT's build system to comment more on it:
>>
>> Acked-by: Martin Peres <martin.peres@mupuf.org>
>>
>>>
>>
> 
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev