From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78404C433F5 for ; Thu, 17 Feb 2022 11:01:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.274657.470202 (Exim 4.92) (envelope-from ) id 1nKeXC-0006Pj-AN; Thu, 17 Feb 2022 11:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 274657.470202; Thu, 17 Feb 2022 11:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nKeXC-0006Pc-6D; Thu, 17 Feb 2022 11:01:14 +0000 Received: by outflank-mailman (input) for mailman id 274657; Thu, 17 Feb 2022 11:01:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nKeXB-0006PU-JC for xen-devel@lists.xenproject.org; Thu, 17 Feb 2022 11:01:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nKeX9-0002em-GX; Thu, 17 Feb 2022 11:01:11 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.236.18]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nKeX9-0005PC-Ar; Thu, 17 Feb 2022 11:01:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ILJlgiB2MVZhZyIdl6l4gpCNPlV65nDoLLW2Rp3c5Zw=; b=CHCkSz3/8TcTWqcHX8ucbiSAeR RqNDJYoIh6b4wDbzTA1qgjnxJtbzsMW8xFEZdNIYq3l7bX+CFNDTAagIqbLcI4kWCSFBOqI6TMBTv xF32689QKEPl2JpG4oXKhCHvzTXyS/HwzF+We/Hh4ieZ0rsnUDLRroHRze9gkZge6Um4=; Message-ID: <7d934fd7-b1e2-8a9e-10dd-a213db93c689@xen.org> Date: Thu, 17 Feb 2022 11:01:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v6 02/11] xen: introduce CDF_directmap To: Jan Beulich , Penny Zheng Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com, xen-devel@lists.xenproject.org, sstabellini@kernel.org References: <20220214031956.3726764-1-penny.zheng@arm.com> <20220214031956.3726764-3-penny.zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 16/02/2022 09:34, Jan Beulich wrote: > On 15.02.2022 21:26, Julien Grall wrote: >> (+ Jan) >> >> Hi Penny, >> >> I am CCing Jan to give him a chance to... > > Thanks, but ... > >> On 14/02/2022 03:19, Penny Zheng wrote: >>> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h >>> index cfb0b47f13..24eb4cc7d3 100644 >>> --- a/xen/include/xen/domain.h >>> +++ b/xen/include/xen/domain.h >>> @@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d, >>> /* CDF_* constant. Internal flags for domain creation. */ >>> /* Is this a privileged domain? */ >>> #define CDF_privileged (1U << 0) >>> +#ifdef CONFIG_ARM >>> +/* Should domain memory be directly mapped? */ >>> +#define CDF_directmap (1U << 1) >>> +#endif >> >> ... comment on this approach. I would be happy to switch to an ASSERT() >> if that's preferred. > > ... I think I did signal agreement with this approach beforehand. You raised a concern and it wasn't 100% obvious whether you would still be happy if we merged it as-is. So I preferred to ask rather than merging it and getting an angry e-mail/message afterwards :). Anyway, this series is now fully acked. So I will commit the series in a bit. Cheers, -- Julien Grall