From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751590AbcHLBuy (ORCPT ); Thu, 11 Aug 2016 21:50:54 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:34175 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcHLBuw (ORCPT ); Thu, 11 Aug 2016 21:50:52 -0400 Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node To: Reza Arbab , Rob Herring , Mark Rutland , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jonathan Corbet , Bharata B Rao , Nathan Fontenot , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1470680843-28702-1-git-send-email-arbab@linux.vnet.ibm.com> <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com> From: Balbir Singh Message-ID: <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> Date: Fri, 12 Aug 2016 11:50:43 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/16 04:27, Reza Arbab wrote: > Remove the check which prevents us from hotplugging into an empty node. > > Signed-off-by: Reza Arbab > --- > arch/powerpc/mm/numa.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > index 80d067d..bc70c4f 100644 > --- a/arch/powerpc/mm/numa.c > +++ b/arch/powerpc/mm/numa.c > @@ -1127,7 +1127,7 @@ static int hot_add_node_scn_to_nid(unsigned long scn_addr) > int hot_add_scn_to_nid(unsigned long scn_addr) > { > struct device_node *memory = NULL; > - int nid, found = 0; > + int nid; > Do we want to do this only for ibm,hotplug-aperture compatible ranges? I'm OK either ways Acked-by: Balbir Singh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by kanga.kvack.org (Postfix) with ESMTP id 6B0A36B0253 for ; Thu, 11 Aug 2016 21:50:54 -0400 (EDT) Received: by mail-pa0-f71.google.com with SMTP id ag5so20068784pad.2 for ; Thu, 11 Aug 2016 18:50:54 -0700 (PDT) Received: from mail-pa0-x241.google.com (mail-pa0-x241.google.com. [2607:f8b0:400e:c03::241]) by mx.google.com with ESMTPS id g2si6029529pfa.278.2016.08.11.18.50.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Aug 2016 18:50:53 -0700 (PDT) Received: by mail-pa0-x241.google.com with SMTP id vy10so616320pac.0 for ; Thu, 11 Aug 2016 18:50:52 -0700 (PDT) Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node References: <1470680843-28702-1-git-send-email-arbab@linux.vnet.ibm.com> <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com> From: Balbir Singh Message-ID: <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> Date: Fri, 12 Aug 2016 11:50:43 +1000 MIME-Version: 1.0 In-Reply-To: <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Reza Arbab , Rob Herring , Mark Rutland , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jonathan Corbet , Bharata B Rao , Nathan Fontenot , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On 09/08/16 04:27, Reza Arbab wrote: > Remove the check which prevents us from hotplugging into an empty node. > > Signed-off-by: Reza Arbab > --- > arch/powerpc/mm/numa.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > index 80d067d..bc70c4f 100644 > --- a/arch/powerpc/mm/numa.c > +++ b/arch/powerpc/mm/numa.c > @@ -1127,7 +1127,7 @@ static int hot_add_node_scn_to_nid(unsigned long scn_addr) > int hot_add_scn_to_nid(unsigned long scn_addr) > { > struct device_node *memory = NULL; > - int nid, found = 0; > + int nid; > Do we want to do this only for ibm,hotplug-aperture compatible ranges? I'm OK either ways Acked-by: Balbir Singh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org