From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] glib-compat: work around g_test_message bug with subprocess tests
Date: Tue, 27 Nov 2018 19:55:51 +0100 [thread overview]
Message-ID: <7d95c907-c3da-d992-8133-e4b65a17370c@redhat.com> (raw)
In-Reply-To: <CAMxuvawT9NgS6N769gmZ+kzSzefBcp1eYpa_h_OWJ2S12b_O=g@mail.gmail.com>
On 27/11/18 19:49, Marc-André Lureau wrote:
> good catch! makes me wonder if g_test_message() is supposed to be
> usable in a subprocess.. Let see the review comments on upstream bug.
> At least, documentation should be updated.
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Considering that GLib goes to great lengths to pass the test log fd as
--GTestFD, it definitely should. So the alternative is not that that
documentation should be updated, the test log file descriptor should not
be passed.
Paolo
next prev parent reply other threads:[~2018-11-27 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 18:35 [Qemu-devel] [PATCH] glib-compat: work around g_test_message bug with subprocess tests Paolo Bonzini
2018-11-27 18:44 ` Eric Blake
2018-11-27 18:58 ` Paolo Bonzini
2018-11-29 13:38 ` [Qemu-devel] [Qemu-devel for-3.1?] " Eric Blake
2018-11-27 18:49 ` [Qemu-devel] " Marc-André Lureau
2018-11-27 18:55 ` Paolo Bonzini [this message]
2018-11-29 11:57 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d95c907-c3da-d992-8133-e4b65a17370c@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.