From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F1B2C4332F for ; Thu, 20 Oct 2022 07:30:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17AE210E3CF; Thu, 20 Oct 2022 07:30:27 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id F232010E3CF for ; Thu, 20 Oct 2022 07:30:25 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id F31755808CC; Thu, 20 Oct 2022 03:30:24 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 20 Oct 2022 03:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666251024; x=1666258224; bh=wOxLCzcVu+ q+SEyBn/M4QllQRne63QwVrmt2BoYxq6o=; b=DB0KPjPqIj/nbnYmjgdk0kCApn aVNrHAQUjdw5QcGUS9R59jqK3joi2g74adqnI0MmeDADz+cBP8HjR3FjsgxGJszU p7fKM+Yv2Fz+EuiBub/9XJaJVi/9TirMoM1DjawknQWEzHchWNPsl6pnKdzdgKgm HvgBa7nfN6nWlTRqU05OkOZwHXJo+MwEcGdGgEHDxOMRBuGQISe87t4xOJKUHYra sMFrtpuBVPevYu2OkPxDX6bxJZ38fenQBKR+9kX4f+tCmeFFSHIYyDUmpKbjyRUq dpKGnV8CZUqRSZ6eN3b8CXbIKEZqyylRN+lsUr65byN/Hk1sl9+IVSko+5QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666251024; x=1666258224; bh=wOxLCzcVu+q+SEyBn/M4QllQRne6 3QwVrmt2BoYxq6o=; b=URPrxE7B17bixo89Pz9gzBBvqySx2hF97gJCAd+ebL/7 kcG0y4nvK22Qh9tt4OKq8DtlgClI/rhX96NTFg1Hngkyyq5qF6fXp845XARp65bt wEnkduta/m/nuPAEj+loUCHG0sm9CqNdEds3ZxbVU9y4oenFNSi4W6XHHipJHXUO irBXEM1d7oo/igL7tNEEJSt2M6tp3/nWO5tN55L05H//4mZp/c56nwyWm2lw0yMH MDMzLWwiJHCteWb4eOBQewYJMD1Z4V1vnr7UPgKMlFu3zR2kGeeCreGbh455udxg b8Qkvq7qOkGpMcj9NyxDlv4QsnBI1g5eMXza/DX8Dw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelhedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeu feehudenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 12D00B60086; Thu, 20 Oct 2022 03:30:22 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-Id: <7d9eebc8-39b6-4dc1-9ffc-f17ec584bee2@app.fastmail.com> In-Reply-To: References: <20221019161831.3864786-1-arnd@kernel.org> Date: Thu, 20 Oct 2022 09:30:03 +0200 From: "Arnd Bergmann" To: "Robert Jarzmik" , "Arnd Bergmann" Subject: Re: [PATCH 00/30] ARM: pxa: remove all unused boards&drivers Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-usb@vger.kernel.org, Vignesh Raghavendra , lgirdwood@gmail.com, Viresh Kumar , Ulf Hansson , Dominik Brodowski , perex@perex.cz, Wolfram Sang , patches@opensource.cirrus.com, linux-mtd@lists.infradead.org, philipp.zabel@gmail.com, Miquel Raynal , Damien Le Moal , kernel@wantstofly.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Bartosz Golaszewski , Lee Jones , Russell King , marek.vasut@gmail.com, Alan Stern , lost.distance@yahoo.com, slapin@ossfans.org, alsa-devel@alsa-project.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Mark Brown , sre@kernel.org, linux-fbdev@vger.kernel.org, tiwai@suse.com, linux-arm-kernel@lists.infradead.org, Felipe Balbi , mkpetch@internode.on.net, Sergey Shtylyov , linux-ide@vger.kernel.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, Dmitry Torokhov , "linux-mmc @ vger . kernel . org" , linux-kernel@vger.kernel.org, Sudip Mukherjee , Linux-Renesas , Greg Kroah-Hartman , Helge Deller , Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 19, 2022, at 23:13, Robert Jarzmik wrote: > Arnd Bergmann writes: > >> From: Arnd Bergmann > ...zip... > >> A good number of drivers become impossible to select after this, so >> each of these also get dropped. I'm including the driver patches in the >> series here and can either merge them through the soc tree, or they >> can get picked up by the individual subsystem maintainers. Since both >> the platform and the drivers get removed, the order should not matter. > This part is a bit ... bothering. > I at least identified these : >> delete mode 100644 drivers/input/touchscreen/wm9705.c >> delete mode 100644 drivers/input/touchscreen/wm9712.c >> delete mode 100644 drivers/input/touchscreen/wm9713.c >> delete mode 100644 drivers/input/touchscreen/wm97xx-core.c >> delete mode 100644 drivers/mfd/wm97xx-core.c >> delete mode 100644 sound/ac97/bus.c >> delete mode 100644 sound/ac97/codec.c >> delete mode 100644 sound/ac97/snd_ac97_compat.c > > For the existing platforms working with devicetree support (mioa701 for > example), the wm9713 was properly used, providing both sound support and input > touchscreen. > So was the a97 part, providing a framework to make the wm9713 work. > > So I'm wondering how the choice to chop these drivers was done, and it is > necessary to remove them. If so, maybe pxa support in the kernel should be > removed all together, as people playing with it loose part of the working DT > platforms they had. If the files are used for DT based machines, then they should definitely stay, the intention of my series was to only remove known dead code. What I did was to remove CONFIG_UNUSED_BOARD_FILES and then recursively trim out all code that could be compiled in before but not after this change, assuming that this would be safe. What I see here is that AC97_BUS_NEW and SND_PXA2XX_SOC_AC97 are selected by eight legacy board files (tosa, e740, e750, e800, em_x270, palm27x, zylonite and mioa701), but no DT based machine, so without CONFIG_UNUSED_BOARD_FILES, the entire AC97_BUS_NEW infrastructure and all drivers depending on this became dead code. Unfortunately I ran into problems sending out the rest of the series after sending the cover letter, so the explanations I put in the individual patches were not here. See [1] for the actual series. Since it looks like I'll have to redo half of the PXA patches after leaving AC97_BUS_NEW in, I won't post the full version first. Any idea where I went wrong here? Did I make a mistake in following the Kconfig dependencies, or are some parts of this incorrectly annotated? Arnd [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=boardfile-remove&id=73c4b7cfbc2b2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89317C4167B for ; Thu, 20 Oct 2022 07:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbiJTHas (ORCPT ); Thu, 20 Oct 2022 03:30:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbiJTHap (ORCPT ); Thu, 20 Oct 2022 03:30:45 -0400 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79FC94B0F5; Thu, 20 Oct 2022 00:30:26 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id F31755808CC; Thu, 20 Oct 2022 03:30:24 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 20 Oct 2022 03:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666251024; x=1666258224; bh=wOxLCzcVu+ q+SEyBn/M4QllQRne63QwVrmt2BoYxq6o=; b=DB0KPjPqIj/nbnYmjgdk0kCApn aVNrHAQUjdw5QcGUS9R59jqK3joi2g74adqnI0MmeDADz+cBP8HjR3FjsgxGJszU p7fKM+Yv2Fz+EuiBub/9XJaJVi/9TirMoM1DjawknQWEzHchWNPsl6pnKdzdgKgm HvgBa7nfN6nWlTRqU05OkOZwHXJo+MwEcGdGgEHDxOMRBuGQISe87t4xOJKUHYra sMFrtpuBVPevYu2OkPxDX6bxJZ38fenQBKR+9kX4f+tCmeFFSHIYyDUmpKbjyRUq dpKGnV8CZUqRSZ6eN3b8CXbIKEZqyylRN+lsUr65byN/Hk1sl9+IVSko+5QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666251024; x=1666258224; bh=wOxLCzcVu+q+SEyBn/M4QllQRne6 3QwVrmt2BoYxq6o=; b=URPrxE7B17bixo89Pz9gzBBvqySx2hF97gJCAd+ebL/7 kcG0y4nvK22Qh9tt4OKq8DtlgClI/rhX96NTFg1Hngkyyq5qF6fXp845XARp65bt wEnkduta/m/nuPAEj+loUCHG0sm9CqNdEds3ZxbVU9y4oenFNSi4W6XHHipJHXUO irBXEM1d7oo/igL7tNEEJSt2M6tp3/nWO5tN55L05H//4mZp/c56nwyWm2lw0yMH MDMzLWwiJHCteWb4eOBQewYJMD1Z4V1vnr7UPgKMlFu3zR2kGeeCreGbh455udxg b8Qkvq7qOkGpMcj9NyxDlv4QsnBI1g5eMXza/DX8Dw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelhedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeu feehudenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 12D00B60086; Thu, 20 Oct 2022 03:30:22 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-Id: <7d9eebc8-39b6-4dc1-9ffc-f17ec584bee2@app.fastmail.com> In-Reply-To: References: <20221019161831.3864786-1-arnd@kernel.org> Date: Thu, 20 Oct 2022 09:30:03 +0200 From: "Arnd Bergmann" To: "Robert Jarzmik" , "Arnd Bergmann" Cc: linux-arm-kernel@lists.infradead.org, "Daniel Mack" , "Haojian Zhuang" , linux-kernel@vger.kernel.org, "Alan Stern" , "Alexandre Belloni" , "Bartosz Golaszewski" , "Damien Le Moal" , "Dmitry Torokhov" , "Dominik Brodowski" , "Felipe Balbi" , "Greg Kroah-Hartman" , "Helge Deller" , perex@perex.cz, jingoohan1@gmail.com, "Lee Jones" , kernel@wantstofly.org, lgirdwood@gmail.com, "Linus Walleij" , marek.vasut@gmail.com, "Mark Brown" , mkpetch@internode.on.net, "Miquel Raynal" , lost.distance@yahoo.com, philipp.zabel@gmail.com, "Russell King" , sre@kernel.org, slapin@ossfans.org, "Sergey Shtylyov" , "Sudip Mukherjee" , tiwai@suse.com, "Ulf Hansson" , "Vignesh Raghavendra" , "Viresh Kumar" , "Wolfram Sang" , linux-pm@vger.kernel.org, linux-ide@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, "linux-mmc @ vger . kernel . org" , Linux-Renesas , linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 00/30] ARM: pxa: remove all unused boards&drivers Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, Oct 19, 2022, at 23:13, Robert Jarzmik wrote: > Arnd Bergmann writes: > >> From: Arnd Bergmann > ...zip... > >> A good number of drivers become impossible to select after this, so >> each of these also get dropped. I'm including the driver patches in the >> series here and can either merge them through the soc tree, or they >> can get picked up by the individual subsystem maintainers. Since both >> the platform and the drivers get removed, the order should not matter. > This part is a bit ... bothering. > I at least identified these : >> delete mode 100644 drivers/input/touchscreen/wm9705.c >> delete mode 100644 drivers/input/touchscreen/wm9712.c >> delete mode 100644 drivers/input/touchscreen/wm9713.c >> delete mode 100644 drivers/input/touchscreen/wm97xx-core.c >> delete mode 100644 drivers/mfd/wm97xx-core.c >> delete mode 100644 sound/ac97/bus.c >> delete mode 100644 sound/ac97/codec.c >> delete mode 100644 sound/ac97/snd_ac97_compat.c > > For the existing platforms working with devicetree support (mioa701 for > example), the wm9713 was properly used, providing both sound support and input > touchscreen. > So was the a97 part, providing a framework to make the wm9713 work. > > So I'm wondering how the choice to chop these drivers was done, and it is > necessary to remove them. If so, maybe pxa support in the kernel should be > removed all together, as people playing with it loose part of the working DT > platforms they had. If the files are used for DT based machines, then they should definitely stay, the intention of my series was to only remove known dead code. What I did was to remove CONFIG_UNUSED_BOARD_FILES and then recursively trim out all code that could be compiled in before but not after this change, assuming that this would be safe. What I see here is that AC97_BUS_NEW and SND_PXA2XX_SOC_AC97 are selected by eight legacy board files (tosa, e740, e750, e800, em_x270, palm27x, zylonite and mioa701), but no DT based machine, so without CONFIG_UNUSED_BOARD_FILES, the entire AC97_BUS_NEW infrastructure and all drivers depending on this became dead code. Unfortunately I ran into problems sending out the rest of the series after sending the cover letter, so the explanations I put in the individual patches were not here. See [1] for the actual series. Since it looks like I'll have to redo half of the PXA patches after leaving AC97_BUS_NEW in, I won't post the full version first. Any idea where I went wrong here? Did I make a mistake in following the Kconfig dependencies, or are some parts of this incorrectly annotated? Arnd [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=boardfile-remove&id=73c4b7cfbc2b2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B487CC433FE for ; Thu, 20 Oct 2022 07:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mPJi+OX8/Z7UQkybRH3dw3UMw6xY8vL/JpV05K+vZd4=; b=R4F+SguM78l9xS cRgucyCBX5jhZjl5apNzK+opIH5ddnp4Bo/u1N3s2KI7y4WtAtDxuKrA4JkwIoPBrud/FKkuqiOdt 1A2FhgI5NQVXZg2kNnPoMiNv4W/XgRjX1zh6iZaJdMrfr9u5laDS7UjvE1JUouJCzxmGgs4nYqgYf MM4JNTAV8dR2OcJ33XkYec8l4QoU205XTMfKuTIhDVFRk2vj/2pKGGFrI3zcIIMsH5m/5xYUWkkeM SG+yjxod16c94qXoRW+Z4E7+BuRCCkIlQj20d+pCCFjxD9DfO49v3ZKSsW+WDTv8dceYsXR/Vn4ZR Gnw2D19y3dOcH6hEYGSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olQ0e-00Bi8u-Ru; Thu, 20 Oct 2022 07:30:33 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olQ0Z-00Bi2I-S0; Thu, 20 Oct 2022 07:30:29 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id F31755808CC; Thu, 20 Oct 2022 03:30:24 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 20 Oct 2022 03:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666251024; x=1666258224; bh=wOxLCzcVu+ q+SEyBn/M4QllQRne63QwVrmt2BoYxq6o=; b=DB0KPjPqIj/nbnYmjgdk0kCApn aVNrHAQUjdw5QcGUS9R59jqK3joi2g74adqnI0MmeDADz+cBP8HjR3FjsgxGJszU p7fKM+Yv2Fz+EuiBub/9XJaJVi/9TirMoM1DjawknQWEzHchWNPsl6pnKdzdgKgm HvgBa7nfN6nWlTRqU05OkOZwHXJo+MwEcGdGgEHDxOMRBuGQISe87t4xOJKUHYra sMFrtpuBVPevYu2OkPxDX6bxJZ38fenQBKR+9kX4f+tCmeFFSHIYyDUmpKbjyRUq dpKGnV8CZUqRSZ6eN3b8CXbIKEZqyylRN+lsUr65byN/Hk1sl9+IVSko+5QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666251024; x=1666258224; bh=wOxLCzcVu+q+SEyBn/M4QllQRne6 3QwVrmt2BoYxq6o=; b=URPrxE7B17bixo89Pz9gzBBvqySx2hF97gJCAd+ebL/7 kcG0y4nvK22Qh9tt4OKq8DtlgClI/rhX96NTFg1Hngkyyq5qF6fXp845XARp65bt wEnkduta/m/nuPAEj+loUCHG0sm9CqNdEds3ZxbVU9y4oenFNSi4W6XHHipJHXUO irBXEM1d7oo/igL7tNEEJSt2M6tp3/nWO5tN55L05H//4mZp/c56nwyWm2lw0yMH MDMzLWwiJHCteWb4eOBQewYJMD1Z4V1vnr7UPgKMlFu3zR2kGeeCreGbh455udxg b8Qkvq7qOkGpMcj9NyxDlv4QsnBI1g5eMXza/DX8Dw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelhedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeu feehudenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 12D00B60086; Thu, 20 Oct 2022 03:30:22 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-Id: <7d9eebc8-39b6-4dc1-9ffc-f17ec584bee2@app.fastmail.com> In-Reply-To: References: <20221019161831.3864786-1-arnd@kernel.org> Date: Thu, 20 Oct 2022 09:30:03 +0200 From: "Arnd Bergmann" To: "Robert Jarzmik" , "Arnd Bergmann" Cc: linux-arm-kernel@lists.infradead.org, "Daniel Mack" , "Haojian Zhuang" , linux-kernel@vger.kernel.org, "Alan Stern" , "Alexandre Belloni" , "Bartosz Golaszewski" , "Damien Le Moal" , "Dmitry Torokhov" , "Dominik Brodowski" , "Felipe Balbi" , "Greg Kroah-Hartman" , "Helge Deller" , perex@perex.cz, jingoohan1@gmail.com, "Lee Jones" , kernel@wantstofly.org, lgirdwood@gmail.com, "Linus Walleij" , marek.vasut@gmail.com, "Mark Brown" , mkpetch@internode.on.net, "Miquel Raynal" , lost.distance@yahoo.com, philipp.zabel@gmail.com, "Russell King" , sre@kernel.org, slapin@ossfans.org, "Sergey Shtylyov" , "Sudip Mukherjee" , tiwai@suse.com, "Ulf Hansson" , "Vignesh Raghavendra" , "Viresh Kumar" , "Wolfram Sang" , linux-pm@vger.kernel.org, linux-ide@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, "linux-mmc @ vger . kernel . org" , Linux-Renesas , linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 00/30] ARM: pxa: remove all unused boards&drivers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_003028_000126_88E0A8C1 X-CRM114-Status: GOOD ( 21.79 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Oct 19, 2022, at 23:13, Robert Jarzmik wrote: > Arnd Bergmann writes: > >> From: Arnd Bergmann > ...zip... > >> A good number of drivers become impossible to select after this, so >> each of these also get dropped. I'm including the driver patches in the >> series here and can either merge them through the soc tree, or they >> can get picked up by the individual subsystem maintainers. Since both >> the platform and the drivers get removed, the order should not matter. > This part is a bit ... bothering. > I at least identified these : >> delete mode 100644 drivers/input/touchscreen/wm9705.c >> delete mode 100644 drivers/input/touchscreen/wm9712.c >> delete mode 100644 drivers/input/touchscreen/wm9713.c >> delete mode 100644 drivers/input/touchscreen/wm97xx-core.c >> delete mode 100644 drivers/mfd/wm97xx-core.c >> delete mode 100644 sound/ac97/bus.c >> delete mode 100644 sound/ac97/codec.c >> delete mode 100644 sound/ac97/snd_ac97_compat.c > > For the existing platforms working with devicetree support (mioa701 for > example), the wm9713 was properly used, providing both sound support and input > touchscreen. > So was the a97 part, providing a framework to make the wm9713 work. > > So I'm wondering how the choice to chop these drivers was done, and it is > necessary to remove them. If so, maybe pxa support in the kernel should be > removed all together, as people playing with it loose part of the working DT > platforms they had. If the files are used for DT based machines, then they should definitely stay, the intention of my series was to only remove known dead code. What I did was to remove CONFIG_UNUSED_BOARD_FILES and then recursively trim out all code that could be compiled in before but not after this change, assuming that this would be safe. What I see here is that AC97_BUS_NEW and SND_PXA2XX_SOC_AC97 are selected by eight legacy board files (tosa, e740, e750, e800, em_x270, palm27x, zylonite and mioa701), but no DT based machine, so without CONFIG_UNUSED_BOARD_FILES, the entire AC97_BUS_NEW infrastructure and all drivers depending on this became dead code. Unfortunately I ran into problems sending out the rest of the series after sending the cover letter, so the explanations I put in the individual patches were not here. See [1] for the actual series. Since it looks like I'll have to redo half of the PXA patches after leaving AC97_BUS_NEW in, I won't post the full version first. Any idea where I went wrong here? Did I make a mistake in following the Kconfig dependencies, or are some parts of this incorrectly annotated? Arnd [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=boardfile-remove&id=73c4b7cfbc2b2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DD65C433FE for ; Thu, 20 Oct 2022 10:40:58 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C7EEC8B8E; Thu, 20 Oct 2022 12:40:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C7EEC8B8E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666262456; bh=ODbf5lj3Wj/NcrkR8AuwAv98n5pvT5v/x3zw8IPEcE8=; h=In-Reply-To:References:Date:From:To:Subject:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dtDuVw6Oe76RX5ghWoE9Em73vDf07OTipOKcmZARYnW03ci7n5fx8nvACXa/8pC7o q4plQEaaVaUNKLtlDr0fBZnCmnRTDpdcsgTxpV1rAO5FfR0VzcHJSAJMy/8GiFjy/M OfgO/DyilIgjAYesUR2Ks8tbD4oIuk83gl8SPKZ4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0FB91F805EB; Thu, 20 Oct 2022 12:33:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29A20F8032B; Thu, 20 Oct 2022 09:30:35 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 43A97F800B5 for ; Thu, 20 Oct 2022 09:30:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 43A97F800B5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="DB0KPjPq"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="URPrxE7B" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id F31755808CC; Thu, 20 Oct 2022 03:30:24 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Thu, 20 Oct 2022 03:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666251024; x=1666258224; bh=wOxLCzcVu+ q+SEyBn/M4QllQRne63QwVrmt2BoYxq6o=; b=DB0KPjPqIj/nbnYmjgdk0kCApn aVNrHAQUjdw5QcGUS9R59jqK3joi2g74adqnI0MmeDADz+cBP8HjR3FjsgxGJszU p7fKM+Yv2Fz+EuiBub/9XJaJVi/9TirMoM1DjawknQWEzHchWNPsl6pnKdzdgKgm HvgBa7nfN6nWlTRqU05OkOZwHXJo+MwEcGdGgEHDxOMRBuGQISe87t4xOJKUHYra sMFrtpuBVPevYu2OkPxDX6bxJZ38fenQBKR+9kX4f+tCmeFFSHIYyDUmpKbjyRUq dpKGnV8CZUqRSZ6eN3b8CXbIKEZqyylRN+lsUr65byN/Hk1sl9+IVSko+5QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666251024; x=1666258224; bh=wOxLCzcVu+q+SEyBn/M4QllQRne6 3QwVrmt2BoYxq6o=; b=URPrxE7B17bixo89Pz9gzBBvqySx2hF97gJCAd+ebL/7 kcG0y4nvK22Qh9tt4OKq8DtlgClI/rhX96NTFg1Hngkyyq5qF6fXp845XARp65bt wEnkduta/m/nuPAEj+loUCHG0sm9CqNdEds3ZxbVU9y4oenFNSi4W6XHHipJHXUO irBXEM1d7oo/igL7tNEEJSt2M6tp3/nWO5tN55L05H//4mZp/c56nwyWm2lw0yMH MDMzLWwiJHCteWb4eOBQewYJMD1Z4V1vnr7UPgKMlFu3zR2kGeeCreGbh455udxg b8Qkvq7qOkGpMcj9NyxDlv4QsnBI1g5eMXza/DX8Dw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelhedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeu feehudenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 12D00B60086; Thu, 20 Oct 2022 03:30:22 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-Id: <7d9eebc8-39b6-4dc1-9ffc-f17ec584bee2@app.fastmail.com> In-Reply-To: References: <20221019161831.3864786-1-arnd@kernel.org> Date: Thu, 20 Oct 2022 09:30:03 +0200 From: "Arnd Bergmann" To: "Robert Jarzmik" , "Arnd Bergmann" Subject: Re: [PATCH 00/30] ARM: pxa: remove all unused boards&drivers Content-Type: text/plain X-Mailman-Approved-At: Thu, 20 Oct 2022 12:33:17 +0200 Cc: Alexandre Belloni , linux-usb@vger.kernel.org, Vignesh Raghavendra , lgirdwood@gmail.com, Viresh Kumar , Linus Walleij , Ulf Hansson , Dominik Brodowski , Wolfram Sang , patches@opensource.cirrus.com, linux-mtd@lists.infradead.org, philipp.zabel@gmail.com, Miquel Raynal , Damien Le Moal , kernel@wantstofly.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Bartosz Golaszewski , Lee Jones , Russell King , marek.vasut@gmail.com, Alan Stern , lost.distance@yahoo.com, slapin@ossfans.org, alsa-devel@alsa-project.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Mark Brown , sre@kernel.org, linux-fbdev@vger.kernel.org, tiwai@suse.com, linux-arm-kernel@lists.infradead.org, Felipe Balbi , mkpetch@internode.on.net, Sergey Shtylyov , linux-ide@vger.kernel.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, Dmitry Torokhov , "linux-mmc @ vger . kernel . org" , linux-kernel@vger.kernel.org, Sudip Mukherjee , Linux-Renesas , Greg Kroah-Hartman , Helge Deller , Daniel Mack X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Oct 19, 2022, at 23:13, Robert Jarzmik wrote: > Arnd Bergmann writes: > >> From: Arnd Bergmann > ...zip... > >> A good number of drivers become impossible to select after this, so >> each of these also get dropped. I'm including the driver patches in the >> series here and can either merge them through the soc tree, or they >> can get picked up by the individual subsystem maintainers. Since both >> the platform and the drivers get removed, the order should not matter. > This part is a bit ... bothering. > I at least identified these : >> delete mode 100644 drivers/input/touchscreen/wm9705.c >> delete mode 100644 drivers/input/touchscreen/wm9712.c >> delete mode 100644 drivers/input/touchscreen/wm9713.c >> delete mode 100644 drivers/input/touchscreen/wm97xx-core.c >> delete mode 100644 drivers/mfd/wm97xx-core.c >> delete mode 100644 sound/ac97/bus.c >> delete mode 100644 sound/ac97/codec.c >> delete mode 100644 sound/ac97/snd_ac97_compat.c > > For the existing platforms working with devicetree support (mioa701 for > example), the wm9713 was properly used, providing both sound support and input > touchscreen. > So was the a97 part, providing a framework to make the wm9713 work. > > So I'm wondering how the choice to chop these drivers was done, and it is > necessary to remove them. If so, maybe pxa support in the kernel should be > removed all together, as people playing with it loose part of the working DT > platforms they had. If the files are used for DT based machines, then they should definitely stay, the intention of my series was to only remove known dead code. What I did was to remove CONFIG_UNUSED_BOARD_FILES and then recursively trim out all code that could be compiled in before but not after this change, assuming that this would be safe. What I see here is that AC97_BUS_NEW and SND_PXA2XX_SOC_AC97 are selected by eight legacy board files (tosa, e740, e750, e800, em_x270, palm27x, zylonite and mioa701), but no DT based machine, so without CONFIG_UNUSED_BOARD_FILES, the entire AC97_BUS_NEW infrastructure and all drivers depending on this became dead code. Unfortunately I ran into problems sending out the rest of the series after sending the cover letter, so the explanations I put in the individual patches were not here. See [1] for the actual series. Since it looks like I'll have to redo half of the PXA patches after leaving AC97_BUS_NEW in, I won't post the full version first. Any idea where I went wrong here? Did I make a mistake in following the Kconfig dependencies, or are some parts of this incorrectly annotated? Arnd [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=boardfile-remove&id=73c4b7cfbc2b2