All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Girish K S <ks.giri@samsung.com>,
	Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
	Vasanth Ananthan <vasanth.a@samsung.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] phy: samsung: exynos5250-sata: fix missing device put in probe error paths
Date: Thu, 7 Apr 2022 11:19:46 +0200	[thread overview]
Message-ID: <7da30fdc-cef7-879a-69ef-6993e05beda5@linaro.org> (raw)
In-Reply-To: <20220407091857.230386-2-krzysztof.kozlowski@linaro.org>

On 07/04/2022 11:18, Krzysztof Kozlowski wrote:
> The actions of of_find_i2c_device_by_node() in probe function should be
> reversed in error paths by putting the reference to obtained device.
> 
> Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/phy/samsung/phy-exynos5250-sata.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

I forgot:
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

https://lore.kernel.org/all/018501d834eb$01e62ad0$05b28070$@samsung.com/


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Girish K S <ks.giri@samsung.com>,
	Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
	Vasanth Ananthan <vasanth.a@samsung.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] phy: samsung: exynos5250-sata: fix missing device put in probe error paths
Date: Thu, 7 Apr 2022 11:19:46 +0200	[thread overview]
Message-ID: <7da30fdc-cef7-879a-69ef-6993e05beda5@linaro.org> (raw)
In-Reply-To: <20220407091857.230386-2-krzysztof.kozlowski@linaro.org>

On 07/04/2022 11:18, Krzysztof Kozlowski wrote:
> The actions of of_find_i2c_device_by_node() in probe function should be
> reversed in error paths by putting the reference to obtained device.
> 
> Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/phy/samsung/phy-exynos5250-sata.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

I forgot:
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

https://lore.kernel.org/all/018501d834eb$01e62ad0$05b28070$@samsung.com/


Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Girish K S <ks.giri@samsung.com>,
	Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
	Vasanth Ananthan <vasanth.a@samsung.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] phy: samsung: exynos5250-sata: fix missing device put in probe error paths
Date: Thu, 7 Apr 2022 11:19:46 +0200	[thread overview]
Message-ID: <7da30fdc-cef7-879a-69ef-6993e05beda5@linaro.org> (raw)
In-Reply-To: <20220407091857.230386-2-krzysztof.kozlowski@linaro.org>

On 07/04/2022 11:18, Krzysztof Kozlowski wrote:
> The actions of of_find_i2c_device_by_node() in probe function should be
> reversed in error paths by putting the reference to obtained device.
> 
> Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/phy/samsung/phy-exynos5250-sata.c | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)

I forgot:
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

https://lore.kernel.org/all/018501d834eb$01e62ad0$05b28070$@samsung.com/


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-07  9:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  9:18 [RESEND PATCH 1/2] phy: samsung: Fix missing of_node_put() in exynos_sata_phy_probe Krzysztof Kozlowski
2022-04-07  9:18 ` Krzysztof Kozlowski
2022-04-07  9:18 ` Krzysztof Kozlowski
2022-04-07  9:18 ` [RESEND PATCH 2/2] phy: samsung: exynos5250-sata: fix missing device put in probe error paths Krzysztof Kozlowski
2022-04-07  9:18   ` Krzysztof Kozlowski
2022-04-07  9:18   ` Krzysztof Kozlowski
2022-04-07  9:19   ` Krzysztof Kozlowski [this message]
2022-04-07  9:19     ` Krzysztof Kozlowski
2022-04-07  9:19     ` Krzysztof Kozlowski
2022-04-11 17:16 ` [RESEND PATCH 1/2] phy: samsung: Fix missing of_node_put() in exynos_sata_phy_probe Vinod Koul
2022-04-11 17:16   ` Vinod Koul
2022-04-11 17:16   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7da30fdc-cef7-879a-69ef-6993e05beda5@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=kishon@ti.com \
    --cc=ks.giri@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=vasanth.a@samsung.com \
    --cc=vkoul@kernel.org \
    --cc=yuvaraj.cd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.