From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1c8tx3-0001Vr-5g for mharc-grub-devel@gnu.org; Mon, 21 Nov 2016 14:08:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8tx0-0001VB-Ad for grub-devel@gnu.org; Mon, 21 Nov 2016 14:08:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8twv-0008By-8L for grub-devel@gnu.org; Mon, 21 Nov 2016 14:08:22 -0500 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:34368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c8twv-0008BQ-1F for grub-devel@gnu.org; Mon, 21 Nov 2016 14:08:17 -0500 Received: by mail-qt0-x242.google.com with SMTP id l20so26672427qta.1 for ; Mon, 21 Nov 2016 11:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=twgp9FmTxdW/i5a4bpf7Jwn37r53z9GA846farYG1cg=; b=HqaSemV+tPCu/NvQfl8kTja04kSXVfNwITz+yKDXgUXJDgosE3NxlTKZAuVB0TZZ4R h+apQYA36c2NiSS/U2AwzM9Uo36xasROKCLu31zd1U7qyy7/SUH+fL0gXXZcCEKlWyzY 53B6JbUe6kxo1a3aJ3YLFPnJyCAgcZYw721pku/hcdUTYqtn49ITBKQlZPlQtzNbRFuv dKzmep/6FcS54xGKkpp7HTBDf7Jr4SxhW9buNHcINTQkOuhgNZhrA+fVr8ZVt3MOlGbv CXShTZwlqG3w82OLOhuijxt5uka7cOWIe6InCeglzOY0nouPcSM+Pts0TFT/voRuVcxj Nxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=twgp9FmTxdW/i5a4bpf7Jwn37r53z9GA846farYG1cg=; b=aA1w/OSHAOPMsPD4oc9FeMqzjh8PFtaC1Fj13l0u9TgtsyJRcmryLbiiIMBn7Nee8M fUnAj5PBwPBJBYXTKHvaJdlnOdgNJlJBn1ACLgUh21h9yt1BR9FNtLmYhOaeznlbB+4k qlO1bHrvgrHQ5fPv5ACRXl6jeUawpU06dswdF5VLGzPakOZD4661Nts+QjrKqEx5r/BL Ld58RXbyBEFdxQrUgTSzfAwOIdqmVPLnXZgIVKJ7cBVeArMfzcgPkptRALWZNFKl0GhM G/4U12dAe5AQXeQge1h2xLG6BmMiv3zlbR4UbY5JBfu13tpJLogGqOa80q0UIeyR9ki2 wZEg== X-Gm-Message-State: AKaTC02CLRawHpuHgWxeI3aq4OeqS+4dYJzeLEWHfmFMqLsTckdi+UohpjC7F84iS0vp6Q== X-Received: by 10.25.156.135 with SMTP id f129mr3764312lfe.124.1479755295331; Mon, 21 Nov 2016 11:08:15 -0800 (PST) Received: from [192.168.1.44] (ppp109-252-90-55.pppoe.spdop.ru. [109.252.90.55]) by smtp.gmail.com with ESMTPSA id s6sm5536563lfe.11.2016.11.21.11.08.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2016 11:08:14 -0800 (PST) Subject: Re: [PATCH v2] serial: Poll USB devices if usbX serial port is missing To: Joonas Lahtinen References: <7b9507a2-8bd4-2da7-8a04-333377e42bec@gmail.com> <1479465398-23174-1-git-send-email-joonas.lahtinen@linux.intel.com> <1479737119.3256.7.camel@linux.intel.com> Cc: The development of GNU GRUB From: Andrei Borzenkov Message-ID: <7da8c724-ecd7-613d-5a74-4e1d68b04330@gmail.com> Date: Mon, 21 Nov 2016 22:08:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479737119.3256.7.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::242 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 19:08:23 -0000 21.11.2016 17:05, Joonas Lahtinen пишет: > On pe, 2016-11-18 at 15:21 +0300, Andrei Borzenkov wrote: >> On Fri, Nov 18, 2016 at 1:36 PM, Joonas Lahtinen >>> >>> v2: >>> - Use grub_term_poll_usb to avoid module dependency (Andrei) >>> >> >> Hmm ... note that terminal_input/terminal_output also auto-load >> modules that handle serial ports. So this still will not be >> equivalent, it will require user to manually pre-load USB. Did you >> actually test this version of patch? Do you pre-load USB modules >> somewhere? > > Nope, I took your word literally and just changed the function. Looking more closely, only top-level modules are autoloaded anyway, like "serial" itself; low level drivers are not, at least as far as I can tell. In your case "serial" is pulled in by using command, so it should be no change. > Assuming it's a rather direct replacement. Excuse for that. > Could you confirm that your last version works for you? Could you give more details about your configuration, in particular, how you load necessary modules (if you load them)? What USB serial driver you use? >> >> The problem is, infrastructure to handle auto-load lists currently >> belongs to normal mode, while serial may sensibly be used before >> normal is loaded. Not sure what we can do here. > > I think this is getting more important when we're seeing increasing > amount of devices without even an internal serial port. > > Sounds to me like pulling the auto-loading out of just normal mode > would make sense? > > Regards, Joonas >