From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Ard Biesheuvel" <ardb@kernel.org>, "Loïc Yhuel" <loic.yhuel@gmail.com>
Cc: Matthew Garrett <mjg59@google.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>
Subject: Re: [PATCH] tpm: check event log version before reading final events
Date: Fri, 15 May 2020 03:03:10 +0300 [thread overview]
Message-ID: <7dadd27c89860c03d6c2eb0922838ef3e29e8f9b.camel@linux.intel.com> (raw)
In-Reply-To: <CAMj1kXEUTdmudiB5aKeDAkYhv5jbwzBQ4cOrxK8VOt8O8Xjk=Q@mail.gmail.com>
On Thu, 2020-05-14 at 13:31 +0200, Ard Biesheuvel wrote:
> On Thu, 14 May 2020 at 13:28, Loïc Yhuel <loic.yhuel@gmail.com> wrote:
> > Le jeu. 14 mai 2020 à 12:54, Jarkko Sakkinen
> > <jarkko.sakkinen@linux.intel.com> a écrit :
> > > So it is clear that "pr_warn(FW_BUG ..." would be a sane to have there.
> > So only to tell the UEFI might have logged events the kernel can't read ?
> > There is no warning if the table is missing, which would have the same result.
> >
> > I can try to dump it, perhaps it is using the SHA-1 log format.
> > If so, would a patch to support this non-standard behavior be accepted ?
>
> That is why I was asking the question: what exact condition should we
> warn about? And at which point?
Always when final table is missing there should be some sort of notification
because the event log is incomplete.
I.e. it misses PCR5 extends from GetEventLog().
No additional info, just a note that we don't have the tail. I'm fine with
info level message too.
/Jarkko
next prev parent reply other threads:[~2020-05-15 0:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 4:01 [PATCH] tpm: check event log version before reading final events Loïc Yhuel
2020-05-12 6:44 ` Ard Biesheuvel
2020-05-12 11:40 ` Loïc Yhuel
2020-05-12 12:30 ` Ard Biesheuvel
2020-05-14 10:51 ` Jarkko Sakkinen
2020-05-14 1:09 ` Jarkko Sakkinen
2020-05-14 8:10 ` Ard Biesheuvel
2020-05-14 23:44 ` Jarkko Sakkinen
2020-05-12 17:45 ` Javier Martinez Canillas
2020-05-12 18:45 ` Jerry Snitselaar
2020-05-12 20:08 ` Matthew Garrett
2020-05-14 10:53 ` Jarkko Sakkinen
2020-05-14 11:28 ` Loïc Yhuel
2020-05-14 11:31 ` Ard Biesheuvel
2020-05-15 0:03 ` Jarkko Sakkinen [this message]
2020-05-14 11:33 ` Javier Martinez Canillas
2020-05-14 12:28 ` Ard Biesheuvel
2020-05-14 12:56 ` Javier Martinez Canillas
2020-05-14 13:04 ` Ard Biesheuvel
2020-05-14 13:51 ` Javier Martinez Canillas
2020-05-14 18:06 ` Matthew Garrett
2020-05-15 15:55 ` Loïc Yhuel
2020-05-22 18:30 ` [tip: efi/urgent] " tip-bot2 for Loïc Yhuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dadd27c89860c03d6c2eb0922838ef3e29e8f9b.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ardb@kernel.org \
--cc=javierm@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=loic.yhuel@gmail.com \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.