From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934117AbcJUNj7 (ORCPT ); Fri, 21 Oct 2016 09:39:59 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35234 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932745AbcJUNj5 (ORCPT ); Fri, 21 Oct 2016 09:39:57 -0400 Subject: Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size To: Maxime Ripard References: <20161019140234.13518-1-woogyom.kim@gmail.com> <20161019140234.13518-4-woogyom.kim@gmail.com> <20161020155641.b3erji5vrkk3wvia@lukather> Cc: Mark Brown , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org From: Milo Kim Message-ID: <7dbf6c9f-361b-9e31-8305-469ba4f274a8@gmail.com> Date: Fri, 21 Oct 2016 22:39:52 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161020155641.b3erji5vrkk3wvia@lukather> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/21/2016 12:56 AM, Maxime Ripard wrote: >> -static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi, int len) >> > +static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi) >> > { >> > + int len = sspi->fifo_depth; >> > u32 reg, cnt; >> > u8 byte; > I'm not so sure about this one. This function was initially to drain > any given number of bytes, which might be of interest at some point. > > Removing that argument also remove that ability... Any particular > reason you want to change it? I just wanted to remove duplicate variable but I agree with you. Let me drop this in the next patch-set. Thanks for your comments. Best regards, Milo