* [PATCH] auto-t: testFT-PSK-roam wait for connected
@ 2021-02-03 21:00 James Prestwood
2021-02-04 2:06 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2021-02-03 21:00 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Rather than assert its better to wait for a connected
state.
---
autotests/testFT-PSK-roam/connection_test.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/autotests/testFT-PSK-roam/connection_test.py b/autotests/testFT-PSK-roam/connection_test.py
index 8e69fcd5..a7acf495 100644
--- a/autotests/testFT-PSK-roam/connection_test.py
+++ b/autotests/testFT-PSK-roam/connection_test.py
@@ -90,7 +90,8 @@ class Test(unittest.TestCase):
condition = 'obj.state != DeviceState.roaming'
wd.wait_for_object_condition(device, condition)
- self.assertEqual(device.state, iwd.DeviceState.connected)
+ condition = 'obj.state == DeviceState.connected'
+ wd.wait_for_object_condition(device, condition)
self.assertTrue(self.bss_hostapd[1].list_sta())
testutil.test_iface_operstate(device.name)
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] auto-t: testFT-PSK-roam wait for connected
2021-02-03 21:00 [PATCH] auto-t: testFT-PSK-roam wait for connected James Prestwood
@ 2021-02-04 2:06 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2021-02-04 2:06 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
Hi James,
On 2/3/21 3:00 PM, James Prestwood wrote:
> Rather than assert its better to wait for a connected
> state.
> ---
> autotests/testFT-PSK-roam/connection_test.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 21:00 [PATCH] auto-t: testFT-PSK-roam wait for connected James Prestwood
2021-02-04 2:06 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.