From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbdKFQiM (ORCPT ); Mon, 6 Nov 2017 11:38:12 -0500 Received: from mail-co1nam03on0047.outbound.protection.outlook.com ([104.47.40.47]:54924 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752315AbdKFQiJ (ORCPT ); Mon, 6 Nov 2017 11:38:09 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Tom Lendacky , x86@kernel.org Subject: Re: [Part2 PATCH v7 33/38] KVM: SVM: Add support for SEV DEBUG_ENCRYPT command To: Borislav Petkov References: <20171101211723.71594-1-brijesh.singh@amd.com> <20171101211723.71594-4-brijesh.singh@amd.com> <20171106113105.qvw5wq7qts3ak5c2@pd.tnic> From: Brijesh Singh Message-ID: <7dcacb08-2a08-c902-691c-a454a3737aca@amd.com> Date: Mon, 6 Nov 2017 10:38:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171106113105.qvw5wq7qts3ak5c2@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR1701CA0014.namprd17.prod.outlook.com (10.172.58.24) To CY1PR12MB0152.namprd12.prod.outlook.com (10.161.173.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee3e17b2-df2b-4afd-1c11-08d52534c1b2 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603249);SRVR:CY1PR12MB0152; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;3:/bcycxe7LuvjBAKFnYY9nJFspQII0I1RHeUOpDw9QjEU4cS3iEV07LXPkfX8+q7SFP9xkdx9XY5PHDdgCGEiWj4T/YsqfxeSl878zwClojXgiWReG6UCrwqHM9dBthgtN78sE5418cGj5M1yEDNIb4mF4KQqpA/4PPChozuaZzT531ym5d+RvZjxi6V36k5Pk+lT4zoS3KDgb8bmZOkMnfrcTfGkbYo3WVRSzGsLQnKxWsG08MtOp9x1O7FMoMKZ;25:pGUL2mcemTAZlhKg8mOgdI0U8crFeu2hiupYi8fwaTFvUqR2mbbGICJ4u4UlrG4bCo2cKh8eVz4CQJpyfYfGJKyHCbkX6eqazNYeUAsk+7wK5kz3t3oD49MwURPHr03xc8ELtzIB6W19Q0BukoWiBtkFZLJPMsGEOLkzKUT1zxzudYOCmZm80IBr0OtYT++6HAv9dY95eGyVEbguXJ4oV0YprtW6pg+IDdsSn3OMF49nMcvEH/GD3lxbuJ5uACAzzgObhD1Hq+yvXdZ5QLIBhlIj90ufK+zQZNJihzgY36NJlg05idtdgxk8oG1y301sS/+yn9kYMBDbQTnQzM6Uvg==;31:pXTcFuNlQrrxu/avsJWokxfE76OHBnWELuAuOj6TOZKZdqgvk8Evcd5Yw32ysJ9N4sVAWdV+dsn3ex5/WfQi4cPrRMyQyU+Li5pz9eOS390m6ChFvWX6y7xP1I9A3P6mpP2z/fssrJ3HdHQa6tUz+2XkNEqz8xTbK9WRh74zvqB+FeVAPNgJJU2VK9HnNZEFIHR2DNQHxBB8GqcwvIigjnFfAXRRFeEBOFrx0kwlDXs= X-MS-TrafficTypeDiagnostic: CY1PR12MB0152: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:37H7Li+O4BD9hwahD5F3K1V5Pc8DxAt08F4GEAImidr47ZPAPo7AAijJrdssaDzdXEE9RRB6FWlW2DQ3ZR8AOx9N5T7QlqozgIvUw3mGZq7AUQv8+zvXQTrqZYXkW7Ovg6AAimb5Lhtp1okLJW4ow65v33eqyXoFiU7pWD+IS7xx2Bx3vwMl/MPqKbfa0ovSDeqtk/SVRzR2E+WmtD7wtkBLf59gLVbo9yFhPWHdjPgYogyTO3AyMAHw70E2XBrXAEAj59bW8uu3qJR3XkkfwxMj6UQY1XAgImY0o3GLQMqpQmo4QswsbIh0Y5l+JEePDHvBaBxJWuM5z/RP2vzGekLflOdlfsmXVujybM58lDEjqWCCdphcgflsy1PvdRgjc1v9RwycKcpnPX12Dmgc2X9prCcHLLL/T1wNjFPakck1oDgy+/ZxfZRaUmt6qfc2w29dvKArZZlQxX220+0AosuxgPLc4+w4dAZpYUgP8qJh7x9U7sQu/Hi5vzBQ0ajN;4:d7FrDysxICNKpU0sVqAzeB/vEW05G/76eHy/comhOeYzY9PQ40WtY3QVZ9hSu3pUT8CoQ28lZ/zBmC0fhcOa3tfGOd9FF9O4totWxLGATK8zBF7X3Z3Sakipp0SBfmqnJwTo9ZWvPs7Tj1HG55hwJfzujefh6q6cJizFQDyQcODp0XdJ8gJD7E2Uz3E5E5gq9Fv/c1PDN/kRFyzo71LMn6PTpZAb26Gp/nXc1AtEGRupMpo49c8Z0cBoMHue/+wpyQ1orhCP87MEWGEFKzHPYA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231021)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0152;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0152; X-Forefront-PRVS: 048396AFA0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(39860400002)(376002)(199003)(24454002)(189002)(50986999)(4326008)(66066001)(7736002)(65806001)(65956001)(83506002)(305945005)(189998001)(25786009)(47776003)(2906002)(53546010)(81166006)(86362001)(33646002)(81156014)(105586002)(68736007)(106356001)(8676002)(31696002)(229853002)(6246003)(54356999)(76176999)(8936002)(478600001)(6486002)(90366009)(230700001)(58126008)(50466002)(54906003)(31686004)(97736004)(16526018)(65826007)(6916009)(64126003)(2950100002)(23676003)(67846002)(6666003)(7416002)(5660300001)(77096006)(101416001)(53936002)(6116002)(3846002)(16576012)(316002)(36756003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0152;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUyOzIzOm83MXprVmo1eEtSUFcrSmRjR2Y5OU1pQmp1?= =?utf-8?B?Rk5DWUh6ZGwzRDRsd2ErTVhTdWJJYi91alBDK1M3UEFxd2xBWXlOZEt5bWhw?= =?utf-8?B?eURaV1dYRUNnNjVUTE8ya1lVQVBPQmMwMHg3L0ZlRkdrNmtPaHh2VERLOFht?= =?utf-8?B?dEp2eU00U0ZjeGpGeW0xQXdyeGdENkFVL25VdC80bmU2OXlBd2Y4dGNOU1oz?= =?utf-8?B?QUpNbW1QUDd1cUZrOTVKQmp2Z2g4NTgrQWpIVjdRdm9jSW93c2dTUjk2aEhi?= =?utf-8?B?VmcxUXU2dXowR1hBUmlmZlVzcklKemczbTlydDMrUm42SzR4dkFSckpzMUNk?= =?utf-8?B?ODBJaE9FZzk2NUFZOFhtUkFPK1pKM1pmTVZpSWdGNzRycy9xQkJmeVdXRzhX?= =?utf-8?B?ZjRwQVVJL1dzNUozMzhnODNYK0hDdFJqREJRTXlhRDVvcEhvSzJ3YTYwQ1Fq?= =?utf-8?B?bHJwZnZER1V0cHNjcVRNT3UyOE1JVGdBYjRYcWJJN20ybGQzOWFwTEE4bkRJ?= =?utf-8?B?Umt2amJmS2tqYmR1WEpSYnVKOUJTbVBMb2pyd3JnWlFCSWFMSCtKay9FQTdG?= =?utf-8?B?Smk4c0I5RXNHVjk0NXdxTktHR2oxRzNiZDBkdFJrcHVyMWUyL2phNXRYL0M4?= =?utf-8?B?RUlYenhxWkVXNkJoOG4vSHFsZFM5S0UyM25oanRaQi9iR1ZNRHV6dTFwelJK?= =?utf-8?B?Z0s2V3JtSzdyZHJaTEd3QnZzUlNVcGs3ZFYycFQ3MzFaZDBJeWlLSUNQQnNJ?= =?utf-8?B?bWRIUHp3MWRPek02djV2ZTFJenZiSlZsclorQmdhcHFnVG9yOTREdzVPVVpj?= =?utf-8?B?VXdrOWxlY3hUQXlXL1ByQVg4UXRPUHpsM0ppaFJFWklnZFdQekMyeG5XUWNV?= =?utf-8?B?ZnRlVWdpWWNkcGhoZ0FpZmhsRzZRbW5VMmpIVzlwcFc1aWp1ekczRUxoQWVI?= =?utf-8?B?TDN1ZmkrMWZpM096TVhGMXQ0Uld5cCtpeHVOMlJsZmxlWGpVVUZZZUE1Qnlj?= =?utf-8?B?Tkp1MUtuUTV5NS9lbng3SCtmY2dXREhXQ2UrbC9aNjBueXhwYjBkZmRtcGJN?= =?utf-8?B?WUhpS2pDbWQ0Z0RZOWh1OGtCeU11UnhBR1VTNVE1U09jOE91NFBEUm52VHhZ?= =?utf-8?B?L0U3dU91QjJyOXBuTDNVUVZZNTBUOWllejZSa1A0clBLV3VQVVA5Tm1JRWdT?= =?utf-8?B?L01LV1AvRkV6a3V5aUpJS2NxdHdETzN1OHpvRWYwOVRIWjJVUllNS3kzam0z?= =?utf-8?B?L09BUHdKcitDYUpFc095M0Y1dURnTmNRekdtQStWSEZTSnBXTEs1b0s2VVAr?= =?utf-8?B?MjNPbFJ2eEt5TEFrSzNJa2dBa1BBdEs5TEVpa2lJcXQ0ZGZzank2QnhmQkNi?= =?utf-8?B?TnU3QXY5c0RDTVBjRk91cTAxRHN5VGRNaTBOSjFsWlplSUlCODFWSGdSNFVC?= =?utf-8?B?aldtVHVHWi9BV1Y4Y0hhSm12MDR5bWxpN09OZ0V6aXpjY1R2RDdQZmRTM2Jt?= =?utf-8?B?RmJ5Skd0YXBMUlU4eHlWWlJTa0VCbTFCUzJyaTB6ZUJ4NS9JSnI1ZHRyd0pH?= =?utf-8?B?Uyt4Ukc5ZWFnRVdTUE5ZSTJTem1neXVGK0VqbXRzdTR6RHp1by82ajB5Mnh6?= =?utf-8?B?MDExenZrWnlvZnR1ZTVJQnVOZkYydWwrZTFpL0FKNkh1akhvMmtLak4wdDBP?= =?utf-8?B?R3grV0ZtRDEwSWc4MW92Vno4TVJBWnE2dzhmb2Y2U3d3N0czZVg1OUVnV0Vr?= =?utf-8?B?NGNLNTI5VzkvUHM5Z2NlZ1BLQjVjRkZhWTg2ZzBaVEZkYlpUVysxOWlMekxZ?= =?utf-8?B?N21VV3Fqb2lCOHRUM3FaQ09WWlF5YlhDdmFtQjZ2MCtVQXJ2Q2xyMTlyRmht?= =?utf-8?B?cFpIbWQyQk5mRnJ2dmxMdkk3U1I3NFp4dUtlMTJLbUh0RE1wdS9IRDB6Ykkx?= =?utf-8?B?U2NQU2Irc0dnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;6:MDks2EBVR+orXkFPvNOxKEk7rvAFOjeO8VSLClBxwvkxudoJh2cGnxETq3FF2Ss6De1ZGIdgeqqb0qWPIciTYkrTZmj1U/YkCw2SFe+MSj1ypaYN59p3KM4CqCvVs6wclUUAcnU4s7IR5uNAJE8YCXAYq3ilib97w3ZnWVGCkLgAUgMA495hLVRi3CskctjOk2P1eUBcII2qGMlpevz7ffYMTKcLJhishdk/B8Gsrbcl30uThYl+YPlr6CcfpUXI2DjuwLVOpihmWYnJRBcscdPLm2v9XLKf7hoL+PvYeTj6KquyC7fzhKbTbfwNSQ34FqareMrFfCtoLcTQQj76FuZ0w9LZCIbnz1hCb8c6l+8=;5:JSyqWe4L/No4/BfhrGoQC0zOkoPRBl8LOvr28Jhw4t//BnARGReJTiHuS8pXT3YSgqKxUJ6B93e0YpCcU8ehmqRGN3yCMoOfcyWnrr1Af5UKOAVql0SEuiAlnUCkoV4zc9eIWftf8fe6zrU0K7VyiuKKPHCppO01Qlt7ehCMnrM=;24:xS2EgFT7LS0hMBuhhAKNlwQ2/dxzFdJFmoswr04c13cTEry7nu3vCXiPihXgNC1gSQKIBEDSNvKnqNj4reJJrqePmhb2eiDu/4qqSAC8hRw=;7:Vu/oBu96eq9XtP9AuNAtj5acAdMA7adhrmgH74TPU+qSRLugVwduysXbDB0gbvU2qlx3r5DVY7GQIKlrvuL54eBzQghVrEbU6YW92tgIc9O746IlqRjotJLcIdIOr5Mte9cUhd0+CBZo9tZPRXCOQEsdOUgzmKik1G/AwImYlo8E+4O0r0kzwf8eOELeRCn2pAvlEUe3u7nq2N36cbFOzMpKCIHzxyX6cCBYm7Bmgy2pgmX2SRFkwv/6K0mjn5qQ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:gz+5VLoOJJ6bWx6TrOEDmmESRPp+Q2GedUeJLqoFqbn5wq9FdaUquJR1afi0nLDkcLvssOaZtnPB/AsFkIUexu/W7iVJ/1bBF/ZZNUWRzf12o7ZRf7jUlUFLO0vgeKkYE1/kWZtSQ5tN4XrtwsB0x+wIxTnNz4mrfvGCnoXg50Pql+08CFqKN+evBNUkpQQVnI31NnuoePSerz7OaI11hr3eLva/fPjJQRq4ey03AEyegNP7QJIHyr+KNsLnkpBO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2017 16:38:04.9745 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee3e17b2-df2b-4afd-1c11-08d52534c1b2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2017 05:31 AM, Borislav Petkov wrote: ... >> - ret = sev_dbg_decrypt_user(kvm, >> - __sme_page_pa(src_p[0]) + s_off, >> - dst_vaddr, >> - __sme_page_pa(dst_p[0]) + d_off, >> - len, &argp->error); >> + if (dec) >> + ret = sev_dbg_decrypt_user(kvm, >> + __sme_page_pa(src_p[0]) + s_off, >> + dst_vaddr, >> + __sme_page_pa(dst_p[0]) + d_off, >> + len, &argp->error); >> + else >> + ret = __sev_dbg_encrypt_user(kvm, >> + __sme_page_pa(src_p[0]) + s_off, >> + vaddr, >> + __sme_page_pa(dst_p[0]) + d_off, >> + dst_vaddr, >> + len, &argp->error); > > sev_dbg_decrypt_user but __sev_dbg_encrypt_user, with the "__" ?? > yes they both should be "__", I will overlooked it and will fix in next rev.