From: Matthieu Baerts <matthieu.baerts at tessares.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH mptcp-next] mptcp: use rightmost 64 bits in ADD_ADDR HMAC
Date: Tue, 19 May 2020 17:11:09 +0200 [thread overview]
Message-ID: <7dd1f4ae-c6dd-c1f9-375c-d644cf7e8b22@tessares.net> (raw)
In-Reply-To: 20200519003050.GW45434@MacBook-Pro-64.local
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Hi Todd,
On 19/05/2020 02:30, Christoph Paasch wrote:
> On 18/05/20 - 15:29:16, Todd Malsbary wrote:
>> This changes the HMAC used in the ADD_ADDR option from the leftmost 64
>> bits to the rightmost 64 bits as described in RFC 8684, section 3.4.1.
>>
>> Signed-off-by: Todd Malsbary <todd.malsbary(a)linux.intel.com>
>
> Nice find!
Yes, good catch!
Reviewed-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
I guess we should send that to -net branch, ideally before the release
of v5.7, not to introduce incompatibilities between versions. What do
you think?
> I found this while adding support to packetdrill for the ADD_ADDR v1
> option. The computation I used for the HMAC in the pending
> packetdrill work gave a different result than what was being computed
> by the kernel.
Good to hear you are looking at adding ADD_ADDRv1 support to packetdrill! :)
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
next reply other threads:[~2020-05-19 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 15:11 Matthieu Baerts [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 16:15 [MPTCP] Re: [PATCH mptcp-next] mptcp: use rightmost 64 bits in ADD_ADDR HMAC Mat Martineau
2020-05-20 15:54 Christoph Paasch
2020-05-20 2:00 Todd Malsbary
2020-05-20 1:09 Christoph Paasch
2020-05-19 16:26 Matthieu Baerts
2020-05-19 16:00 Todd Malsbary
2020-05-19 0:30 Christoph Paasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd1f4ae-c6dd-c1f9-375c-d644cf7e8b22@tessares.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.