From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next v2 16/21] net/ipv6: Add gfp_flags to route add functions Date: Wed, 18 Apr 2018 10:06:58 -0700 Message-ID: <7dd4a7ae-f940-70fd-fab8-3376d4662f70@gmail.com> References: <20180418003327.19992-1-dsahern@gmail.com> <20180418003327.19992-17-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, idosch@idosch.org, roopa@cumulusnetworks.com, eric.dumazet@gmail.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org To: David Ahern , netdev@vger.kernel.org Return-path: Received: from mail-pl0-f44.google.com ([209.85.160.44]:43318 "EHLO mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbeDRRHA (ORCPT ); Wed, 18 Apr 2018 13:07:00 -0400 Received: by mail-pl0-f44.google.com with SMTP id a39-v6so1479401pla.10 for ; Wed, 18 Apr 2018 10:07:00 -0700 (PDT) In-Reply-To: <20180418003327.19992-17-dsahern@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 04/17/2018 05:33 PM, David Ahern wrote: > Most FIB entries can be added using memory allocated with GFP_KERNEL. > Add gfp_flags to ip6_route_add and addrconf_dst_alloc. Code paths that > can be reached from the packet path (e.g., ndisc and autoconfig) or > atomic notifiers use GFP_ATOMIC; paths from user context (adding > addresses and routes) use GFP_KERNEL. > > Signed-off-by: David Ahern > --- Hmmm.... ipv6_ifa_notify() calls __ipv6_ifa_notify() under rcu_read_lock_bh()/rcu_read_unlock_bh() So using GFP_KERNEL in __ipv6_ifa_notify() is certainly not allowed.