From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIYCT-0000l7-NL for qemu-devel@nongnu.org; Tue, 15 May 2018 07:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIYCI-0002Nt-0R for qemu-devel@nongnu.org; Tue, 15 May 2018 07:33:01 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:55799) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fIYCH-0002LM-4M for qemu-devel@nongnu.org; Tue, 15 May 2018 07:32:49 -0400 References: <1526383058-49501-1-git-send-email-imammedo@redhat.com> From: Laurent Vivier Message-ID: <7dd6b2d6-73f8-706e-9083-884ce478d784@vivier.eu> Date: Tue, 15 May 2018 13:32:33 +0200 MIME-Version: 1.0 In-Reply-To: <1526383058-49501-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] linux-user: update comments to point to cpu_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: riku.voipio@iki.fi Le 15/05/2018 à 13:17, Igor Mammedov a écrit : > cpu_init() was replaced by cpu_create() since 2.12 but comments > weren't updated. So update stale comments now. > > Signed-off-by: Igor Mammedov > --- > bsd-user/main.c | 2 +- > linux-user/main.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bsd-user/main.c b/bsd-user/main.c > index 283dc6f..a6ef4a7 100644 > --- a/bsd-user/main.c > +++ b/bsd-user/main.c > @@ -917,7 +917,7 @@ int main(int argc, char **argv) > envlist_free(envlist); > > /* > - * Now that page sizes are configured in cpu_init() we can do > + * Now that page sizes are configured in cpu_create() we can do > * proper page alignment for guest_base. > */ > guest_base = HOST_PAGE_ALIGN(guest_base); > diff --git a/linux-user/main.c b/linux-user/main.c > index 3234754..27d0b37 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -693,7 +693,7 @@ int main(int argc, char **argv, char **envp) > envlist_free(envlist); > > /* > - * Now that page sizes are configured in cpu_init() we can do > + * Now that page sizes are configured in cpu_create() we can do > * proper page alignment for guest_base. > */ > guest_base = HOST_PAGE_ALIGN(guest_base); > I think page size is now configured in tcg_exec_init() since: commit 26a5f13b8eb1281d0552fe323e869806f3cefbfb Author: bellard Date: Wed May 28 12:30:31 2008 +0000 variable dynamic translation buffer size Strangely comment has been added after this change by: commit 379f6698d73f476de38682b3ff96ecb226728c43 Author: Paul Brook Date: Fri Jul 17 12:48:08 2009 +0100 Userspace guest address offsetting Thanks, Laurent