From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Traynor Subject: Re: [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function Date: Tue, 12 Sep 2017 17:31:09 +0100 Message-ID: <7de69ba5-3dfc-2e2d-5106-5eb050148bc5@redhat.com> References: <1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-3-git-send-email-markus.theil@tu-ilmenau.de> <20170912081604.GB40060@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Markus Theil , dev@dpdk.org, stephen@networkplumber.org, nicolas.dichtel@6wind.com To: Bruce Richardson , Ferruh Yigit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 20D4E1396 for ; Tue, 12 Sep 2017 18:31:13 +0200 (CEST) In-Reply-To: <20170912081604.GB40060@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/12/2017 09:16 AM, Bruce Richardson wrote: > On Mon, Sep 11, 2017 at 06:56:39PM +0100, Ferruh Yigit wrote: >> On 9/5/2017 1:04 PM, Markus Theil wrote: >>> The patch which introduced the usage of pci_alloc_irq_vectors >>> came after the patch which switched to non-threaded ISR (f0d1896fa1), >>> but did not use non-threaded ISR, if pci_alloc_irq_vectors >>> is used. >>> >>> Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for >>> MSI-X") >>> Cc: nicolas.dichtel@6wind.com >>> >>> Signed-off-by: Markus Theil >>> --- >>> lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> index 93bb71d..6885e72 100644 >>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> @@ -331,6 +331,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev) >>> #else >>> if (pci_alloc_irq_vectors(udev->pdev, 1, 1, PCI_IRQ_MSIX) == 1) { >>> dev_dbg(&udev->pdev->dev, "using MSI-X"); >>> + udev->info.irq_flags = IRQF_NO_THREAD; >> >> IRQF_NO_THREAD seems has been introduced in 2.6.39, so using this flag >> causing build error for kernel versions < 2.6.39. >> >> btw, the flag is already in use, so issue is not related to this patch. >> >> In DPDK documentation supported Linux kernel version is >= 2.6.34 [1]. >> >> We should either increase supported version to 2.6.39, or update igb_uio >> code. >> >> I am for increasing minimum supported kernel version to 2.6.39, any >> objection / comment? >> >> 2.6.39 released on May 2011 >> 2.6.34 released on May 2010 >> > > Only thing I can think of here is: > * is the necessary support for this in RHEL 6.x series It doesn't look to be there > * anyone still care about RHEL 6 support? > Not an issue with DPDK packages as igb_uio is not included. If someone was using RHEL6/CentOS6 and igb_uio from DPDK source then seems like it would be an issue for them. In general, a deprecation notice would be a good idea if the minimum kernel version is changing. > /Bruce >