From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0482EC433F5 for ; Fri, 8 Oct 2021 05:52:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FB6C60F70 for ; Fri, 8 Oct 2021 05:52:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5FB6C60F70 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 90D6083390; Fri, 8 Oct 2021 07:52:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633672366; bh=JToiHdunJ8LZ6/VL02KZsZJZBwC4ikepuSRLzPZbgYc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dST/mhI5TMJm+dDOZ2HPBLLIBZ1KtSaxaAir9ZspkcazetIkFS6wtAo3LtjdBzNq2 ObAyTnKsY2J5jCYQ6hmF07YD63R6GSm6S2OMBP8jPlXcDzqpomyJoIB6fVX634iRdS zWVefn8ezozr1zQTygsaXZfmnbG+/zL3P+jmB6y1N/nDgr0JtYOecuKZZLu+dedPnU hLQd/SteKP/MW2VsZskKWnpYXqVPiD+vvSNzyemJxyz5c58YHcm4QEa5QK2QHkfHu4 OWO8S/gzJMHLr3tg4zCxk/wSeZ6W6qYe79U4zrAtOqaGxXXXvpJj7mf+ofKp6B4DtT +GFztHMo9kWMA== Received: by phobos.denx.de (Postfix, from userid 109) id AD74D8337C; Fri, 8 Oct 2021 07:52:44 +0200 (CEST) Received: from mout-u-205.mailbox.org (mout-u-205.mailbox.org [91.198.250.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 12BB08337C for ; Fri, 8 Oct 2021 07:52:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-205.mailbox.org (Postfix) with ESMTPS id 4HQcm871Y7zQkwj; Fri, 8 Oct 2021 07:52:40 +0200 (CEST) Subject: Re: [PATCH 1/5] pci: Skip configuring PCI Rom Address for unsupported header types To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Simon Glass , Vladimir Oltean , Bin Meng Cc: u-boot@lists.denx.de References: <20211007125101.21811-1-pali@kernel.org> From: Stefan Roese Message-ID: <7deb4cbf-02c6-3769-8493-652a0c72d452@denx.de> Date: Fri, 8 Oct 2021 07:52:37 +0200 MIME-Version: 1.0 In-Reply-To: <20211007125101.21811-1-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 11D3E188F X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 07.10.21 14:50, Pali Rohár wrote: > PCI Rom Address is currently supported only for Normal (0x00) and > Bridge (0x01) header types. Fix code accordingly. > > Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/pci/pci_auto.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pci_auto.c b/drivers/pci/pci_auto.c > index 08082460eb86..288f7996c7c0 100644 > --- a/drivers/pci/pci_auto.c > +++ b/drivers/pci/pci_auto.c > @@ -131,7 +131,8 @@ static void dm_pciauto_setup_device(struct udevice *dev, int bars_num, > /* Configure the expansion ROM address */ > dm_pci_read_config8(dev, PCI_HEADER_TYPE, &header_type); > header_type &= 0x7f; > - if (header_type != PCI_HEADER_TYPE_CARDBUS) { > + if (header_type == PCI_HEADER_TYPE_NORMAL || > + header_type == PCI_HEADER_TYPE_BRIDGE) { > rom_addr = (header_type == PCI_HEADER_TYPE_NORMAL) ? > PCI_ROM_ADDRESS : PCI_ROM_ADDRESS1; > dm_pci_write_config32(dev, rom_addr, 0xfffffffe); > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de