From: Eric Blake <eblake@redhat.com>
To: Olaf Hering <olaf@aepfle.de>, qemu-trivial@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Fam Zheng" <famz@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux
Date: Wed, 18 Apr 2018 10:04:03 -0500 [thread overview]
Message-ID: <7df49e91-aa65-d775-78eb-ddf53676dd7f@redhat.com> (raw)
In-Reply-To: <20180418145443.6332-1-olaf@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
On 04/18/2018 09:54 AM, Olaf Hering wrote:
> Since usage of g_realloc_n was introduced, glib-2.22 can not be used
> anymore on Linux. Leave non-Linux unchanged because one developer system
> still uses it.
> Fixes commit 418026ca43 ("util: Introduce vfio helpers")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> configure | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Rather than hacking configure, why not fix util/vfio-helpers.c to avoid
g_realloc_n()? We've done it before; see commit 071d405
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-04-18 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 14:54 [Qemu-devel] [PATCH v2] configure: require glib-2.24 on Linux Olaf Hering
2018-04-18 15:04 ` Eric Blake [this message]
2018-04-18 15:31 ` Olaf Hering
2018-04-18 15:37 ` Olaf Hering
2018-04-18 15:05 ` no-reply
2018-04-18 15:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7df49e91-aa65-d775-78eb-ddf53676dd7f@redhat.com \
--to=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=olaf@aepfle.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.