All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: fred.konrad@greensocs.com, qemu-trivial@nongnu.org,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] ppc_booke: drop useless assignment
Date: Sat, 25 Mar 2017 11:58:48 +0100	[thread overview]
Message-ID: <7e150e14-dfb1-7dda-fb1b-0d885b28b33b@vivier.eu> (raw)
In-Reply-To: <1490360147-26450-1-git-send-email-fred.konrad@greensocs.com>

Le 24/03/2017 à 13:55, fred.konrad@greensocs.com a écrit :
> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> The tb_env variable is set two lines above. So just drop the double assignment.
> 
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> ---
>  hw/ppc/ppc_booke.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c
> index 60baffa..23bcf1b 100644
> --- a/hw/ppc/ppc_booke.c
> +++ b/hw/ppc/ppc_booke.c
> @@ -282,7 +282,6 @@ void store_booke_tcr(CPUPPCState *env, target_ulong val)
>      ppc_tb_t *tb_env = env->tb_env;
>      booke_timer_t *booke_timer = tb_env->opaque;
>  
> -    tb_env = env->tb_env;
>      env->spr[SPR_BOOKE_TCR] = val;
>      kvmppc_set_tcr(cpu);
>  
> 
Reviewed-by: Laurent Vivier <laurent@vivier.eu>

  reply	other threads:[~2017-03-25 10:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 12:55 [Qemu-devel] [PATCH] ppc_booke: drop useless assignment fred.konrad
2017-03-25 10:58 ` Laurent Vivier [this message]
2017-04-22 17:56 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e150e14-dfb1-7dda-fb1b-0d885b28b33b@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=fred.konrad@greensocs.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.