All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gvt-dev@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 14/15] drm/i915/gvt: annotate maybe unused gma_bottom variables
Date: Fri, 26 May 2023 19:38:07 +0300	[thread overview]
Message-ID: <7e1c475bf123eca6935a1be099cc0608bed49b0b.1685119007.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1685119006.git.jani.nikula@intel.com>

Prepare for re-enabling -Wunused-but-set-variable.

Lacking a better idea, annotate the gma_bottom variables with
__maybe_unused.

Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: intel-gvt-dev@lists.freedesktop.org
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

Frankly I'm not sure what to do with these. Maybe the variables should
be dropped altogether?
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 3c4ae1da0d41..2801e17e5522 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -2833,7 +2833,7 @@ static int command_scan(struct parser_exec_state *s,
 
 static int scan_workload(struct intel_vgpu_workload *workload)
 {
-	unsigned long gma_head, gma_tail, gma_bottom;
+	unsigned long gma_head, gma_tail, __maybe_unused gma_bottom;
 	struct parser_exec_state s;
 	int ret = 0;
 
@@ -2874,7 +2874,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
 static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
 {
 
-	unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
+	unsigned long gma_head, gma_tail, __maybe_unused gma_bottom, ring_size, ring_tail;
 	struct parser_exec_state s;
 	int ret = 0;
 	struct intel_vgpu_workload *workload = container_of(wa_ctx,
-- 
2.39.2


  parent reply	other threads:[~2023-05-26 16:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 16:37 [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 01/15] drm/i915/plane: warn on non-zero plane offset Jani Nikula
2023-05-26 16:49   ` Ville Syrjälä
2023-05-26 17:22     ` Jani Nikula
2023-05-26 17:22   ` [Intel-gfx] [PATCH v2] " Jani Nikula
2023-05-27  0:27   ` [Intel-gfx] [PATCH 01/15] " kernel test robot
2023-05-27  0:27     ` kernel test robot
2023-05-27  1:50   ` kernel test robot
2023-05-27  1:50     ` kernel test robot
2023-05-29  9:24   ` Dan Carpenter
2023-05-29  9:24     ` Dan Carpenter
2023-05-29 10:04     ` Jani Nikula
2023-05-29 10:04       ` Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 02/15] drm/i915/ddi: drop unused but set variable intel_dp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 03/15] drm/i915/dsi: drop unused but set variable data Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 04/15] drm/i915/dsi: drop unused but set variable vbp Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 05/15] drm/i915/dpll: drop unused but set variables bestn and bestm1 Jani Nikula
2023-05-26 16:37 ` [Intel-gfx] [PATCH 06/15] drm/i915/fb: drop unused but set variable cpp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 07/15] drm/i915/irq: drop unused but set variable tmp Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 08/15] drm/i915/gt/uc: drop unused but set variable sseu Jani Nikula
2023-05-26 17:51   ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 09/15] drm/i915/gem: drop unused but set variable unpinned Jani Nikula
2023-05-26 17:35   ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 10/15] drm/i915/gem: annotate maybe unused but set variable c Jani Nikula
2023-05-26 17:50   ` Andi Shyti
2023-05-26 16:38 ` [Intel-gfx] [PATCH 11/15] drm/i915/selftest: annotate maybe unused but set variable unused Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 12/15] drm/i915: annotate maybe unused but set intel_plane_state variables Jani Nikula
2023-05-26 16:38 ` [Intel-gfx] [PATCH 13/15] drm/i915: annotate maybe unused but set intel_crtc_state variables Jani Nikula
2023-05-26 16:38 ` Jani Nikula [this message]
2023-05-29 14:36   ` [Intel-gfx] [PATCH 14/15] drm/i915/gvt: annotate maybe unused gma_bottom variables Wang, Zhi A
2023-05-26 16:38 ` [Intel-gfx] [PATCH 15/15] drm/i915: re-enable -Wunused-but-set-variable Jani Nikula
2023-05-26 19:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev2) Patchwork
2023-05-26 19:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-26 23:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev3) Patchwork
2023-05-26 23:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-29  9:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: re-enable -Wunused-but-set-variable (rev4) Patchwork
2023-05-29  9:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-29 14:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-07  9:35 ` [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable Hogander, Jouni
2023-06-07 10:37   ` Jani Nikula
2023-06-08  9:05     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e1c475bf123eca6935a1be099cc0608bed49b0b.1685119007.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.