From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753780AbdLFIfa (ORCPT ); Wed, 6 Dec 2017 03:35:30 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2211 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753356AbdLFIf3 (ORCPT ); Wed, 6 Dec 2017 03:35:29 -0500 Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events To: Andi Kleen References: <1512490399-94107-1-git-send-email-john.garry@huawei.com> <1512490399-94107-3-git-send-email-john.garry@huawei.com> <20171205172748.GI3070@tassilo.jf.intel.com> CC: , , , , , , , , , , , , , , , From: John Garry Message-ID: <7e209e42-362e-7767-2b94-62239c62e70d@huawei.com> Date: Wed, 6 Dec 2017 08:34:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20171205172748.GI3070@tassilo.jf.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2017 17:27, Andi Kleen wrote: > On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: >> For some architectures (like arm64), there are architecture- >> defined recommended events. Vendors may not be obliged to >> follow the recommendation and may implement their own pmu >> event for a specific event cod > > I would just duplicate the architected events into the different > vendor files. Then you wouldn't need all this mess. > This is what we were originally doing: https://patchwork.kernel.org/patch/10010859/ But then we thought that we could avoid duplicating all these events for every platform from every vendor. Most, if not all, vendors will implement the events as recommended for any platform, so much unnecessary duplication. cheers, John > -Andi > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: john.garry@huawei.com (John Garry) Date: Wed, 6 Dec 2017 08:34:59 +0000 Subject: [RFC PATCH 2/5] perf jevents: add support for arch recommended events In-Reply-To: <20171205172748.GI3070@tassilo.jf.intel.com> References: <1512490399-94107-1-git-send-email-john.garry@huawei.com> <1512490399-94107-3-git-send-email-john.garry@huawei.com> <20171205172748.GI3070@tassilo.jf.intel.com> Message-ID: <7e209e42-362e-7767-2b94-62239c62e70d@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/12/2017 17:27, Andi Kleen wrote: > On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: >> For some architectures (like arm64), there are architecture- >> defined recommended events. Vendors may not be obliged to >> follow the recommendation and may implement their own pmu >> event for a specific event cod > > I would just duplicate the architected events into the different > vendor files. Then you wouldn't need all this mess. > This is what we were originally doing: https://patchwork.kernel.org/patch/10010859/ But then we thought that we could avoid duplicating all these events for every platform from every vendor. Most, if not all, vendors will implement the events as recommended for any platform, so much unnecessary duplication. cheers, John > -Andi > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > . >