All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michel Thierry <michel.thierry@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/4] drm/i915/selftests: Include the start of each subtest in the GEM trace
Date: Fri, 13 Jul 2018 13:33:53 -0700	[thread overview]
Message-ID: <7e303b4f-d990-7aaa-ffca-8dd566e00113@intel.com> (raw)
In-Reply-To: <20180713201848.1495-2-chris@chris-wilson.co.uk>

On 7/13/2018 1:18 PM, Chris Wilson wrote:
> Knowing the boundary of each subtest can be instrumental in digesting
> the voluminous trace output and finding the critical piece of
> information.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Michel Thierry <michel.thierry@intel.com>
> ---
>   drivers/gpu/drm/i915/selftests/i915_selftest.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
> index addc5a599c4a..86c54ea37f48 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
> @@ -210,6 +210,8 @@ int __i915_subtests(const char *caller,
>   			return -EINTR;
>   
>   		pr_debug(DRIVER_NAME ": Running %s/%s\n", caller, st->name);
> +		GEM_TRACE("Running %s/%s\n", caller, st->name);
> +
>   		err = st->func(data);
>   		if (err && err != -EINTR) {
>   			pr_err(DRIVER_NAME "/%s: %s failed with error %d\n",
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-07-13 20:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 20:18 [PATCH 1/4] drm/i915/execlists: Check reset_in_progress() Chris Wilson
2018-07-13 20:18 ` [PATCH 2/4] drm/i915/selftests: Include the start of each subtest in the GEM trace Chris Wilson
2018-07-13 20:33   ` Michel Thierry [this message]
2018-07-13 20:18 ` [PATCH 3/4] drm/i915: Do not short-circuit tasklets during reset Chris Wilson
2018-07-13 20:18 ` [PATCH 4/4] drm/i915/execlists: Drop clear_gtiir() on GPU reset Chris Wilson
2018-07-13 20:32 ` [PATCH 1/4] drm/i915/execlists: Check reset_in_progress() Michel Thierry
2018-07-13 20:34 ` Chris Wilson
2018-07-13 20:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
2018-07-13 20:53 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e303b4f-d990-7aaa-ffca-8dd566e00113@intel.com \
    --to=michel.thierry@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.